Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: ambiguous attribute for button #1518

Merged
merged 1 commit into from
May 29, 2024
Merged

fix: ambiguous attribute for button #1518

merged 1 commit into from
May 29, 2024

Conversation

hamirmahal
Copy link
Contributor

fixes #1517.

PR Checklist

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

  • Code style update (formatting, local variables)

What is the current behavior?

New projects created from specific templates use a button without specifying the type attribute, which defaults to submit, not button, and that can be unexpected.

What is the new behavior?

Templates explicitly specify button type attributes as button.

Other information

Copy link

changeset-bot bot commented May 28, 2024

⚠️ No Changeset found

Latest commit: 75fcac6

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link
Contributor Author

@hamirmahal hamirmahal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Without these changes, people creating a new Solid project and using webhint will likely get a warning like this.

image

@ryansolid ryansolid merged commit 431feef into solidjs:main May 29, 2024
@ryansolid
Copy link
Member

Thanks

@hamirmahal
Copy link
Contributor Author

You're welcome.

@hamirmahal hamirmahal deleted the fix/ambiguous-attribute-for-button branch May 29, 2024 21:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug?]: Button type attribute has not been set. in templates
2 participants