Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: actual example of solid authjs #1658

Merged
merged 1 commit into from
Oct 23, 2024
Merged

fix: actual example of solid authjs #1658

merged 1 commit into from
Oct 23, 2024

Conversation

OrJDev
Copy link
Contributor

@OrJDev OrJDev commented Oct 23, 2024

PR Checklist

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

  • [-] Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • infrastructure changes
  • Other... Please describe:

What is the current behavior?

What is the new behavior?

Other information

Copy link

changeset-bot bot commented Oct 23, 2024

⚠️ No Changeset found

Latest commit: 7a26eb6

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@ryansolid
Copy link
Member

Thanks

@ryansolid ryansolid merged commit e45e499 into solidjs:main Oct 23, 2024
4 checks passed
@@ -1,3 +1,5 @@
import { defineConfig } from "@solidjs/start/config";

Copy link
Contributor

@birkskyum birkskyum Oct 28, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@OrJDev , the @solid-mediakit/auth-plugin is added in the list of dependencies, but it's not included in the app.config.ts here like shown in this docs of protected$, and I don't see any other usage of it. Is it an under-the-hood dependency, or should it be removed or installed wired up in the config?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants