Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: remove castError #2026

Draft
wants to merge 5 commits into
base: main
Choose a base branch
from
Draft

feat: remove castError #2026

wants to merge 5 commits into from

Conversation

lxsmnsyc
Copy link
Member

THIS IS A BREAKING CHANGE

This PR changes the behavior of Solid's error handling, mainly on the concept of "casting errors". Solid has an internal mechanism wrapping thrown values if the value isn't an Error instance.

Copy link

changeset-bot bot commented Jan 11, 2024

⚠️ No Changeset found

Latest commit: 51e085a

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@lxsmnsyc lxsmnsyc marked this pull request as draft January 11, 2024 16:51
@ryansolid
Copy link
Member

Why? It was this way before. We intentionally went to normalizing errors. I admit it was mostly for serialization so I could see the argument for reverting it now. But on the other hand I feel as much temptation to normalize farther to prevent serialization errors for things that random libraries pass us that can't be serialized.

@lxsmnsyc
Copy link
Member Author

@ryansolid it's not exactly that way before. We used to check if the error is truthy, and not if the error existed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants