Skip to content
This repository has been archived by the owner on May 22, 2024. It is now read-only.

Request: Support for Microsoft.Extensions.DependencyInjection <= Version 3.1.18 #67

Closed
cliveontoast opened this issue Aug 11, 2021 · 3 comments · Fixed by #71
Closed
Assignees
Labels
question Further information is requested

Comments

@cliveontoast
Copy link

Hi,

Thanks for creating this nuget package. My .net core 3.1 project is currently using Microsoft.Extensions.DependencyInjection Version 3.1.17. Is it possible for this nuget package to support lower versions?

When I downloaded the code and changed the line below, the tests still pass.

<PackageReference Include="Microsoft.Extensions.DependencyInjection" Version="3.1.18" />

I've not tried it in anger with my existing solution however.

It's not really a big issue, as I should update my projects, as Microsoft.Extensions.DependencyInjection 5+ is compatible with .net core 3.1.

@mbhoek
Copy link
Member

mbhoek commented Aug 11, 2021

Let me investigate and I'll get back to you by EBD tomorrow.

@mbhoek mbhoek self-assigned this Aug 11, 2021
@mbhoek mbhoek added enhancement New feature or request question Further information is requested and removed enhancement New feature or request labels Aug 11, 2021
@mbhoek
Copy link
Member

mbhoek commented Sep 3, 2021

Apologies for not getting back to you sooner @cliveontoast . I was trying to recreate your problem using the SpecFlow.DependencyInjection.Tests project and adding an explicit reference, but I was not able to reproduce your problem.

If you still need this to be resolved, could you create a test project and/or include the error messages you encountered?

@mbhoek mbhoek mentioned this issue Nov 8, 2021
mbhoek added a commit that referenced this issue Nov 11, 2021
In hindsight, requiring Microsoft.Extensions.DependencyInjection 5.0.1 or above was not necessary for this package.
Lowering it to 3.1.0 allows users to pick a broader range of MEDI packages without it impacting this package.

Fixes: #67
@mbhoek mbhoek mentioned this issue Nov 11, 2021
mbhoek added a commit that referenced this issue Nov 16, 2021
* Add 'net6.0' target (#70)
* Remove 'netcoreapp2.1' target
* Remove dependabot
* Lower MEDI dependency requirement to 3.1.0 (#67)
* Add README to NuGet (#47)
@cliveonfmgl
Copy link

Hi,
Sorry for not replying sooner. I kept on using AdCodicem.SpecFlow.MicrosoftDependencyInjection as it was happily working. But now that's no longer maintained (fair enough, two projects doing the same thing)

Now the project is sitting on .net 6, this isn't much of an issue for me anymore either :)

Cheers,
Clive

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
question Further information is requested
Development

Successfully merging a pull request may close this issue.

3 participants