Skip to content

Commit

Permalink
Merge pull request #3379 from nebulab/kennyadsl/sprockets-4-support
Browse files Browse the repository at this point in the history
Add support for Sprockets v4 to the DummyApp
  • Loading branch information
elia authored Jan 9, 2024
2 parents 9692a68 + 9c4057d commit 7bab27b
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 6 deletions.
6 changes: 1 addition & 5 deletions Gemfile
Original file line number Diff line number Diff line change
Expand Up @@ -12,11 +12,6 @@ else
end
# rubocop:enable Bundler/DuplicatedGem

# Temporarily locking sprockets to v3.x
# see https://github.com/solidusio/solidus/issues/3374
# and https://github.com/rails/sprockets-rails/issues/369
gem 'sprockets', '~> 3'

gem 'pry'
gem 'launchy', require: false

Expand All @@ -31,6 +26,7 @@ gem 'rspec-rails', '~> 6.0.3', require: false
gem 'rspec-retry', '~> 0.6.2', require: false
gem 'simplecov', require: false
gem 'simplecov-cobertura', require: false
gem 'rack', '< 3', require: false
gem 'rake', require: false, groups: [:lint, :release]
gem 'rails-controller-testing', require: false
gem 'puma', '< 6', require: false
Expand Down
5 changes: 4 additions & 1 deletion core/lib/spree/testing_support/dummy_app.rb
Original file line number Diff line number Diff line change
Expand Up @@ -34,8 +34,11 @@ module ApplicationHelper
module DummyApp
def self.setup(gem_root:, lib_name:, auto_migrate: true)
ENV["LIB_NAME"] = lib_name
DummyApp::Application.config.root = File.join(gem_root, 'spec', 'dummy')
root = Pathname(gem_root).join('spec/dummy')
root.join("app/assets/config").mkpath
root.join("app/assets/config/manifest.js").write("// Intentionally empty\n")

DummyApp::Application.config.root = root
DummyApp::Application.initialize! unless DummyApp::Application.initialized?

if auto_migrate
Expand Down

0 comments on commit 7bab27b

Please sign in to comment.