Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add covered_by_store_credit translation in en.yml #5208

Conversation

rainerdema
Copy link
Contributor

@rainerdema rainerdema commented Jul 3, 2023

Summary

This PR adds a new translation key 'covered_by_store_credit' in en.yml.
The new key provides a specific message to inform users when their order is fully covered by store credits and no additional payment method is required.
This change is connected to an update made in Solidus Starter Frontend: solidusio/solidus_starter_frontend#348

Checklist

Check out our PR guidelines for more details.

The following are mandatory for all PRs:

The following are not always needed:

  • 📖 I have updated the README to account for my changes.
  • 📑 I have documented new code with YARD.
  • 🛣️ I have opened a PR to update the guides.
  • ✅ I have added automated tests to cover my changes.
  • 📸 I have attached screenshots to demo visual changes.

This commit adds a new translation key 'covered_by_store_credit' in en.yml.
The new key provides a specific message to inform users when their order is fully
covered by store credits, and no additional payment method is required.
This change is connected to an update made in Solidus Starter Frontend:
solidusio/solidus_starter_frontend#348
@kennyadsl
Copy link
Member

@rainerdema did you consider adding this key to the starter fronted instead?

@elia
Copy link
Member

elia commented Jul 3, 2023

@rainerdema did you consider adding this key to the starter fronted instead?

This! I too think we should push translations out of core unless they're not strictly related to it.

@rainerdema
Copy link
Contributor Author

rainerdema commented Jul 3, 2023

@rainerdema did you consider adding this key to the starter fronted instead?

Sure @kennyadsl, but the starter frontend doesn't have a translations file and mainly uses those from the core at the moment.
Even though I'm not fond of this, since I only have to add one key, I've preferred to simply do it here with this small PR.
Let me know if there is another way to do this for the starter frontend.

Copy link
Member

@elia elia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This translation can open the way for having them in the starter solidusio/solidus_starter_frontend#348 (review)

@rainerdema
Copy link
Contributor Author

Closing, it will be addressed with #5212

@rainerdema rainerdema closed this Jul 3, 2023
@elia elia deleted the nebulab/rainerd/add-missing-translation-for-orders-fully-covered-by-store-credits branch July 3, 2023 11:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog:solidus_core Changes to the solidus_core gem
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants