Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Admin] Sidebar tweaks #5295

Merged
merged 2 commits into from
Aug 1, 2023
Merged

[Admin] Sidebar tweaks #5295

merged 2 commits into from
Aug 1, 2023

Conversation

elia
Copy link
Member

@elia elia commented Aug 1, 2023

Summary

Just a couple of small adjustments.

Checklist

Check out our PR guidelines for more details.

The following are mandatory for all PRs:

The following are not always needed:

  • 📖 I have updated the README to account for my changes.
  • 📑 I have documented new code with YARD.
  • 🛣️ I have opened a PR to update the guides.
  • ✅ I have added automated tests to cover my changes.
  • 📸 I have attached screenshots to demo visual changes.

@elia
Use the ui/icon component to render the sidebar arrow
34542bf
@elia
Open the current store within a blank page
85c2654 
This is generally expected when a right-up arrow is shown next to a
link.
@elia elia self-assigned this Aug 1, 2023
@elia elia requested a review from a team as a code owner August 1, 2023 12:08
@elia elia requested review from rainerdema and the-krg August 1, 2023 12:08
@github-actions github-actions bot added changelog:solidus_backend Changes to the solidus_backend gem changelog:solidus_core Changes to the solidus_core gem changelog:solidus Changes to the solidus meta-gem changelog:repository Changes to the repository not within any gem changelog:solidus_admin labels Aug 1, 2023
@elia elia changed the base branch from main to nebulab/admin August 1, 2023 12:18
@codecov
Copy link

codecov bot commented Aug 1, 2023 •
edited
Loading

Codecov Report

Merging #5295 (85c2654) into nebulab/admin (1b08fed) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@              Coverage Diff               @@
##           nebulab/admin    #5295   +/-   ##
==============================================
  Coverage          88.56%   88.56%           
==============================================
  Files                599      599           
  Lines              14563    14564    +1     
==============================================
+ Hits               12897    12898    +1     
  Misses              1666     1666
Files Changed Coverage Δ
.../app/components/solidus_admin/sidebar/component.rb 100.00% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@rainerdema rainerdema merged commit a90918b into nebulab/admin Aug 1, 2023
4 checks passed
@rainerdema rainerdema deleted the elia/admin/sidebar-tweaks branch August 1, 2023 15:46
@elia elia mentioned this pull request Aug 7, 2023
Closed
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rainerdema rainerdema rainerdema approved these changes

@the-krg the-krg Awaiting requested review from the-krg

Assignees

@elia elia

Labels
changelog:repository Changes to the repository not within any gem changelog:solidus_admin changelog:solidus_backend Changes to the solidus_backend gem changelog:solidus_core Changes to the solidus_core gem changelog:solidus Changes to the solidus meta-gem
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@elia @rainerdema