Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Admin] Fix user locale handling in SolidusAdmin #5303

Merged
merged 3 commits into from
Aug 4, 2023

Conversation

elia
Copy link
Member

@elia elia commented Aug 3, 2023

Summary

The current implementation was writing on the session key if the requested locale was empty and the session key was set.

Checklist

Check out our PR guidelines for more details.

The following are mandatory for all PRs:

The following are not always needed:

  • 📖 I have updated the README to account for my changes.
  • 📑 I have documented new code with YARD.
  • 🛣️ I have opened a PR to update the guides.
  • ✅ I have added automated tests to cover my changes.
  • 📸 I have attached screenshots to demo visual changes.

The previous implementation was writing on the session key if the
requested locale was empty and the session key was set.
@elia elia self-assigned this Aug 3, 2023
@elia elia requested a review from a team as a code owner August 3, 2023 16:44
@elia elia requested review from rainerdema and the-krg August 3, 2023 16:44
@codecov
Copy link

codecov bot commented Aug 3, 2023

Codecov Report

Merging #5303 (9ce3bc6) into nebulab/admin (7cd6dd5) will decrease coverage by 0.01%.
The diff coverage is 81.81%.

@@                Coverage Diff                @@
##           nebulab/admin    #5303      +/-   ##
=================================================
- Coverage          88.57%   88.56%   -0.01%     
=================================================
  Files                599      600       +1     
  Lines              14594    14604      +10     
=================================================
+ Hits               12926    12934       +8     
- Misses              1668     1670       +2     
Files Changed Coverage Δ
...rollers/solidus_admin/controller_helpers/locale.rb 76.47% <76.47%> (ø)
...n/app/controllers/solidus_admin/base_controller.rb 100.00% <100.00%> (+10.52%) ⬆️
...ntrollers/solidus_admin/controller_helpers/auth.rb 100.00% <100.00%> (ø)
admin/lib/solidus_admin/preview.rb 93.33% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@elia elia merged commit 7eba7c1 into nebulab/admin Aug 4, 2023
2 of 4 checks passed
@elia elia deleted the elia/admin/locale-fix branch August 4, 2023 09:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants