New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix the target pid of oomkill example, expose metrics by default #91

Merged

soloio-bulldozer merged 1 commit into solo-io:main from krisztianfekete:fix-oomkill-example

Dec 9, 2022

Contributor

krisztianfekete commented Oct 17, 2022

This PR

fixes getting the target PID in the oomkill example by using BPF_CORE_READ(oc, chosen, tgid) instead of getting the current pid
enables exposing the events as metrics by default, so people can just pull/use the upstream image. The cardinality of the labels in this case is low, so I think this is a sensible default.


          fix the target pid of oomkill example, expose metrics by default

7151fe2

krisztianfekete requested review from EItanya and lgadban

October 17, 2022 12:08

lgadban approved these changes

View reviewed changes

soloio-bulldozer bot merged commit d824192 into solo-io:main

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet