Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DFU mode: improve programming robustness. #98

Merged
merged 2 commits into from
Jan 20, 2021
Merged

DFU mode: improve programming robustness. #98

merged 2 commits into from
Jan 20, 2021

Commits on Jan 20, 2021

  1. DFU mode: improve programming robustness. 

    The ctrl_transfer in dfu.get_status() might return usb.core.USBError
with errno == EPIPE, seen when called in quick succession. This is the
case when called from dfu.block_on_state(). The next call usually works.

This change tries to catch this specific error and just re-tries up to
two times in case it happens.

Without this change, the error (and programming abort) might get
undetected, as 'click' catches IOerror/EPIPE silently. This has
significant potential to brick a device if you don't check the output
and return code of 'solo' closely enough.
    @enrikb @nickray
    enrikb authored and nickray committed Jan 20, 2021
    Configuration menu
    Copy the full SHA
    5af5aba View commit details
    Browse the repository at this point in the history

  2. Add CHANGELOG entry

    @nickray
    nickray committed Jan 20, 2021
    Configuration menu
    Copy the full SHA
    dff5668 View commit details
    Browse the repository at this point in the history