Fix u2f on fido2 #173
Merged
Fix u2f on fido2 #173
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If a user registers using U2F, and then later authenticates on a browser that only uses FIDO2, it won't work since Solo's CTAP2 and CTAP1 have different key handles/ids, and Solo CTAP2 doesn't attempt to use a CTAP1 key handle.
This update adds support for CTAP1 key handles in CTAP2, so the above scenario will work. Tests included. Tested it works by registering with U2F on Chrome, updating key, and then authenticating with FIDO2.