New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix make all target #482

Merged

conorpp merged 1 commit into solokeys:master from Ollrogge:fix_make_target

Jan 28, 2021

Contributor

Ollrogge commented Oct 29, 2020 •

edited

Loading

I tried to build the code as standalone application running following commands as stated in the README.md:

git clone --recurse-submodules https://github.com/solokeys/solo
cd solo
make all

this resulted in the following errors:

/solo/fido2/version.h:36: multiple definition of 'firmware_version'; fido2/libsolo.a(ctaphid.o):/solo/fido2/version.h:36: first defined here
/solo/fido2/device.c:29: multiple definition of 'RK_STORE'; pc/device.o:/solo/pc/device.c:31: first defined here

This pull requests fixes this issue.


          fix make all target

ac11eff

Member

conorpp commented Jan 28, 2021

Thank you!

conorpp merged commit d12ace5 into solokeys:master

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet