Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix return of cred protect value for resident ed25519 keys #568

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion fido2/ctap.c
Original file line number Diff line number Diff line change
Expand Up @@ -1494,7 +1494,7 @@ uint8_t ctap_cred_rk(CborEncoder * encoder, int rk_ind, int rk_count)
CTAP_residentKey rk;
ctap_load_rk(rk_ind, &rk);

uint32_t cred_protect = read_metadata_from_masked_credential(&rk.id);
uint32_t cred_protect = read_cred_protect_from_masked_credential(&rk.id);
if ( cred_protect == 0 || cred_protect > 3 )
{
// Take default value of userVerificationOptional
Expand Down