RDM Discovery Request and Request Updates #33
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It appears discovery isn't actually working. I don't think it has anything to do with the changes in this PR, however. All of the testing I've done with discovery has been with either one device on the RDM network, or multiple devices of the same type on the network. I'm now testing |
|
Whoops! It was definitely me that caused the problem lol. This is fixed now and I'm feeling much more confident that discovery works now. I've tested with two devices of different types and |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This updates the return types of
rdm_send_disc_unique_branch()andrdm_send_mute(). It also updates the logic for RDM requests so that response errors are properly handled.