Fix DMX transmit #42
Merged
Fix DMX transmit #42
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a major issue introduced in PR#41 that caused DMX receive interrupts to fire when DMX was transmitting resulting in corrupted data and packet sizes.
Changes include setting the DMX UART to "normal" mode rather than "RS-485" mode. These modes are not well-documented in the ESP32 technical reference manual. It was found that setting the UART to RS-485 mode would cause DMX receive interrupts to fire due to its own DMX transmissions. This would result in major data corruption. Packets over the size of 130 bytes could not be reliably sent; data slots would be repeated and packet sizes would be significantly larger than desired.