-
-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement RDM responder #61
Conversation
RDM response is working! The code still needs polish. Furthermore, the RDM response is useless for end-users; users are not able to configure settings on the RDM responder. This means that the RDM responder will always respond to messages the same way. But it supports the minimum required RDM responses, which is a pretty big milestone. The driver currently does not respond to invalid RDM requests, which would mean that RDM response is not yet fully supported in this library, but this should be trivial to implement. |
I ran into some roadblocks with getting RDM response working so I decided to try a different solution. The new solution is a pretty big paradigm shift from how I was originally trying to implement RDM response. It took some work, but I got it working! It not only works, but the new paradigm is user-friendly enough for me to be happy. I am not quite finished with response, but I got enough of it working to see that it works very well. Unfortunately, due to the big conceptual changes made, I've had to break the RDM controller code. I am planning on re-implementing it before merging this PR. In any case, there is still lots of work that needs to be done before I can call RDM response finished. |
Sounds like good progress though |
Discovery is working again. It's taking some time, but RDM is finally starting to come together. This PR is introducing a few breaking changes here and there so I am going to probably tag the next version v3.1 and officially take it out of beta. :) |
Let me know when the interface is stable enough for me to start trying to start trying to integrate |
Okay, this is more or less feature complete for this PR. I'm working on documentation and polish now. But you are welcome to start messing around with code now - I won't be changing much from now on! |
Can you update the examples please? |
Arduino examples are up! The examples are very messy. I will clean them up soon. I also had the opportunity to test the RDM responder code using an ETC Colorsource 20. The Colorsource was able to detect and automatically patch the ESP32. The Colorsource was not able to send an |
We are using ENTTEC DMX USB Pro and it works smoothly with the OLA software. |
I am in the US. That is super generous of you! Thank you! You or your colleague can reach out to me at [email protected] and I can send my mailing address. |
Merged! There is still plenty of work to do on RDM. I'll be submitting more PRs to further polish up the RDM responder soon. For now I would say that RDM response is (minimally) supported. |
This adds the feature for the DMX library to respond to RDM requests using custom callbacks.