Many To Many audit relation fail with new entity in the relation.

[mpoiriert]

Environment

Sonata packages

show

$ composer show --latest 'sonata-project/*'
sonata-project/admin-bundle              4.19.0 4.19.0 The missing Symfony Admin Generator
sonata-project/block-bundle              4.18.0 4.18.0 Symfony SonataBlockBundle
sonata-project/cache                     2.2.0  2.2.0  Cache library
Package sonata-project/cache is abandoned, you should avoid using it. No replacement was suggested.
sonata-project/doctrine-extensions       2.0.1  2.0.1  Doctrine2 behavioral extensions
sonata-project/doctrine-orm-admin-bundle 4.8.0  4.8.0  Integrate Doctrine ORM into the SonataAdminBundle
sonata-project/entity-audit-bundle       1.9.0  1.9.0  Audit for Doctrine Entities
sonata-project/exporter                  3.0.0  3.0.0  Lightweight Exporter library
sonata-project/form-extensions           1.18.0 1.18.0 Symfony form extensions
sonata-project/media-bundle              4.5.1  4.5.1  Symfony SonataMediaBundle
sonata-project/translation-bundle        3.1.0  3.1.0  SonataTranslationBundle
sonata-project/twig-extensions           2.0.0  2.0.0  Sonata twig extensions

Symfony packages

show

$ composer show --latest 'symfony/*'
symfony/amqp-messenger             v5.4.13 v5.4.13 Symfony AMQP extension Messenger Bridge
symfony/asset                      v5.4.13 v6.1.5  Manages URL generation and versioning of web assets such as CSS stylesheets, JavaScript files and image files
symfony/browser-kit                v5.4.11 v6.1.3  Simulates the behavior of a web browser, allowing you to make requests, click on links and submit forms programmatically
symfony/cache                      v5.4.13 v6.1.5  Provides extended PSR-6, PSR-16 (and tags) implementations
symfony/cache-contracts            v2.5.2  v3.1.1  Generic abstractions related to caching
symfony/config                     v5.4.11 v6.1.3  Helps you find, load, combine, autofill and validate configuration values of any kind
symfony/console                    v5.4.13 v6.1.5  Eases the creation of beautiful and testable command line interfaces
symfony/css-selector               v5.4.11 v6.1.3  Converts CSS selectors to XPath expressions
symfony/debug-bundle               v5.4.11 v6.1.3  Provides a tight integration of the Symfony VarDumper component and the ServerLogCommand from MonologBridge into the Symfony full-stack framework
symfony/dependency-injection       v5.4.13 v6.1.5  Allows you to standardize and centralize the way objects are constructed in your application
symfony/deprecation-contracts      v3.1.1  v3.1.1  A generic function and convention to trigger deprecation notices
symfony/doctrine-bridge            v5.4.13 v6.1.5  Provides integration for Doctrine with various Symfony components
symfony/doctrine-messenger         v5.4.12 v6.1.4  Symfony Doctrine Messenger Bridge
symfony/dom-crawler                v5.4.12 v6.1.4  Eases DOM navigation for HTML and XML documents
symfony/dotenv                     v5.4.5  v6.1.0  Registers environment variables from a .env file
symfony/error-handler              v5.4.11 v6.1.3  Provides tools to manage errors and ease debugging PHP code
symfony/event-dispatcher           v5.4.9  v6.1.0  Provides tools that allow your application components to communicate with each other by dispatching events and listening to them
symfony/event-dispatcher-contracts v3.1.1  v3.1.1  Generic abstractions related to dispatching event
symfony/expression-language        v5.4.11 v6.1.3  Provides an engine that can compile and evaluate expressions
symfony/filesystem                 v5.4.13 v6.1.5  Provides basic utilities for the filesystem
symfony/finder                     v5.4.11 v6.1.3  Finds files and directories via an intuitive fluent interface
symfony/flex                       v1.19.3 v2.2.3  Composer plugin for Symfony
symfony/form                       v5.4.13 v6.1.5  Allows to easily create, process and reuse HTML forms
symfony/framework-bundle           v5.4.13 v6.1.5  Provides a tight integration between Symfony components and the Symfony full-stack framework
symfony/http-client                v5.4.13 v6.1.5  Provides powerful methods to fetch HTTP resources synchronously or asynchronously
symfony/http-client-contracts      v2.5.2  v3.1.1  Generic abstractions related to HTTP clients
symfony/http-foundation            v5.4.13 v6.1.5  Defines an object-oriented layer for the HTTP specification
symfony/http-kernel                v5.4.13 v6.1.5  Provides a structured process for converting a Request into a Response
symfony/intl                       v5.4.11 v6.1.0  Provides a PHP replacement layer for the C intl extension that includes additional data from the ICU library
symfony/mailer                     v5.4.13 v6.1.5  Helps sending emails
symfony/messenger                  v5.4.13 v6.1.5  Helps applications send and receive messages to/from other applications or via message queues
symfony/mime                       v5.4.13 v6.1.5  Allows manipulating MIME messages
symfony/monolog-bridge             v5.4.10 v6.1.2  Provides integration for Monolog with various Symfony components
symfony/monolog-bundle             v3.8.0  v3.8.0  Symfony MonologBundle
symfony/options-resolver           v5.4.11 v6.1.0  Provides an improved replacement for the array_replace PHP function
symfony/password-hasher            v5.4.11 v6.1.3  Provides password hashing utilities
symfony/phpunit-bridge             v5.4.11 v6.1.3  Provides utilities for PHPUnit, especially user deprecation notices management
symfony/polyfill-ctype             v1.26.0 v1.26.0 Symfony polyfill for ctype functions
symfony/polyfill-intl-grapheme     v1.26.0 v1.26.0 Symfony polyfill for intl's grapheme_* functions
symfony/polyfill-intl-icu          v1.26.0 v1.26.0 Symfony polyfill for intl's ICU-related data and classes
symfony/polyfill-intl-idn          v1.26.0 v1.26.0 Symfony polyfill for intl's idn_to_ascii and idn_to_utf8 functions
symfony/polyfill-intl-normalizer   v1.26.0 v1.26.0 Symfony polyfill for intl's Normalizer class and related functions
symfony/polyfill-mbstring          v1.26.0 v1.26.0 Symfony polyfill for the Mbstring extension
symfony/polyfill-php72             v1.26.0 v1.26.0 Symfony polyfill backporting some PHP 7.2+ features to lower PHP versions
symfony/polyfill-php73             v1.26.0 v1.26.0 Symfony polyfill backporting some PHP 7.3+ features to lower PHP versions
symfony/polyfill-php80             v1.26.0 v1.26.0 Symfony polyfill backporting some PHP 8.0+ features to lower PHP versions
symfony/polyfill-php81             v1.26.0 v1.26.0 Symfony polyfill backporting some PHP 8.1+ features to lower PHP versions
symfony/process                    v5.4.11 v6.1.3  Executes commands in sub-processes
symfony/property-access            v5.4.11 v6.1.3  Provides functions to read and write from/to an object or array using a simple string notation
symfony/property-info              v5.4.11 v6.1.3  Extracts information about PHP class' properties using metadata of popular sources
symfony/redis-messenger            v5.4.13 v6.1.5  Symfony Redis extension Messenger Bridge
symfony/routing                    v5.4.11 v6.1.5  Maps an HTTP request to a set of configuration variables
symfony/security-acl               v3.3.2  v3.3.2  Symfony Security Component - ACL (Access Control List)
symfony/security-bundle            v5.4.11 v6.1.3  Provides a tight integration of the Security component into the Symfony full-stack framework
symfony/security-core              v5.4.13 v6.1.5  Symfony Security Component - Core Library
symfony/security-csrf              v5.4.11 v6.1.0  Symfony Security Component - CSRF Library
symfony/security-guard             v5.4.13 v5.4.13 Symfony Security Component - Guard
symfony/security-http              v5.4.13 v6.1.5  Symfony Security Component - HTTP Integration
symfony/service-contracts          v2.5.2  v3.1.1  Generic abstractions related to writing services
symfony/stopwatch                  v5.4.13 v6.1.5  Provides a way to profile code
symfony/string                     v5.4.13 v6.1.5  Provides an object-oriented API to strings and deals with bytes, UTF-8 code points and grapheme clusters in a unified way
symfony/templating                 v5.4.11 v6.1.3  Provides all the tools needed to build any kind of template system
symfony/translation                v5.4.12 v6.1.4  Provides tools to internationalize your application
symfony/translation-contracts      v2.5.2  v3.1.1  Generic abstractions related to translation
symfony/twig-bridge                v5.4.12 v6.1.4  Provides integration for Twig with various Symfony components
symfony/twig-bundle                v5.4.8  v6.1.1  Provides a tight integration of Twig into the Symfony full-stack framework
symfony/validator                  v5.4.13 v6.1.5  Provides tools to validate values
symfony/var-dumper                 v5.4.13 v6.1.5  Provides mechanisms for walking through any arbitrary PHP variable
symfony/var-exporter               v5.4.10 v6.1.3  Allows exporting any serializable PHP data structure to plain PHP code
symfony/web-profiler-bundle        v5.4.13 v6.1.5  Provides a development tool that gives detailed information about the execution of any request
symfony/workflow                   v5.4.11 v6.1.3  Provides tools for managing a workflow or finite state machine
symfony/yaml                       v5.4.12 v6.1.4  Loads and dumps YAML files

PHP version

$ php -v
PHP 8.1.5 (cli) (built: May 11 2022 13:06:14) (NTS)
Copyright (c) The PHP Group
Zend Engine v4.1.5, Copyright (c) Zend Technologies
    with Zend OPcache v8.1.5, Copyright (c), by Zend Technologies
    with Xdebug v3.1.4, Copyright (c) 2002-2022, by Derick Rethans

Subject

Many To Many audit relation fail with new entity in the relation.

Steps to reproduce

Create EntityA with property many to many on EntityB.

Add one EntityB to the property of EntityA.

Flush when the full entity graph is still new.

Expected results

Everything should be persisted to the database.

Actual results

We get an error of constraint violation. Here is my example:

[Doctrine\DBAL\Exception\NotNullConstraintViolationException (1048)]
An exception occurred while executing a query: SQLSTATE[23000]: Integrity constraint violation: 1048 Column 'role_id' cannot be null

Note

I am able to prevent this by saving the target entity of the many to many relation first.

Probably the post persist event is trigger event if the many to many relation is not saved yet.

Maybe all the logic of the LogRevisionsListener should be in the onFlush listener.

[MartinCigarsky]

Can I work on this?

[mpoiriert]

I myself I don't have time to work on this soon. I just fix downgrade the dependencies to the previous version.

I don't see why you couldn't do a PR to fix it. But maybe maintainer could give the best way to fix it, mine was just a suggestion.

[VincentLanglet]

Should be related to #509 cc @pietaj

[nocive]

We were forced to pin version 1.8.0, this change broke a many years old application for us.

[VincentLanglet]

Feel free to fix it.

[nocive]

@VincentLanglet I'd be happy to!

Since I'm not familiar with the internals of this bundle, if someone could at least provide some pointers as to what the fix could look like, that would be extremely helpful.

[VincentLanglet]

This bundle was transferred to SonataProject (cf #343 (comment)) but we're not the original authors of this ; so we can't say we're way more familiar to such internals things.
I'm just able to maintain integrations with newer libraries and solving easy quick fixes ; especially because I don't use this lib.

[salamichel]

Hi same issue for me, the audit table used for ManyToMany relation won't be created but sonata try to feed the table, so an exception "table not found xxxx_audit does not exist" :/

[VincentLanglet]

@VincentLanglet I'd be happy to!

Since I'm not familiar with the internals of this bundle, if someone could at least provide some pointers as to what the fix could look like, that would be extremely helpful.

If you say that 1.8.0 works fine for you it means that it's related to the PR #509 @nocive.

A first step could be to create a test which fails to reproduce the issue.