Fix schema creation for self referencing many to many association #537
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Subject
I am targeting this branch, because it's a bug fix.
We've tried to upgrade from 1.7 to 1.9 but our CI was failing with the following exception:
Further debugging showed that the issue was introduced in #509 as the case of a self referencing many to many association which uses class table inheritance was not taken into consideration in the create schema listener class so it currently tries to create the revision/audit table for the related table which does not yet exist at that point. The fix was to execute that logic (if we run into that case) in the post schema generation event instead where we are sure that all schema tables are created so we can then safely create the revision table for them.
Changelog