Fix OneToOne reverse relation Doctrine fallback query #250
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The foreign column name was used on a classic Doctrine find. Two issues: * This method expects an identifier. So we have to get the repository to use findOneBy method instead. * The findOneBy method expects fieldName, not column name. So primary field array is introduced.
|
BTW, this PR must be merged to master after that. |
|
thanks! |
|
Thank you @DavidBadura! |
|
@DavidBadura I think the tag is on the wrong place, including BC breaks. For
This modification should be on v2.0, right? |
|
@soullivaneuh Thanks for the hint! Version 1.0.2 should solved this. |
|
Thanks @DavidBadura. I just upgraded to 1.0.2, works correctly. 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The foreign column name was used on a classic Doctrine find.
Two issues:
I target the 1.0 branch because it's a bugfix of introduced feature in #227.
You can push the new patch release after this PR. 👍