Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avoid some deprecations #451

Merged
merged 1 commit into from
Oct 23, 2021
Merged

Avoid some deprecations #451

merged 1 commit into from
Oct 23, 2021

Conversation

jordisala1991
Copy link
Member

@jordisala1991 jordisala1991 commented Oct 20, 2021 •
edited
Loading

Subject

I am targeting this branch, because this is pedantic.

Will help with the upgrade to 3.0 of dbal

Changelog

### Removed
- Removed support for Doctrine ORM < 2.10
- Removed support for Doctrine DBAL < 2.13

jordisala1991
jordisala1991 commented Oct 20, 2021
View reviewed changes
src/AuditReader.php
@@ -18,6 +18,7 @@
use Doctrine\DBAL\Platforms\AbstractPlatform;
use Doctrine\DBAL\Types\Type;
use Doctrine\ORM\EntityManagerInterface;
use Doctrine\ORM\Internal\SQLResultCasing;
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This class is internal to ORM, but I think we might be using it for now, since it is the only non deprecated way I found to have this function

@jordisala1991 jordisala1991 force-pushed the hotfix/remove-some-deprecations branch 2 times, most recently from be57034 to 71898fd Compare October 20, 2021 07:02
@jordisala1991 jordisala1991 requested a review from a team October 20, 2021 13:02
@jordisala1991
Copy link
Member Author

Please review @sonata-project/contributors

@phansys phansys merged commit 6493b44 into sonata-project:1.x Oct 23, 2021
@phansys
Copy link
Member

phansys commented Oct 23, 2021

Thank you @jordisala1991!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@VincentLanglet VincentLanglet VincentLanglet approved these changes

@simonberger simonberger simonberger approved these changes

@phansys phansys phansys approved these changes

Assignees
No one assigned
Labels
minor
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jordisala1991 @phansys @simonberger @VincentLanglet