-
-
Notifications
You must be signed in to change notification settings - Fork 261
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add functional test and fix container usage #472
Conversation
fea8e07
to
1e8b6cf
Compare
* file that was distributed with this source code. | ||
*/ | ||
|
||
namespace SimpleThings\EntityAudit\Tests\App; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This would be problematic for dev-kit, it wont be able to generate the correct namespace. It will try to use Sonata when adding the console lints.
Since this is tests files, we could change the test namespace to use Sonata and it would fix this problem. Or you will need to introduce an if in the code for this case
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've removed the container test in dev-kit sonata-project/dev-kit#1880 in the meantime.
Maybe the console bin file could read the AppKernel
class name from an external variable or be able to configure it in dev-kit using as default name the current behaviour.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Our goal was stop remove the option from the dev-kit later, so it would be nice to not rely on a name provided by the devkit.
Thanks @franmomu |
Subject
I was trying to add a functional test and in the way some issues came up.
I am targeting this branch, because this is BC.
Closes #471.
Changelog