-
-
Notifications
You must be signed in to change notification settings - Fork 261
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix audit revision query for enum column mapping #534
Fix audit revision query for enum column mapping #534
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the fix, do you have time to take a look at the ci errors ?
You'll need to
- Solve some linters errors
- Solve some "possiblyNull" static analysis error by adding
static::assertNotNull($foo)
. - Skip the test for PHP version which doesn't support ENUM
37e68b9
to
5beece9
Compare
Even though the test I've added is marked as requiring PHP 8.1 to run, the PHP 7.4 and PHP 8.0 pipelines are still failing as the entity with the enum mapping class metadata is still being registered (so it blows up in |
Filtering here maybe https://github.com/sonata-project/EntityAuditBundle/blob/1.x/tests/BaseTest.php#L98-L102 |
a107697
to
8826d0a
Compare
@VincentLanglet Thanks - all CI pipelines have now passed 🎉 |
Thanks |
Subject
I am targeting this branch, because it's a bug fix.
After doctrine/orm#10088 we get an enum object back in the
DEL
revisionsaveRevisionEntityData
code path instead of an integer or string value which then blows up on the$conn->executeStatement()
call with the following exception:Changelog