Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added the with_foreign_keys parameter to allow disabling the creation of foreign keys #587

Merged
merged 6 commits into from
Sep 27, 2023

Conversation

SavageDays
Copy link
Contributor

@SavageDays SavageDays commented Sep 5, 2023

Subject

Large legacy projects can contain a massive amount of audit data. Adding foreign keys can take a significant amount of time. I have added a 'with_foreign_keys' parameter, which can be used to disable the creation of foreign keys.

Changelog

### Added
Added the `disable_foreign_keys` parameter, which disables the creation of foreign keys.

Copy link
Member

@VincentLanglet VincentLanglet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, thanks for the contribution.

Overall the PR seems ok, just:

  • I think a disable_foreign_keys: true option seems more natural than with_foreign_keys: false. WDYT ?
  • Maybe the use cases of this option could be in the Readme

src/DependencyInjection/Configuration.php Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
src/AuditConfiguration.php Outdated Show resolved Hide resolved
@VincentLanglet VincentLanglet requested review from phansys and a team September 27, 2023 06:40
@phansys phansys merged commit e90d8bb into sonata-project:1.x Sep 27, 2023
19 checks passed
@phansys
Copy link
Member

phansys commented Sep 27, 2023

Thank you @SavageDays!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants