Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/encore webpack #6180

Closed
wants to merge 5 commits into from

Conversation

wbloszyk
Copy link
Member

@wbloszyk wbloszyk commented Jul 1, 2020

Subject

I am targeting this branch, because {reason}.

Closes #{put_issue_number_here}.

Changelog

### Added
- Added some `Class::newMethod()` to do great stuff.

### Changed

### Deprecated

### Removed

### Fixed

### Security

@core23
Copy link
Member

core23 commented Jul 2, 2020

Can we close this in favor of #6177?

@wbloszyk
Copy link
Member Author

wbloszyk commented Jul 2, 2020

@core23 more like close #6177 in favor of this.

Add new assets system (encore webpack) is awesome feature and give new posibility (upgrade bootstrap and AdminLTE, add scss). It is all huge change not only in AdminBundle but in whole Sonata. I need to think how to do it in the best way. Probably I will do it in sandbox first, when templates can be override and after that split it to seperate bundles as final/stable webpack releases. Open dev-kit issue will be require. I will do it when i found free time. Now I'm busy.

So lets keep this open.

@SonataCI
Copy link
Collaborator

SonataCI commented Jul 3, 2020

Could you please rebase your PR and fix merge conflicts?

@wbloszyk
Copy link
Member Author

Close in favor of sonata-project/dev-kit#779

@wbloszyk wbloszyk closed this Jul 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants