-
-
Notifications
You must be signed in to change notification settings - Fork 210
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make page blocks works or remove if it is not used #1586
Comments
It would be nice to know how did you get that errors (for 1 and 3, the second one is in the process of being fixed), because they have some test that pass without problem. |
I just tried to add those blocks in composer page, and the ajax response return those errors |
But you pass any special option to those block (or you miss yo add some required parameter)? If you fill correctly the data, do they work? |
I fill out all required parameters.
what do you mean the correctly data? fill all fields? |
Screen.Recording.2022-09-06.at.09.06.00.movHey @jordisala1991 does it help you with |
Yes, it helps. I see, we do not use the interaction with javascript on the tests for this specific use case, that's why I think we didn't spot the problem. |
I see, in this case should we test the sub request directly? |
not sure tbh, too many bugs, until I fix the ones I am working on, I can't work on more 😓 |
well I do not use any of those blocks 😄, But I guess the share block are the most important one! should we invest time only in this one and if someone else use the others 2 blocks provide a PR? |
Ok Just to inform you in 4.x branch children page core is not crashing anymore, It doesn't appear any error, but I can't see any effect in my page 😄 |
It should show a list of children pages of the selected one, it does not work? |
hmmmm I can test it :) |
it is crashing if you select a page and update the block with |
I'm comparing between 3.x and 4.x, I'll try to reproduce your bug |
Nice Job @jordisala1991 🥳 |
When I'm trying to use the page blocks, some of them are crashing the page
Blocks
Chieldren page core
Breadcrumb
Related issue: sonata-project/SonataSeoBundle#685
Shared block
The text was updated successfully, but these errors were encountered: