Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release 4.0 #1495

Closed
36 tasks done
eerison opened this issue Jul 26, 2022 · 296 comments
Closed
36 tasks done

Release 4.0 #1495

eerison opened this issue Jul 26, 2022 · 296 comments
Labels
Milestone

Comments

@eerison
Copy link
Contributor

eerison commented Jul 26, 2022

I'm using this branch to test the upgrade from 3.x branch to 4.x

Those issues need to be solved before release 4.0 version

CSS / Javascript:

Other:

Completed:

@eerison
Copy link
Contributor Author

eerison commented Jul 26, 2022

Updated Sonata admin 4

Sonata\BlockBundle\Model\BaseBlock::setPosition(): Argument #1 ($position) must be of type int, null given, called in /app/vendor/sonata-project/page-bundle/src/Entity/Transformer.php on line 157

@eerison eerison changed the title Testing 4.x branch Release 4 major Jul 26, 2022
@eerison eerison changed the title Release 4 major Release 4.0 major Jul 26, 2022
@eerison eerison changed the title Release 4.0 major Release 4.0 Jul 26, 2022
@eerison
Copy link
Contributor Author

eerison commented Jul 26, 2022

well the 4.x branch is unusable, if you just navigate into the admin you will get some internal server error!

@eerison
Copy link
Contributor Author

eerison commented Jul 26, 2022

do you think make sense I create more bug issues @VincentLanglet?

@VincentLanglet
Copy link
Member

Havind all the issues in the same issue might be enough

@VincentLanglet VincentLanglet added this to the 4.0 milestone Jul 26, 2022
@VincentLanglet
Copy link
Member

For

http://localhost:8001/admin/app/sonatapagepage/tree

it's the same issue than #1498

I proposed a solution.

@eerison
Copy link
Contributor Author

eerison commented Jul 26, 2022

For

http://localhost:8001/admin/app/sonatapagepage/tree

it's the same issue than #1498

I proposed a solution.

NIce ❤️

@VincentLanglet
Copy link
Member

For

form.group_form_page_group_main_label, form.group_form_page_group_seo_label, form.group_form_page_group_advanced_label

I assume the translations exists either
https://github.com/sonata-project/SonataPageBundle/blob/3.x/src/Resources/translations/SonataPageBundle.en.xliff#L133-L144
or
https://github.com/sonata-project/SonataPageBundle/blob/3.x/src/Resources/translations/SonataPageBundle.en.xliff#L225-L236

But SonataAdmin changed the way he generated the translation keys.
In 3.x foo.bar group were using the key foo_bar.
In 4.x foo.bar group is using the key form.group_foo_bar.

So the form_page.group_seo_label translations should be updated.
And we might simplify

form.group_form_page_group_main_label, form.group_form_page_group_seo_label, form.group_form_page_group_advanced_label

to

form.group_main_label, form.group_seo_label, form.group_advanced_label

By changing

->with('form_page.group_main_label', ['class' => 'col-md-6'])->end()
->with('form_page.group_seo_label', ['class' => 'col-md-6'])->end()
->with('form_page.group_advanced_label', ['class' => 'col-md-6'])->end();
to

             ->with('main_label', ['class' => 'col-md-6'])->end()
             ->with('seo_label', ['class' => 'col-md-6'])->end()
             ->with('advanced_label', ['class' => 'col-md-6'])->end();

or even

             ->with('main', ['class' => 'col-md-6'])->end()
             ->with('seo', ['class' => 'col-md-6'])->end()
             ->with('advanced', ['class' => 'col-md-6'])->end();

@VincentLanglet
Copy link
Member

For create_snapshot, it's #1502 IMHO

@eerison
Copy link
Contributor Author

eerison commented Jul 27, 2022

I added a new issue in dashboard

@Amin-Hosseini
Copy link
Contributor

Hey, I will work on missing translations

@eerison
Copy link
Contributor Author

eerison commented Jul 27, 2022

@VincentLanglet have you tried to add this in the pipelines: https://symfony.com/doc/current/translation/debug.html to get the missing translations?

@VincentLanglet
Copy link
Member

VincentLanglet commented Jul 27, 2022

@VincentLanglet have you tried to add this in the pipelines: https://symfony.com/doc/current/translation/debug.html to get the missing translations?

It would miss all the translation key generated dynamically if I understand correctly

@eerison
Copy link
Contributor Author

eerison commented Jul 27, 2022

@VincentLanglet have you tried to add this in the pipelines: https://symfony.com/doc/current/translation/debug.html to get the missing translations?

It would miss all the translation key generated dynamically if I understand correctly

true :(

@VincentLanglet
Copy link
Member

  • at http://localhost:8001/admin/dashboard is returning An exception has been thrown during the rendering of a template ("The options "manager", "page_id" do not exist. Defined options are: "attr", "extra_cache_keys", "groups", "template", "ttl", "use_cache".").

For this error, seems like the BlockManager is done in 4.x is not working
https://github.com/sonata-project/SonataPageBundle/blob/4.x/src/Block/BlockContextManager.php#L19
because the extra settings are not configured https://github.com/sonata-project/SonataBlockBundle/blob/375b168da31545bf3c386fd25a4b483411ac97c5/src/Block/BlockContextManager.php#L163

Is there a way to avoid removing the final keyword from the BlockBundle BlockManager ?
cc @jordisala1991

@jordisala1991
Copy link
Member

Saw the same error and tried to fix, but didn't found a solution without touching BlockBundle. I only tried for half an hour, so I might be wrong.

@VincentLanglet
Copy link
Member

Saw the same error and tried to fix, but didn't found a solution without touching BlockBundle.

Seems ok to me to touch the BlockBundle, but I would have prefer to avoid removing the final keyword.

FormType has things like a getParent() method, I dunno if same could be done here.
We could also provide an abstract class with everything implemented except the configureSettings method ; but seems like some settings need to be configured for every BlockManager, like template. So there is maybe something like configureDefaultSettings and configureExtraSettings...
Didn't find a great pattern so far.

@eerison
Copy link
Contributor Author

eerison commented Aug 4, 2022

Saw the same error and tried to fix, but didn't found a solution without touching BlockBundle. I only tried for half an hour, so I might be wrong.

I was checking with @Amin-Hosseini this issue related with BlockManager, and I guess it's possible make this work without remove the final class, Because if I got correct we are more or less decorating this BlockContextManager.php#L16

@Amin-Hosseini please share where what have you find ATM!

@Amin-Hosseini
Copy link
Contributor

I've checked #1483 changes and as we don't have OptionsResolver in src/Block/BlockContextManager.php anymore, error happens on $optionsResolver->resolve($settings); -> BlockBundle : BlockContextManager.php#L289

I tried to update get function on BlockContextManager to add (merge) $settings to $block but I guess we can fix this issue with add $optionsResolver->setDefaults($settings); to BlockBundle : BlockContextManager.php#L285

I can create a PR, if you think it's the good solution :-)

cc @jordisala1991

@eerison
Copy link
Contributor Author

eerison commented Aug 4, 2022

I've checked #1483 changes and as we don't have OptionsResolver in src/Block/BlockContextManager.php anymore, error happens on $optionsResolver->resolve($settings); -> BlockBundle : BlockContextManager.php#L289

I tried to update get function on BlockContextManager to add (merge) $settings to $block but I guess we can fix this issue with add $optionsResolver->setDefaults($settings); to BlockBundle : BlockContextManager.php#L285

I can create a PR, if you think it's the good solution :-)

cc @jordisala1991

  • But does resolve still exist?
  • is it working as before? have you tested it and does it work?
  • ins't it possible to override this in the page bundle?

@VincentLanglet
Copy link
Member

I tried to update get function on BlockContextManager to add (merge) $settings to $block but I guess we can fix this issue with add $optionsResolver->setDefaults($settings); to BlockBundle : BlockContextManager.php#L285

I can create a PR, if you think it's the good solution :-)

I might misunderstand the solution but the issue I see is that we cannot validate the values/type of the extra settings ; it would be so nice to be able to configure extra settings in the PageBundle BlockContextManager.
That's why I had in mind to provide an abstract class with extensions point.

@eerison
Copy link
Contributor Author

eerison commented Aug 4, 2022

I tried to update get function on BlockContextManager to add (merge) $settings to $block but I guess we can fix this issue with add $optionsResolver->setDefaults($settings); to BlockBundle : BlockContextManager.php#L285
I can create a PR, if you think it's the good solution :-)

I might misunderstand the solution but the issue I see is that we cannot validate the values/type of the extra settings ; it would be so nice to be able to configure extra settings in the PageBundle BlockContextManager. That's why I had in mind to provide an abstract class with extensions point.

Well should be good we think in some solution using interfaces, usually those abstract class going to increase 😞

@VincentLanglet
Copy link
Member

when I'm running composer update -W, I'm facing this issue Compile Error: Type of App\Entity\SonataPageBlock::$page must be ?Sonata\Pa !! geBundle\Model\PageInterface (as in class Sonata\PageBundle\Model\Block) at In SonataPageBlock.php line 16:

It's an issue with your code IMHO @eerison

@eerison
Copy link
Contributor Author

eerison commented Aug 6, 2022

when I'm running composer update -W, I'm facing this issue Compile Error: Type of App\Entity\SonataPageBlock::$page must be ?Sonata\Pa !! geBundle\Model\PageInterface (as in class Sonata\PageBundle\Model\Block) at In SonataPageBlock.php line 16:

It's an issue with your code IMHO @eerison

Really? I don't remember to change something inf Block::page

@eerison
Copy link
Contributor Author

eerison commented Oct 4, 2022

When I add Menu block I get this error

Twig\Error\RuntimeError:
An exception has been thrown during the rendering of a template ("Knp\Menu\Provider\ChainProvider::get(): Argument #1 ($name) must be of type string, null given, called in /app/vendor/knplabs/knp-menu/src/Knp/Menu/Twig/Helper.php on line 67").

  at vendor/sonata-project/page-bundle/src/Resources/views/Block/block_container.html.twig:15
  at Twig\Template->displayBlock('block_child_render', array('block' => object(SonataPageBlock), 'decorator' => array('pre' => '', 'post' => ''), 'settings' => array('layout' => '{{ CONTENT }}', 'class' => '', 'use_cache' => true, 'extra_cache_keys' => array(), 'attr' => array(), 'template' => '@SonataPage/Block/block_container.html.twig', 'ttl' => 86400, 'code' => 'content'), 'wrap_fields_with_addons' => true, 'app' => object(AppVariable), 'sonata_block' => object(GlobalVariables), 'sonata_config' => object(SonataConfiguration), 'sonata_page' => object(GlobalVariables), 'sonata_page_admin' => object(PageAdmin), '_parent' => array('block' => object(SonataPageBlock), 'decorator' => array('pre' => '', 'post' => ''), 'settings' => array('layout' => '{{ CONTENT }}', 'class' => '', 'use_cache' => true, 'extra_cache_keys' => array(), 'attr' => array(), 'template' => '@SonataPage/Block/block_container.html.twig', 'ttl' => 86400, 'code' => 'content'), 'wrap_fields_with_addons' => true, 'app' => object(AppVariable), 'sonata_block' => object(GlobalVariables), 'sonata_config' => object(SonataConfiguration), 'sonata_page' => object(GlobalVariables), 'sonata_page_admin' => object(PageAdmin)), '_seq' => array(object(SonataPageBlock), object(SonataPageBlock), object(SonataPageBlock), object(SonataPageBlock), object(SonataPageBlock)), 'loop' => array('parent' => array('block' => object(SonataPageBlock), 'decorator' => array('pre' => '', 'post' => ''), 'settings' => array('layout' => '{{ CONTENT }}', 'class' => '', 'use_cache' => true, 'extra_cache_keys' => array(), 'attr' => array(), 'template' => '@SonataPage/Block/block_container.html.twig', 'ttl' => 86400, 'code' => 'content'), 'wrap_fields_with_addons' => true, 'app' => object(AppVariable), 'sonata_block' => object(GlobalVariables), 'sonata_config' => object(SonataConfiguration), 'sonata_page' => object(GlobalVariables), 'sonata_page_admin' => object(PageAdmin)), 'index0' => 2, 'index' => 3, 'first' => false, 'revindex0' => 2, 'revindex' => 3, 'length' => 5, 'last' => false), 'child' => object(SonataPageBlock), '_key' => 2), array('block' => array(object(__TwigTemplate_e5d0f98282cf52aae484e0842c2bdcff), 'block_block'), 'block_class' => array(object(__TwigTemplate_e5d0f98282cf52aae484e0842c2bdcff), 'block_block_class'), 'block_role' => array(object(__TwigTemplate_e5d0f98282cf52aae484e0842c2bdcff), 'block_block_role'), 'block_child_render' => array(object(__TwigTemplate_c8227bb9cf486e6f97b7bde9a3d65f5c), 'block_block_child_render')))
     (var/cache/dev/twig/f3/f3be148a56161735946e894aa613752e.php:139)
  at __TwigTemplate_e5d0f98282cf52aae484e0842c2bdcff->block_block(array('block' => object(SonataPageBlock), 'decorator' => array('pre' => '', 'post' => ''), 'settings' => array('layout' => '{{ CONTENT }}', 'class' => '', 'use_cache' => true, 'extra_cache_keys' => array(), 'attr' => array(), 'template' => '@SonataPage/Block/block_container.html.twig', 'ttl' => 86400, 'code' => 'content'), 'wrap_fields_with_addons' => true, 'app' => object(AppVariable), 'sonata_block' => object(GlobalVariables), 'sonata_config' => object(SonataConfiguration), 'sonata_page' => object(GlobalVariables), 'sonata_page_admin' => object(PageAdmin), '_parent' => array('block' => object(SonataPageBlock), 'decorator' => array('pre' => '', 'post' => ''), 'settings' => array('layout' => '{{ CONTENT }}', 'class' => '', 'use_cache' => true, 'extra_cache_keys' => array(), 'attr' => array(), 'template' => '@SonataPage/Block/block_container.html.twig', 'ttl' => 86400, 'code' => 'content'), 'wrap_fields_with_addons' => true, 'app' => object(AppVariable), 'sonata_block' => object(GlobalVariables), 'sonata_config' => object(SonataConfiguration), 'sonata_page' => object(GlobalVariables), 'sonata_page_admin' => object(PageAdmin)), '_seq' => array(object(SonataPageBlock), object(SonataPageBlock), object(SonataPageBlock), object(SonataPageBlock), object(SonataPageBlock)), 'loop' => array('parent' => array('block' => object(SonataPageBlock), 'decorator' => array('pre' => '', 'post' => ''), 'settings' => array('layout' => '{{ CONTENT }}', 'class' => '', 'use_cache' => true, 'extra_cache_keys' => array(), 'attr' => array(), 'template' => '@SonataPage/Block/block_container.html.twig', 'ttl' => 86400, 'code' => 'content'), 'wrap_fields_with_addons' => true, 'app' => object(AppVariable), 'sonata_block' => object(GlobalVariables), 'sonata_config' => object(SonataConfiguration), 'sonata_page' => object(GlobalVariables), 'sonata_page_admin' => object(PageAdmin)), 'index0' => 2, 'index' => 3, 'first' => false, 'revindex0' => 2, 'revindex' => 3, 'length' => 5, 'last' => false), 'child' => object(SonataPageBlock), '_key' => 2), array('block' => array(object(__TwigTemplate_e5d0f98282cf52aae484e0842c2bdcff), 'block_block'), 'block_class' => array(object(__TwigTemplate_e5d0f98282cf52aae484e0842c2bdcff), 'block_block_class'), 'block_role' => array(object(__TwigTemplate_e5d0f98282cf52aae484e0842c2bdcff), 'block_block_role'), 'block_child_render' => array(object(__TwigTemplate_c8227bb9cf486e6f97b7bde9a3d65f5c), 'block_block_child_render')))
     (vendor/twig/twig/src/Template.php:171)
  at Twig\Template->displayBlock('block', array('block' => object(SonataPageBlock), 'decorator' => array('pre' => '', 'post' => ''), 'settings' => array('layout' => '{{ CONTENT }}', 'class' => '', 'use_cache' => true, 'extra_cache_keys' => array(), 'attr' => array(), 'template' => '@SonataPage/Block/block_container.html.twig', 'ttl' => 86400, 'code' => 'content'), 'wrap_fields_with_addons' => true, 'app' => object(AppVariable), 'sonata_block' => object(GlobalVariables), 'sonata_config' => object(SonataConfiguration), 'sonata_page' => object(GlobalVariables), 'sonata_page_admin' => object(PageAdmin)), array('block' => array(object(__TwigTemplate_e5d0f98282cf52aae484e0842c2bdcff), 'block_block'), 'block_class' => array(object(__TwigTemplate_e5d0f98282cf52aae484e0842c2bdcff), 'block_block_class'), 'block_role' => array(object(__TwigTemplate_e5d0f98282cf52aae484e0842c2bdcff), 'block_block_role'), 'block_child_render' => array(object(__TwigTemplate_c8227bb9cf486e6f97b7bde9a3d65f5c), 'block_block_child_render')))
     (var/cache/dev/twig/d6/d66eb32a4d841ae0a37f1f148ce55e02.php:66)
  at __TwigTemplate_05c6f7b60e4ce7b44dc7835ad2adef74->doDisplay(array('block' => object(SonataPageBlock), 'decorator' => array('pre' => '', 'post' => ''), 'settings' => array('layout' => '{{ CONTENT }}', 'class' => '', 'use_cache' => true, 'extra_cache_keys' => array(), 'attr' => array(), 'template' => '@SonataPage/Block/block_container.html.twig', 'ttl' => 86400, 'code' => 'content'), 'wrap_fields_with_addons' => true, 'app' => object(AppVariable), 'sonata_block' => object(GlobalVariables), 'sonata_config' => object(SonataConfiguration), 'sonata_page' => object(GlobalVariables), 'sonata_page_admin' => object(PageAdmin)), array('block' => array(object(__TwigTemplate_e5d0f98282cf52aae484e0842c2bdcff), 'block_block'), 'block_class' => array(object(__TwigTemplate_e5d0f98282cf52aae484e0842c2bdcff), 'block_block_class'), 'block_role' => array(object(__TwigTemplate_e5d0f98282cf52aae484e0842c2bdcff), 'block_block_role'), 'block_child_render' => array(object(__TwigTemplate_c8227bb9cf486e6f97b7bde9a3d65f5c), 'block_block_child_render')))
     (vendor/twig/twig/src/Template.php:394)
  at Twig\Template->displayWithErrorHandling(array('block' => object(SonataPageBlock), 'decorator' => array('pre' => '', 'post' => ''), 'settings' => array('layout' => '{{ CONTENT }}', 'class' => '', 'use_cache' => true, 'extra_cache_keys' => array(), 'attr' => array(), 'template' => '@SonataPage/Block/block_container.html.twig', 'ttl' => 86400, 'code' => 'content'), 'wrap_fields_with_addons' => true, 'app' => object(AppVariable), 'sonata_block' => object(GlobalVariables), 'sonata_config' => object(SonataConfiguration), 'sonata_page' => object(GlobalVariables), 'sonata_page_admin' => object(PageAdmin)), array('block' => array(object(__TwigTemplate_e5d0f98282cf52aae484e0842c2bdcff), 'block_block'), 'block_class' => array(object(__TwigTemplate_e5d0f98282cf52aae484e0842c2bdcff), 'block_block_class'), 'block_role' => array(object(__TwigTemplate_e5d0f98282cf52aae484e0842c2bdcff), 'block_block_role'), 'block_child_render' => array(object(__TwigTemplate_c8227bb9cf486e6f97b7bde9a3d65f5c), 'block_block_child_render')))
     (vendor/twig/twig/src/Template.php:367)
  at Twig\Template->display(array('block' => object(SonataPageBlock), 'decorator' => array('pre' => '', 'post' => ''), 'settings' => array('layout' => '{{ CONTENT }}', 'class' => '', 'use_cache' => true, 'extra_cache_keys' => array(), 'attr' => array(), 'template' => '@SonataPage/Block/block_container.html.twig', 'ttl' => 86400, 'code' => 'content'), 'wrap_fields_with_addons' => true, 'app' => object(AppVariable), 'sonata_block' => object(GlobalVariables), 'sonata_config' => object(SonataConfiguration), 'sonata_page' => object(GlobalVariables), 'sonata_page_admin' => object(PageAdmin)), array('block_class' => array(object(__TwigTemplate_e5d0f98282cf52aae484e0842c2bdcff), 'block_block_class'), 'block_role' => array(object(__TwigTemplate_e5d0f98282cf52aae484e0842c2bdcff), 'block_block_role'), 'block' => array(object(__TwigTemplate_e5d0f98282cf52aae484e0842c2bdcff), 'block_block'), 'block_child_render' => array(object(__TwigTemplate_c8227bb9cf486e6f97b7bde9a3d65f5c), 'block_block_child_render')))
     (var/cache/dev/twig/f3/f3be148a56161735946e894aa613752e.php:50)
  at __TwigTemplate_e5d0f98282cf52aae484e0842c2bdcff->doDisplay(array('block' => object(SonataPageBlock), 'decorator' => array('pre' => '', 'post' => ''), 'settings' => array('layout' => '{{ CONTENT }}', 'class' => '', 'use_cache' => true, 'extra_cache_keys' => array(), 'attr' => array(), 'template' => '@SonataPage/Block/block_container.html.twig', 'ttl' => 86400, 'code' => 'content'), 'wrap_fields_with_addons' => true, 'app' => object(AppVariable), 'sonata_block' => object(GlobalVariables), 'sonata_config' => object(SonataConfiguration), 'sonata_page' => object(GlobalVariables), 'sonata_page_admin' => object(PageAdmin)), array('block_class' => array(object(__TwigTemplate_e5d0f98282cf52aae484e0842c2bdcff), 'block_block_class'), 'block_role' => array(object(__TwigTemplate_e5d0f98282cf52aae484e0842c2bdcff), 'block_block_role'), 'block' => array(object(__TwigTemplate_e5d0f98282cf52aae484e0842c2bdcff), 'block_block'), 'block_child_render' => array(object(__TwigTemplate_c8227bb9cf486e6f97b7bde9a3d65f5c), 'block_block_child_render')))
     (vendor/twig/twig/src/Template.php:394)
  at Twig\Template->displayWithErrorHandling(array('block' => object(SonataPageBlock), 'decorator' => array('pre' => '', 'post' => ''), 'settings' => array('layout' => '{{ CONTENT }}', 'class' => '', 'use_cache' => true, 'extra_cache_keys' => array(), 'attr' => array(), 'template' => '@SonataPage/Block/block_container.html.twig', 'ttl' => 86400, 'code' => 'content'), 'wrap_fields_with_addons' => true, 'app' => object(AppVariable), 'sonata_block' => object(GlobalVariables), 'sonata_config' => object(SonataConfiguration), 'sonata_page' => object(GlobalVariables), 'sonata_page_admin' => object(PageAdmin)), array('block_class' => array(object(__TwigTemplate_e5d0f98282cf52aae484e0842c2bdcff), 'block_block_class'), 'block_role' => array(object(__TwigTemplate_e5d0f98282cf52aae484e0842c2bdcff), 'block_block_role'), 'block' => array(object(__TwigTemplate_e5d0f98282cf52aae484e0842c2bdcff), 'block_block'), 'block_child_render' => array(object(__TwigTemplate_c8227bb9cf486e6f97b7bde9a3d65f5c), 'block_block_child_render')))
     (vendor/twig/twig/src/Template.php:367)
  at Twig\Template->display(array('block' => object(SonataPageBlock), 'decorator' => array('pre' => '', 'post' => ''), 'settings' => array('layout' => '{{ CONTENT }}', 'class' => '', 'use_cache' => true, 'extra_cache_keys' => array(), 'attr' => array(), 'template' => '@SonataPage/Block/block_container.html.twig', 'ttl' => 86400, 'code' => 'content'), 'wrap_fields_with_addons' => true, 'app' => object(AppVariable), 'sonata_block' => object(GlobalVariables), 'sonata_config' => object(SonataConfiguration), 'sonata_page' => object(GlobalVariables), 'sonata_page_admin' => object(PageAdmin)), array('block_child_render' => array(object(__TwigTemplate_c8227bb9cf486e6f97b7bde9a3d65f5c), 'block_block_child_render')))
     (var/cache/dev/twig/27/27b6a9888657a2a814ec26fae089d87f.php:48)
  at __TwigTemplate_c8227bb9cf486e6f97b7bde9a3d65f5c->doDisplay(array('block' => object(SonataPageBlock), 'decorator' => array('pre' => '', 'post' => ''), 'settings' => array('layout' => '{{ CONTENT }}', 'class' => '', 'use_cache' => true, 'extra_cache_keys' => array(), 'attr' => array(), 'template' => '@SonataPage/Block/block_container.html.twig', 'ttl' => 86400, 'code' => 'content'), 'wrap_fields_with_addons' => true, 'app' => object(AppVariable), 'sonata_block' => object(GlobalVariables), 'sonata_config' => object(SonataConfiguration), 'sonata_page' => object(GlobalVariables), 'sonata_page_admin' => object(PageAdmin)), array('block_child_render' => array(object(__TwigTemplate_c8227bb9cf486e6f97b7bde9a3d65f5c), 'block_block_child_render')))
     (vendor/twig/twig/src/Template.php:394)
  at Twig\Template->displayWithErrorHandling(array('block' => object(SonataPageBlock), 'decorator' => array('pre' => '', 'post' => ''), 'settings' => array('layout' => '{{ CONTENT }}', 'class' => '', 'use_cache' => true, 'extra_cache_keys' => array(), 'attr' => array(), 'template' => '@SonataPage/Block/block_container.html.twig', 'ttl' => 86400, 'code' => 'content'), 'wrap_fields_with_addons' => true, 'app' => object(AppVariable), 'sonata_block' => object(GlobalVariables), 'sonata_config' => object(SonataConfiguration), 'sonata_page' => object(GlobalVariables), 'sonata_page_admin' => object(PageAdmin)), array('block_child_render' => array(object(__TwigTemplate_c8227bb9cf486e6f97b7bde9a3d65f5c), 'block_block_child_render')))
     (vendor/twig/twig/src/Template.php:367)
  at Twig\Template->display(array('block' => object(SonataPageBlock), 'decorator' => array('pre' => '', 'post' => ''), 'settings' => array('layout' => '{{ CONTENT }}', 'class' => '', 'use_cache' => true, 'extra_cache_keys' => array(), 'attr' => array(), 'template' => '@SonataPage/Block/block_container.html.twig', 'ttl' => 86400, 'code' => 'content')))
     (vendor/twig/twig/src/Template.php:379)
  at Twig\Template->render(array('block' => object(SonataPageBlock), 'decorator' => array('pre' => '', 'post' => ''), 'settings' => array('layout' => '{{ CONTENT }}', 'class' => '', 'use_cache' => true, 'extra_cache_keys' => array(), 'attr' => array(), 'template' => '@SonataPage/Block/block_container.html.twig', 'ttl' => 86400, 'code' => 'content')), array())
     (vendor/twig/twig/src/TemplateWrapper.php:40)
  at Twig\TemplateWrapper->render(array('block' => object(SonataPageBlock), 'decorator' => array('pre' => '', 'post' => ''), 'settings' => array('layout' => '{{ CONTENT }}', 'class' => '', 'use_cache' => true, 'extra_cache_keys' => array(), 'attr' => array(), 'template' => '@SonataPage/Block/block_container.html.twig', 'ttl' => 86400, 'code' => 'content')))
     (vendor/twig/twig/src/Environment.php:277)
  at Twig\Environment->render('@SonataPage/Block/block_container.html.twig', array('block' => object(SonataPageBlock), 'decorator' => array('pre' => '', 'post' => ''), 'settings' => array('layout' => '{{ CONTENT }}', 'class' => '', 'use_cache' => true, 'extra_cache_keys' => array(), 'attr' => array(), 'template' => '@SonataPage/Block/block_container.html.twig', 'ttl' => 86400, 'code' => 'content')))
     (vendor/sonata-project/block-bundle/src/Block/Service/AbstractBlockService.php:43)
  at Sonata\BlockBundle\Block\Service\AbstractBlockService->renderResponse('@SonataPage/Block/block_container.html.twig', array('block' => object(SonataPageBlock), 'decorator' => array('pre' => '', 'post' => ''), 'settings' => array('layout' => '{{ CONTENT }}', 'class' => '', 'use_cache' => true, 'extra_cache_keys' => array(), 'attr' => array(), 'template' => '@SonataPage/Block/block_container.html.twig', 'ttl' => 86400, 'code' => 'content')), object(Response))
     (vendor/sonata-project/page-bundle/src/Block/ContainerBlockService.php:85)
  at Sonata\PageBundle\Block\ContainerBlockService->execute(object(BlockContext), object(Response))
     (vendor/sonata-project/block-bundle/src/Block/BlockRenderer.php:70)
  at Sonata\BlockBundle\Block\BlockRenderer->render(object(BlockContext))
     (vendor/sonata-project/block-bundle/src/Templating/Helper/BlockHelper.php:451)
  at Sonata\BlockBundle\Templating\Helper\BlockHelper->render(object(SonataPageBlock), array())
     (vendor/sonata-project/page-bundle/src/Twig/Extension/PageExtension.php:194)
  at Sonata\PageBundle\Twig\Extension\PageExtension->renderBlock(object(SonataPageBlock), array())
     (vendor/sonata-project/page-bundle/src/Twig/Extension/PageExtension.php:178)
  at Sonata\PageBundle\Twig\Extension\PageExtension->renderContainer('content', object(SnapshotPageProxy))
     (var/cache/dev/twig/e4/e4c29647b0e0d5437d3434e345fd1c27.php:216)
  at __TwigTemplate_2fc868b826fd2331f8bf6a7a5d93e557->block_page_content(array('error_codes' => array('_page_internal_error_not_found', '_page_internal_error_fatal'), 'page' => object(SnapshotPageProxy), 'site' => object(SonataPageSite), 'wrap_fields_with_addons' => true, 'app' => object(AppVariable), 'sonata_block' => object(GlobalVariables), 'sonata_config' => object(SonataConfiguration), 'sonata_page' => object(GlobalVariables), 'sonata_page_admin' => object(PageAdmin), 'content' => ''), array('sonata_page_html_tag' => array(object(__TwigTemplate_b624e3e86cf216a5c26f7250d4b6e392), 'block_sonata_page_html_tag'), 'sonata_page_head' => array(object(__TwigTemplate_b624e3e86cf216a5c26f7250d4b6e392), 'block_sonata_page_head'), 'sonata_page_stylesheets' => array(object(__TwigTemplate_b624e3e86cf216a5c26f7250d4b6e392), 'block_sonata_page_stylesheets'), 'sonata_page_javascripts' => array(object(__TwigTemplate_b624e3e86cf216a5c26f7250d4b6e392), 'block_sonata_page_javascripts'), 'sonata_page_body_tag' => array(object(__TwigTemplate_b624e3e86cf216a5c26f7250d4b6e392), 'block_sonata_page_body_tag'), 'sonata_page_top_bar' => array(object(__TwigTemplate_b624e3e86cf216a5c26f7250d4b6e392), 'block_sonata_page_top_bar'), 'sonata_page_container' => array(object(__TwigTemplate_2fc868b826fd2331f8bf6a7a5d93e557), 'block_sonata_page_container'), 'sonata_page_asset_footer' => array(object(__TwigTemplate_b624e3e86cf216a5c26f7250d4b6e392), 'block_sonata_page_asset_footer'), 'sonata_page_breadcrumb' => array(object(__TwigTemplate_2fc868b826fd2331f8bf6a7a5d93e557), 'block_sonata_page_breadcrumb'), 'page_content' => array(object(__TwigTemplate_2fc868b826fd2331f8bf6a7a5d93e557), 'block_page_content')))
     (vendor/twig/twig/src/Template.php:171)
  at Twig\Template->displayBlock('page_content', array('error_codes' => array('_page_internal_error_not_found', '_page_internal_error_fatal'), 'page' => object(SnapshotPageProxy), 'site' => object(SonataPageSite), 'wrap_fields_with_addons' => true, 'app' => object(AppVariable), 'sonata_block' => object(GlobalVariables), 'sonata_config' => object(SonataConfiguration), 'sonata_page' => object(GlobalVariables), 'sonata_page_admin' => object(PageAdmin)), array('sonata_page_html_tag' => array(object(__TwigTemplate_b624e3e86cf216a5c26f7250d4b6e392), 'block_sonata_page_html_tag'), 'sonata_page_head' => array(object(__TwigTemplate_b624e3e86cf216a5c26f7250d4b6e392), 'block_sonata_page_head'), 'sonata_page_stylesheets' => array(object(__TwigTemplate_b624e3e86cf216a5c26f7250d4b6e392), 'block_sonata_page_stylesheets'), 'sonata_page_javascripts' => array(object(__TwigTemplate_b624e3e86cf216a5c26f7250d4b6e392), 'block_sonata_page_javascripts'), 'sonata_page_body_tag' => array(object(__TwigTemplate_b624e3e86cf216a5c26f7250d4b6e392), 'block_sonata_page_body_tag'), 'sonata_page_top_bar' => array(object(__TwigTemplate_b624e3e86cf216a5c26f7250d4b6e392), 'block_sonata_page_top_bar'), 'sonata_page_container' => array(object(__TwigTemplate_2fc868b826fd2331f8bf6a7a5d93e557), 'block_sonata_page_container'), 'sonata_page_asset_footer' => array(object(__TwigTemplate_b624e3e86cf216a5c26f7250d4b6e392), 'block_sonata_page_asset_footer'), 'sonata_page_breadcrumb' => array(object(__TwigTemplate_2fc868b826fd2331f8bf6a7a5d93e557), 'block_sonata_page_breadcrumb'), 'page_content' => array(object(__TwigTemplate_2fc868b826fd2331f8bf6a7a5d93e557), 'block_page_content')))
     (var/cache/dev/twig/e4/e4c29647b0e0d5437d3434e345fd1c27.php:110)
  at __TwigTemplate_2fc868b826fd2331f8bf6a7a5d93e557->block_sonata_page_container(array('error_codes' => array('_page_internal_error_not_found', '_page_internal_error_fatal'), 'page' => object(SnapshotPageProxy), 'site' => object(SonataPageSite), 'wrap_fields_with_addons' => true, 'app' => object(AppVariable), 'sonata_block' => object(GlobalVariables), 'sonata_config' => object(SonataConfiguration), 'sonata_page' => object(GlobalVariables), 'sonata_page_admin' => object(PageAdmin)), array('sonata_page_html_tag' => array(object(__TwigTemplate_b624e3e86cf216a5c26f7250d4b6e392), 'block_sonata_page_html_tag'), 'sonata_page_head' => array(object(__TwigTemplate_b624e3e86cf216a5c26f7250d4b6e392), 'block_sonata_page_head'), 'sonata_page_stylesheets' => array(object(__TwigTemplate_b624e3e86cf216a5c26f7250d4b6e392), 'block_sonata_page_stylesheets'), 'sonata_page_javascripts' => array(object(__TwigTemplate_b624e3e86cf216a5c26f7250d4b6e392), 'block_sonata_page_javascripts'), 'sonata_page_body_tag' => array(object(__TwigTemplate_b624e3e86cf216a5c26f7250d4b6e392), 'block_sonata_page_body_tag'), 'sonata_page_top_bar' => array(object(__TwigTemplate_b624e3e86cf216a5c26f7250d4b6e392), 'block_sonata_page_top_bar'), 'sonata_page_container' => array(object(__TwigTemplate_2fc868b826fd2331f8bf6a7a5d93e557), 'block_sonata_page_container'), 'sonata_page_asset_footer' => array(object(__TwigTemplate_b624e3e86cf216a5c26f7250d4b6e392), 'block_sonata_page_asset_footer'), 'sonata_page_breadcrumb' => array(object(__TwigTemplate_2fc868b826fd2331f8bf6a7a5d93e557), 'block_sonata_page_breadcrumb'), 'page_content' => array(object(__TwigTemplate_2fc868b826fd2331f8bf6a7a5d93e557), 'block_page_content')))
     (vendor/twig/twig/src/Template.php:171)
  at Twig\Template->displayBlock('sonata_page_container', array('error_codes' => array('_page_internal_error_not_found', '_page_internal_error_fatal'), 'page' => object(SnapshotPageProxy), 'site' => object(SonataPageSite), 'wrap_fields_with_addons' => true, 'app' => object(AppVariable), 'sonata_block' => object(GlobalVariables), 'sonata_config' => object(SonataConfiguration), 'sonata_page' => object(GlobalVariables), 'sonata_page_admin' => object(PageAdmin)), array('sonata_page_html_tag' => array(object(__TwigTemplate_b624e3e86cf216a5c26f7250d4b6e392), 'block_sonata_page_html_tag'), 'sonata_page_head' => array(object(__TwigTemplate_b624e3e86cf216a5c26f7250d4b6e392), 'block_sonata_page_head'), 'sonata_page_stylesheets' => array(object(__TwigTemplate_b624e3e86cf216a5c26f7250d4b6e392), 'block_sonata_page_stylesheets'), 'sonata_page_javascripts' => array(object(__TwigTemplate_b624e3e86cf216a5c26f7250d4b6e392), 'block_sonata_page_javascripts'), 'sonata_page_body_tag' => array(object(__TwigTemplate_b624e3e86cf216a5c26f7250d4b6e392), 'block_sonata_page_body_tag'), 'sonata_page_top_bar' => array(object(__TwigTemplate_b624e3e86cf216a5c26f7250d4b6e392), 'block_sonata_page_top_bar'), 'sonata_page_container' => array(object(__TwigTemplate_2fc868b826fd2331f8bf6a7a5d93e557), 'block_sonata_page_container'), 'sonata_page_asset_footer' => array(object(__TwigTemplate_b624e3e86cf216a5c26f7250d4b6e392), 'block_sonata_page_asset_footer'), 'sonata_page_breadcrumb' => array(object(__TwigTemplate_2fc868b826fd2331f8bf6a7a5d93e557), 'block_sonata_page_breadcrumb'), 'page_content' => array(object(__TwigTemplate_2fc868b826fd2331f8bf6a7a5d93e557), 'block_page_content')))
     (var/cache/dev/twig/02/02acb24c5473e58987dc97ba88dac384.php:69)
  at __TwigTemplate_b624e3e86cf216a5c26f7250d4b6e392->doDisplay(array('error_codes' => array('_page_internal_error_not_found', '_page_internal_error_fatal'), 'page' => object(SnapshotPageProxy), 'site' => object(SonataPageSite), 'wrap_fields_with_addons' => true, 'app' => object(AppVariable), 'sonata_block' => object(GlobalVariables), 'sonata_config' => object(SonataConfiguration), 'sonata_page' => object(GlobalVariables), 'sonata_page_admin' => object(PageAdmin)), array('sonata_page_html_tag' => array(object(__TwigTemplate_b624e3e86cf216a5c26f7250d4b6e392), 'block_sonata_page_html_tag'), 'sonata_page_head' => array(object(__TwigTemplate_b624e3e86cf216a5c26f7250d4b6e392), 'block_sonata_page_head'), 'sonata_page_stylesheets' => array(object(__TwigTemplate_b624e3e86cf216a5c26f7250d4b6e392), 'block_sonata_page_stylesheets'), 'sonata_page_javascripts' => array(object(__TwigTemplate_b624e3e86cf216a5c26f7250d4b6e392), 'block_sonata_page_javascripts'), 'sonata_page_body_tag' => array(object(__TwigTemplate_b624e3e86cf216a5c26f7250d4b6e392), 'block_sonata_page_body_tag'), 'sonata_page_top_bar' => array(object(__TwigTemplate_b624e3e86cf216a5c26f7250d4b6e392), 'block_sonata_page_top_bar'), 'sonata_page_container' => array(object(__TwigTemplate_2fc868b826fd2331f8bf6a7a5d93e557), 'block_sonata_page_container'), 'sonata_page_asset_footer' => array(object(__TwigTemplate_b624e3e86cf216a5c26f7250d4b6e392), 'block_sonata_page_asset_footer'), 'sonata_page_breadcrumb' => array(object(__TwigTemplate_2fc868b826fd2331f8bf6a7a5d93e557), 'block_sonata_page_breadcrumb'), 'page_content' => array(object(__TwigTemplate_2fc868b826fd2331f8bf6a7a5d93e557), 'block_page_content')))
     (vendor/twig/twig/src/Template.php:394)
  at Twig\Template->displayWithErrorHandling(array('error_codes' => array('_page_internal_error_not_found', '_page_internal_error_fatal'), 'page' => object(SnapshotPageProxy), 'site' => object(SonataPageSite), 'wrap_fields_with_addons' => true, 'app' => object(AppVariable), 'sonata_block' => object(GlobalVariables), 'sonata_config' => object(SonataConfiguration), 'sonata_page' => object(GlobalVariables), 'sonata_page_admin' => object(PageAdmin)), array('sonata_page_html_tag' => array(object(__TwigTemplate_b624e3e86cf216a5c26f7250d4b6e392), 'block_sonata_page_html_tag'), 'sonata_page_head' => array(object(__TwigTemplate_b624e3e86cf216a5c26f7250d4b6e392), 'block_sonata_page_head'), 'sonata_page_stylesheets' => array(object(__TwigTemplate_b624e3e86cf216a5c26f7250d4b6e392), 'block_sonata_page_stylesheets'), 'sonata_page_javascripts' => array(object(__TwigTemplate_b624e3e86cf216a5c26f7250d4b6e392), 'block_sonata_page_javascripts'), 'sonata_page_body_tag' => array(object(__TwigTemplate_b624e3e86cf216a5c26f7250d4b6e392), 'block_sonata_page_body_tag'), 'sonata_page_top_bar' => array(object(__TwigTemplate_b624e3e86cf216a5c26f7250d4b6e392), 'block_sonata_page_top_bar'), 'sonata_page_container' => array(object(__TwigTemplate_2fc868b826fd2331f8bf6a7a5d93e557), 'block_sonata_page_container'), 'sonata_page_asset_footer' => array(object(__TwigTemplate_b624e3e86cf216a5c26f7250d4b6e392), 'block_sonata_page_asset_footer'), 'sonata_page_breadcrumb' => array(object(__TwigTemplate_2fc868b826fd2331f8bf6a7a5d93e557), 'block_sonata_page_breadcrumb'), 'page_content' => array(object(__TwigTemplate_2fc868b826fd2331f8bf6a7a5d93e557), 'block_page_content')))
     (vendor/twig/twig/src/Template.php:367)
  at Twig\Template->display(array('error_codes' => array('_page_internal_error_not_found', '_page_internal_error_fatal'), 'page' => object(SnapshotPageProxy), 'site' => object(SonataPageSite), 'wrap_fields_with_addons' => true, 'app' => object(AppVariable), 'sonata_block' => object(GlobalVariables), 'sonata_config' => object(SonataConfiguration), 'sonata_page' => object(GlobalVariables), 'sonata_page_admin' => object(PageAdmin)), array('sonata_page_container' => array(object(__TwigTemplate_2fc868b826fd2331f8bf6a7a5d93e557), 'block_sonata_page_container'), 'sonata_page_breadcrumb' => array(object(__TwigTemplate_2fc868b826fd2331f8bf6a7a5d93e557), 'block_sonata_page_breadcrumb'), 'page_content' => array(object(__TwigTemplate_2fc868b826fd2331f8bf6a7a5d93e557), 'block_page_content')))
     (var/cache/dev/twig/e4/e4c29647b0e0d5437d3434e345fd1c27.php:50)
  at __TwigTemplate_2fc868b826fd2331f8bf6a7a5d93e557->doDisplay(array('error_codes' => array('_page_internal_error_not_found', '_page_internal_error_fatal'), 'page' => object(SnapshotPageProxy), 'site' => object(SonataPageSite), 'wrap_fields_with_addons' => true, 'app' => object(AppVariable), 'sonata_block' => object(GlobalVariables), 'sonata_config' => object(SonataConfiguration), 'sonata_page' => object(GlobalVariables), 'sonata_page_admin' => object(PageAdmin)), array('sonata_page_container' => array(object(__TwigTemplate_2fc868b826fd2331f8bf6a7a5d93e557), 'block_sonata_page_container'), 'sonata_page_breadcrumb' => array(object(__TwigTemplate_2fc868b826fd2331f8bf6a7a5d93e557), 'block_sonata_page_breadcrumb'), 'page_content' => array(object(__TwigTemplate_2fc868b826fd2331f8bf6a7a5d93e557), 'block_page_content')))
     (vendor/twig/twig/src/Template.php:394)
  at Twig\Template->displayWithErrorHandling(array('error_codes' => array('_page_internal_error_not_found', '_page_internal_error_fatal'), 'page' => object(SnapshotPageProxy), 'site' => object(SonataPageSite), 'wrap_fields_with_addons' => true, 'app' => object(AppVariable), 'sonata_block' => object(GlobalVariables), 'sonata_config' => object(SonataConfiguration), 'sonata_page' => object(GlobalVariables), 'sonata_page_admin' => object(PageAdmin)), array('sonata_page_container' => array(object(__TwigTemplate_2fc868b826fd2331f8bf6a7a5d93e557), 'block_sonata_page_container'), 'sonata_page_breadcrumb' => array(object(__TwigTemplate_2fc868b826fd2331f8bf6a7a5d93e557), 'block_sonata_page_breadcrumb'), 'page_content' => array(object(__TwigTemplate_2fc868b826fd2331f8bf6a7a5d93e557), 'block_page_content')))
     (vendor/twig/twig/src/Template.php:367)
  at Twig\Template->display(array('error_codes' => array('_page_internal_error_not_found', '_page_internal_error_fatal'), 'page' => object(SnapshotPageProxy), 'site' => object(SonataPageSite)))
     (vendor/twig/twig/src/Template.php:379)
  at Twig\Template->render(array('error_codes' => array('_page_internal_error_not_found', '_page_internal_error_fatal'), 'page' => object(SnapshotPageProxy), 'site' => object(SonataPageSite)), array())
     (vendor/twig/twig/src/TemplateWrapper.php:40)
  at Twig\TemplateWrapper->render(array('error_codes' => array('_page_internal_error_not_found', '_page_internal_error_fatal'), 'page' => object(SnapshotPageProxy), 'site' => object(SonataPageSite)))
     (vendor/twig/twig/src/Environment.php:277)
  at Twig\Environment->render('@SonataPage/layout.html.twig', array('error_codes' => array('_page_internal_error_not_found', '_page_internal_error_fatal'), 'page' => object(SnapshotPageProxy), 'site' => object(SonataPageSite)))
     (vendor/sonata-project/page-bundle/src/Page/TemplateManager.php:99)
  at Sonata\PageBundle\Page\TemplateManager->renderResponse('default', array('page' => object(SnapshotPageProxy), 'site' => object(SonataPageSite)), object(Response))
     (vendor/sonata-project/page-bundle/src/Page/Service/DefaultPageService.php:56)
  at Sonata\PageBundle\Page\Service\DefaultPageService->execute(object(SnapshotPageProxy), object(Request), array('page' => object(SnapshotPageProxy), 'site' => object(SonataPageSite)), object(Response))
     (vendor/sonata-project/page-bundle/src/Page/PageServiceManager.php:83)
  at Sonata\PageBundle\Page\PageServiceManager->execute(object(SnapshotPageProxy), object(Request), array('page' => object(SnapshotPageProxy), 'site' => object(SonataPageSite)), object(Response))
     (vendor/symfony/http-kernel/HttpKernel.php:159)
  at Symfony\Component\HttpKernel\HttpKernel->handleRaw(object(Request), 1)
     (vendor/symfony/http-kernel/HttpKernel.php:81)
  at Symfony\Component\HttpKernel\HttpKernel->handle(object(Request), 1, true)
     (vendor/symfony/http-kernel/Kernel.php:201)
  at Symfony\Component\HttpKernel\Kernel->handle(object(Request))
     (public/index.php:25)  

@eerison
Copy link
Contributor Author

eerison commented Oct 4, 2022

Question:

the recipe should be updated before or after 4.0 release?
symfony/recipes-contrib#1440

@jordisala1991
Copy link
Member

jordisala1991 commented Oct 6, 2022

When I add Menu block I get this error

Can you show how to reproduce the problem?

@eerison
Copy link
Contributor Author

eerison commented Oct 6, 2022

Screen.Recording.2022-10-06.at.09.30.39.mov

@jordisala1991 ☝🏼

@eerison
Copy link
Contributor Author

eerison commented Oct 18, 2022

Ok FYI I'm checking the issue above ☝🏼 !

@eerison
Copy link
Contributor Author

eerison commented Oct 20, 2022

I have the feeling that issue was introduced here: sonata-project/SonataBlockBundle@ebe82c8#diff-a09c2633c4f6405e5d208a92d7a26757d9617bf466977bc2ce42959c46768019

if you check the screenshot, the image_name is null and in theory it should return an ItemInterface
Screenshot 2022-10-20 at 15 43 53

https://github.com/sonata-project/SonataBlockBundle/blob/4.x/src/Block/Service/MenuBlockService.php#L144

@VincentLanglet do you have any idea why it's happening?

@VincentLanglet
Copy link
Member

I have the feeling that issue was introduced here: sonata-project/SonataBlockBundle@ebe82c8#diff-a09c2633c4f6405e5d208a92d7a26757d9617bf466977bc2ce42959c46768019

This was supposed to be a BC refacto. Why was it working before ?

@eerison
Copy link
Contributor Author

eerison commented Oct 20, 2022

it was happening because I didn't pass the menu, I changed it for required

sonata-project/SonataBlockBundle#1124

Screenshot 2022-10-20 at 16 17 34

Screenshot 2022-10-20 at 16 17 03

@VincentLanglet
Copy link
Member

But if you pass no menu, with a blockBundle version without my refacto, do you also have the bug ?

@eerison
Copy link
Contributor Author

eerison commented Oct 20, 2022

But if you pass no menu, with a blockBundle version without my refactor, do you also have the bug ?

I tried to use block bundle v4.17, But I got an issue related with src/Block/Service/AbstractMenuBlockService.php this class wasn't found!

maybe I need to back some commits in page bundle as well!

But for this works before, maybe the sonata_admin_sidebar was a default value.

@eerison
Copy link
Contributor Author

eerison commented Oct 20, 2022

Hey @VincentLanglet

I tested using a commit before your changes: d3b9eaa
with BlockBundle v4.17, and I got the same issue! then I guess this issue was there before But maybe we didn't see this because we fill out all fields!

@VincentLanglet
Copy link
Member

I tested using a commit before your changes: d3b9eaa
with BlockBundle v4.17, and I got the same issue!

Ok, that's reassuring. Your fix seems ok.

@haivala
Copy link
Contributor

haivala commented Oct 20, 2022

Can we release alpha now or do we need to wait for those 2 commits?

@eerison
Copy link
Contributor Author

eerison commented Oct 21, 2022

Maybe after merge this: sonata-project/SonataBlockBundle#1124

we could require the latest version from seo bundle and block bundle, what do you think?

@VincentLanglet
Copy link
Member

we could require the latest version from seo bundle and block bundle, what do you think?

This is not needed. We won't bump seo/block dependency every time a bug is fixed.
If people wants to be bug free, they just bump their dependency.

Does SonataPage work with older versions of SeoBunde ? Yes, they just have a different wording.
Does SonataPage work with older versions of BlockBundle ? Yes, they just have a non-required field.

If there is no other bugfix needed, we can release alpha version.

@eerison
Copy link
Contributor Author

eerison commented Oct 22, 2022

we could require the latest version from seo bundle and block bundle, what do you think?

This is not needed. We won't bump seo/block dependency every time a bug is fixed. If people wants to be bug free, they just bump their dependency.

Does SonataPage work with older versions of SeoBunde ? Yes, they just have a different wording. Does SonataPage work with older versions of BlockBundle ? Yes, they just have a non-required field.

If there is no other bugfix needed, we can release alpha version.

Ahhhh I got it, I thought that we must do this always when we fix a issue related with some dependency.

Ok it's clear :)

@VincentLanglet
Copy link
Member

Ahhhh I got it, I thought that we must do this always when we fix a issue related with some dependency.

You only have to bump the dependency when you use a new feature.

If PageBundle rely on a method/class introduced in SonataBlock 4.20, we have to update the dependency to
^4.20 since on 4.19 the code will crash since the method won't exist.

@eerison
Copy link
Contributor Author

eerison commented Oct 22, 2022

we could require the latest version from seo bundle and block bundle, what do you think?

This is not needed. We won't bump seo/block dependency every time a bug is fixed. If people wants to be bug free, they just bump their dependency.

Does SonataPage work with older versions of SeoBunde ? Yes, they just have a different wording. Does SonataPage work with older versions of BlockBundle ? Yes, they just have a non-required field.

If there is no other bugfix needed, we can release alpha version.

There aren't anything issue that I found in page bundle, the pull request in symfony recipe can be merge later :)

IMO We can release an alpha version :)

@VincentLanglet
Copy link
Member

WIP #1630

Let's close this issue then.

@mesiarm
Copy link

mesiarm commented Oct 23, 2022

WIP #1630

Let's close this issue then.

When we can look forward to 4.0 release?

@VincentLanglet
Copy link
Member

4.0.0-alpha is already released.

@mesiarm
Copy link

mesiarm commented Oct 23, 2022

4.0.0-alpha is already released.

Great. Will try in next project.

@VincentLanglet
Copy link
Member

@eerison Any issue with the 4.0 version ? We could move on to RC version (or even the real version...)
cc @jordisala1991

@eerison
Copy link
Contributor Author

eerison commented Nov 30, 2022

In the company some projects were still into the upgrade process to page bundle 4, but as I saw the feedbacks everything as fine!

@eerison
Copy link
Contributor Author

eerison commented Nov 30, 2022

After release version 4 should be nice if sonata page bundle flex was merged as well, but it doesn't depend of us, does it?

@mesiarm
Copy link

mesiarm commented Nov 30, 2022

@eerison Any issue with the 4.0 version ? We could move on to RC version (or even the real version...) cc @jordisala1991

I updated it and tested yesterday. It took some time because i needed to update all other bundles, but Sonata Page seems working so far.

@haivala
Copy link
Contributor

haivala commented Nov 30, 2022

Same here! It is working

@VincentLanglet
Copy link
Member

4.0.0 is released

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

7 participants