-
-
Notifications
You must be signed in to change notification settings - Fork 210
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Release 4.0 #1495
Comments
Updated Sonata admin 4
|
well the 4.x branch is unusable, if you just navigate into the admin you will get some internal server error! |
do you think make sense I create more bug issues @VincentLanglet? |
Havind all the issues in the same issue might be enough |
For
it's the same issue than #1498 I proposed a solution. |
NIce ❤️ |
For
I assume the translations exists either But SonataAdmin changed the way he generated the translation keys. So the
to
By changing SonataPageBundle/src/Admin/PageAdmin.php Lines 281 to 283 in f2ca4ea
or even
|
For create_snapshot, it's #1502 IMHO |
I added a new issue in dashboard |
Hey, I will work on missing translations |
@VincentLanglet have you tried to add this in the pipelines: https://symfony.com/doc/current/translation/debug.html to get the missing translations? |
It would miss all the translation key generated dynamically if I understand correctly |
true :( |
For this error, seems like the BlockManager is done in 4.x is not working Is there a way to avoid removing the |
Saw the same error and tried to fix, but didn't found a solution without touching BlockBundle. I only tried for half an hour, so I might be wrong. |
Seems ok to me to touch the BlockBundle, but I would have prefer to avoid removing the final keyword. FormType has things like a |
I was checking with @Amin-Hosseini this issue related with @Amin-Hosseini please share where what have you find ATM! |
I've checked #1483 changes and as we don't have I tried to update I can create a PR, if you think it's the good solution :-) |
|
I might misunderstand the solution but the issue I see is that we cannot validate the values/type of the extra settings ; it would be so nice to be able to configure extra settings in the PageBundle BlockContextManager. |
Well should be good we think in some solution using interfaces, usually those abstract class going to increase 😞 |
It's an issue with your code IMHO @eerison |
Really? I don't remember to change something inf Block::page |
When I add Menu block I get this error
|
Question: the recipe should be updated before or after 4.0 release? |
Can you show how to reproduce the problem? |
Screen.Recording.2022-10-06.at.09.30.39.mov |
Ok FYI I'm checking the issue above ☝🏼 ! |
I have the feeling that issue was introduced here: sonata-project/SonataBlockBundle@ebe82c8#diff-a09c2633c4f6405e5d208a92d7a26757d9617bf466977bc2ce42959c46768019 if you check the screenshot, the image_name is @VincentLanglet do you have any idea why it's happening? |
This was supposed to be a BC refacto. Why was it working before ? |
it was happening because I didn't pass the menu, I changed it for required |
But if you pass no menu, with a blockBundle version without my refacto, do you also have the bug ? |
I tried to use block bundle maybe I need to back some commits in page bundle as well! But for this works before, maybe the |
Hey @VincentLanglet I tested using a commit before your changes: d3b9eaa |
Ok, that's reassuring. Your fix seems ok. |
Can we release alpha now or do we need to wait for those 2 commits? |
Maybe after merge this: sonata-project/SonataBlockBundle#1124 we could require the latest version from seo bundle and block bundle, what do you think? |
This is not needed. We won't bump seo/block dependency every time a bug is fixed. Does SonataPage work with older versions of SeoBunde ? Yes, they just have a different wording. If there is no other bugfix needed, we can release alpha version. |
Ahhhh I got it, I thought that we must do this always when we fix a issue related with some dependency. Ok it's clear :) |
You only have to bump the dependency when you use a new feature. If PageBundle rely on a method/class introduced in SonataBlock 4.20, we have to update the dependency to |
There aren't anything issue that I found in page bundle, the pull request in symfony recipe can be merge later :) IMO We can release an alpha version :) |
WIP #1630 Let's close this issue then. |
When we can look forward to 4.0 release? |
4.0.0-alpha is already released. |
Great. Will try in next project. |
@eerison Any issue with the 4.0 version ? We could move on to RC version (or even the real version...) |
In the company some projects were still into the upgrade process to page bundle 4, but as I saw the feedbacks everything as fine! |
After release version 4 should be nice if sonata page bundle flex was merged as well, but it doesn't depend of us, does it? |
I updated it and tested yesterday. It took some time because i needed to update all other bundles, but Sonata Page seems working so far. |
Same here! It is working |
4.0.0 is released |
I'm using this branch to test the upgrade from 3.x branch to 4.x
Those issues need to be solved before release 4.0 version
CSS / Javascript:
Other:
Completed:
requires ^4.8
, Batch delete for shared blocks does not work: Release 4.0 #1495 (comment)sonata_block.context_manager: sonata.page.block.context_manager
andsonata_page.slugify_service: sonata.page.slugify.cocur
An exception has been thrown during the rendering of a template ("The block service
sonata.seo.block.email.share_buttondoes not exist").
http://localhost:8001/admin/app/sonatapagesite/list
is returning this internal server error:An exception has been thrown during the rendering of a template ("Cannot access property "create_snapshots" in class "App\Entity\SonataPageSite".").
form.group_form_page_group_main_label
,form.group_form_page_group_seo_label
,form.group_form_page_group_advanced_label
look here: Release 4.0 #1495 (comment)Action "tree" could not be found in access mapping. Please make sure your action is defined into your admin class accessMapping property.
http://localhost:8001/admin/dashboard
is returningAn exception has been thrown during the rendering of a template ("The options "manager", "page_id" do not exist. Defined options are: "attr", "extra_cache_keys", "groups", "template", "ttl", "use_cache".").
composer update -W
, I'm facing this issueCompile Error: Type of App\Entity\SonataPageBlock::$page must be ?Sonata\Pa !! geBundle\Model\PageInterface (as in class Sonata\PageBundle\Model\Block)
atIn SonataPageBlock.php line 16:
http://localhost:8001/admin/app/sonatapagepage/642/compose
), I got this errorVariable "admin_pool" does not exist.
Remove usage of 'admin_pool' in twig templates #1533/admin/app/sonatapagesnapshot/create
: Release 4.0 #1495 (comment)The text was updated successfully, but these errors were encountered: