Make SonataEasyExtends optional #1162
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
26 tasks
|
Could you please rebase your PR and fix merge conflicts? |
jordisala1991
force-pushed
the
feature/make-easy-extends-optional
branch
from
54dc6a2
to
b46da17
Compare
jordisala1991
force-pushed
the
feature/make-easy-extends-optional
branch
from
b46da17
to
dfd7e7f
Compare
|
Could you please rebase your PR and fix merge conflicts? |
jordisala1991
force-pushed
the
feature/make-easy-extends-optional
branch
from
dfd7e7f
to
9b0ac04
Compare
core23
reviewed
Jul 21, 2020
jordisala1991
force-pushed
the
feature/make-easy-extends-optional
branch
2 times, most recently
from
50c8a9c
to
f168b8d
Compare
jordisala1991
force-pushed
the
feature/make-easy-extends-optional
branch
from
f168b8d
to
2c6412f
Compare
jordisala1991
force-pushed
the
feature/make-easy-extends-optional
branch
from
2c6412f
to
8aedbd8
Compare
jordisala1991
force-pushed
the
feature/make-easy-extends-optional
branch
2 times, most recently
from
e60d985
to
89ececa
Compare
VincentLanglet
previously approved these changes
Jul 25, 2020
phansys
requested changes
Jul 25, 2020
jordisala1991
force-pushed
the
feature/make-easy-extends-optional
branch
from
89ececa
to
e5c4704
Compare
phansys
previously approved these changes
Jul 25, 2020
phansys
reviewed
Jul 25, 2020
jordisala1991
force-pushed
the
feature/make-easy-extends-optional
branch
from
e5c4704
to
676168b
Compare
phansys
approved these changes
Jul 25, 2020
VincentLanglet
approved these changes
Jul 25, 2020
|
Thanks @jordisala1991 ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Subject
I am targeting this branch, because this is BC.
Part of: sonata-project/dev-kit#750
SonataEasyExtends is deprecated but it is used on many bundles, this makes it optional. This change is BC because if the user does not change anything it will continue using the deprecated code but with a message.
Changelog
To do