Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to Sonata 4 #1485

Merged

Conversation

jordisala1991
Copy link
Member

@jordisala1991 jordisala1991 commented Jul 22, 2022

Subject

I am targeting this branch, because this includes a lot of BC breaks.

Part of #1416 #1417

Changelog

### Added
- Add support for Sonata ^4.

@eerison
Copy link
Contributor

eerison commented Jul 22, 2022

I imagined that you could fix this faster then me 😄

But for your pipeline pass you need to use 4.x as 4.14.0 or create a release in sonata admin

@eerison
Copy link
Contributor

eerison commented Jul 22, 2022

because of this PR: sonata-project/SonataAdminBundle#7867

@jordisala1991
Copy link
Member Author

I know, but I wanted to start the Pr to see how it looked.

@jordisala1991 jordisala1991 force-pushed the feature/upgrade-sonata-admin-4 branch from f11bb93 to 2a41d8f Compare July 23, 2022 18:16
@jordisala1991 jordisala1991 marked this pull request as ready for review July 23, 2022 18:16
src/Admin/SharedBlockAdmin.php Outdated Show resolved Hide resolved
src/Admin/SharedBlockAdmin.php Outdated Show resolved Hide resolved
@SonataCI
Copy link
Collaborator

Could you please rebase your PR and fix merge conflicts?

@VincentLanglet
Copy link
Member

We will need you @eerison to both try the 3.x branch (in order to release all the deprecation) and to try this branch (with Sonata 4) to confirm that everything work as expected.

For the 4.x branch, it can still be done later or when the alpha will be release. But the 3.x branch should be tested because it will be a pretty huge release.

@eerison
Copy link
Contributor

eerison commented Jul 24, 2022

We will need you @eerison to both try the 3.x branch (in order to release all the deprecation) and to try this branch (with Sonata 4) to confirm that everything work as expected.

For the 4.x branch, it can still be done later or when the alpha will be release. But the 3.x branch should be tested because it will be a pretty huge release.

Ok tomorrow on the morning I'll test 3.x release and I will confirm here :)

VincentLanglet
VincentLanglet previously approved these changes Jul 24, 2022
@VincentLanglet VincentLanglet mentioned this pull request Jul 24, 2022
17 tasks
VincentLanglet
VincentLanglet previously approved these changes Jul 24, 2022
@jordisala1991 jordisala1991 force-pushed the feature/upgrade-sonata-admin-4 branch from 5f877e3 to 015adee Compare July 25, 2022 05:46
@VincentLanglet VincentLanglet merged commit 88f0740 into sonata-project:4.x Jul 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants