-
-
Notifications
You must be signed in to change notification settings - Fork 210
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove Slugify Method #1506
Remove Slugify Method #1506
Conversation
3249108
to
b06d7e1
Compare
TBH I don't even know why is this needed. Since there is only that call to the setter, and the getter is never used (AFAIK). @eerison do you have another opinion? |
b06d7e1
to
0fdccee
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Phpstan is failing.
You need to update public static function slugify($text)
Yep, now I saw the usage... I will refactor code to not need any of this black magic |
Hey @jordisala1991 I didn't check how it's done But I know that we use the slugfy for pages, but if I remember correct we can't set, it's based on the page name 🤔 |
47507ca
to
6e4be34
Compare
6e4be34
to
8290d6d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We need a PR on 3.x with a BC way to use the new constructor signature of PageManager
I need some help for all those 3.x BC things... otherwise it will take ages to get there. In this case, the manager will be final on 4.x. Do we need to provide such a BC path? |
If someone call
on 4.x it will crash So we need to do
on 3.x. |
Is not that easy, I will need to inject the variable, and try to use it. But we don't know how the user is calling the setSlugifyMethod on the page model. So at the end, all of it could be a bc break. |
If it's too hard, we can accept the non-solvabel BC break to release 4.x faster then |
Subject
I am targeting this branch, because this is BC break.
Changelog