Drop support for PHP 7.3 #585
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Sep 16, 2021
Merged
| * @var array | ||
| */ | ||
| private $blockServices = []; | ||
| private array $blockServices = []; |
There was a problem hiding this comment.
We can still add phpdoc array<...>
There was a problem hiding this comment.
Will check this when increasing phpstan / psalm level
VincentLanglet
approved these changes
Sep 16, 2021
|
Do you think it is a good idea for next majors to have different php required versions? |
I don't see any issue with this. You can still bump Php and then the major version. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Subject
Drop support for PHP 7.3, because active support will end in a few days. This allows us to add type hints everywhere.
I am targeting this branch, because this is a major change.
Changelog