Prepare major release #609

core23 · 2021-10-07T20:43:12Z

Subject

I am targeting this branch, because this should be the last changes for the next major release.

Changelog

### Changed
- Made `sonata.seo.sitemap.manager` service private

### Removed
- Remove all `sonata.seo.*.class` parameters from container

VincentLanglet · 2021-10-07T20:48:16Z

If we follow the same strategy than other bundle, we should also

Bump phpstan level 8: https://github.com/sonata-project/SonataSeoBundle/blob/3.x/phpstan.neon.dist#L5
Add the strict-rules plugin of phpstan (we found a lot of bug with it on SonataAdmin)
Bump psalm level 3: https://github.com/sonata-project/SonataSeoBundle/blob/3.x/psalm.xml#L2

And we might determine what we do with #600 (review)

core23 · 2021-10-07T21:10:32Z

Bump phpstan level 8: https://github.com/sonata-project/SonataSeoBundle/blob/3.x/phpstan.neon.dist#L5

Add the strict-rules plugin of phpstan (we found a lot of bug with it on SonataAdmin)

Bump psalm level 3: https://github.com/sonata-project/SonataSeoBundle/blob/3.x/psalm.xml#L2

Done

And we might determine what we do with #600 (review)

We can still implement the feature on the next major version

src/Resources/config/services.php

franmomu · 2021-10-07T21:46:55Z

src/Resources/config/services.php

    $containerConfigurator->services()

-        ->set('sonata.seo.page.default', '%sonata.seo.page.default.class%')
+        ->set('sonata.seo.page.default', SeoPage::class)
            ->public()


I haven't checked the usages, but do we need services to be public?

Not sure if symfony still recommends using the service container. If it's deprecated we could make this private.

Looks like it depends on the usage:

In addition, services not meant to be used by the application directly, should be defined as private. For public services, aliases should be created from the interface/class to the service id.

(I haven checked, but I guess they don't recommend using the service container directly.)

src/Sitemap/SourceManager.php

src/Block/Breadcrumb/BreadcrumbBlockService.php

wbloszyk · 2021-10-08T06:37:23Z

src/DependencyInjection/SonataSeoExtension.php

-            $connectionIterator = new Definition('%sonata.seo.exporter.database_source_iterator.class%', [
+            $connectionIterator = new Definition(DoctrineDBALConnectionSourceIterator::class, [


I'm not familiar with this, but if we have paramteter here should not be better to keep it and set it in config?

We could improve this by allowing a custom service via the config, but for now we should get rid of all class parameters.

wbloszyk · 2021-10-08T06:37:38Z

src/DependencyInjection/SonataSeoExtension.php

@@ -86,7 +89,7 @@ private function configureSitemap(array $config, ContainerBuilder $container): v
            // define the sitemap proxy iterator
            $sitemapIteratorId = 'sonata.seo.source.doctrine_sitemap_iterator_'.$pos;

-            $sitemapIterator = new Definition('%sonata.seo.exporter.sitemap_source_iterator.class%', [
+            $sitemapIterator = new Definition(SymfonySitemapSourceIterator::class, [


I'm not familiar with this, but if we have paramteter here should not be better to keep it and set it in config?

wbloszyk · 2021-10-08T06:40:17Z

Before next major release we should decide about one importan thing.

After 2 months (59 days) support for PHP 7.3 will be end. If we drop it now then we can also declare types for parameters. Do it in stable branch will be BC.

WDYT? @sonata-project/contributors

franmomu · 2021-10-08T06:53:07Z

Before next major release we should decide about one importan thing.

After 2 months (59 days) support for PHP 7.3 will be end. If we drop it now then we can also declare types for parameters. Do it in stable branch will be BC.

WDYT? @sonata-project/contributors

It's already dropped in this bundle:

SonataSeoBundle/composer.json

Line 23 in 23cf25d

"php": "^7.4 || ^8.0",

wbloszyk · 2021-10-08T07:10:06Z

I want check it this bundle before major release in the evening. So can we wait with major release to tomorrow?

VincentLanglet · 2021-10-08T14:44:50Z

I want check it this bundle before major release in the evening. So can we wait with major release to tomorrow?

We should try with an alpha/beta version anyway

core23 added the major label Oct 7, 2021

core23 force-pushed the prepare-major branch 2 times, most recently from 0aa95b4 to 0af359f Compare October 7, 2021 20:46

core23 requested a review from a team October 7, 2021 20:47

Remove deprecated code

915a7d2

core23 force-pushed the prepare-major branch 2 times, most recently from 596d228 to 9929d6a Compare October 7, 2021 20:51

core23 force-pushed the prepare-major branch 2 times, most recently from 5e0c2d0 to 1aa5c38 Compare October 7, 2021 21:13

franmomu reviewed Oct 7, 2021

View reviewed changes

core23 force-pushed the prepare-major branch 2 times, most recently from 74f9b04 to 8d5a296 Compare October 8, 2021 06:02

core23 added 6 commits October 8, 2021 08:04

Remove class parameters from container

b4d9184

Close API

defccbf

Remove useless call to empty parent method

93ff6dc

Increase psalm / phpstan level

f7a6287

Fix UPGRADE notes

61a5dd6

Make sonata.seo.sitemap.manager service private

92fb05c

core23 force-pushed the prepare-major branch from 8d5a296 to 92fb05c Compare October 8, 2021 06:04

franmomu approved these changes Oct 8, 2021

View reviewed changes

wbloszyk requested changes Oct 8, 2021

View reviewed changes

VincentLanglet approved these changes Oct 8, 2021

View reviewed changes

wbloszyk approved these changes Oct 8, 2021

View reviewed changes

core23 merged commit 9be74b1 into sonata-project:3.x Oct 8, 2021

core23 deleted the prepare-major branch October 8, 2021 14:41

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Prepare major release #609

Prepare major release #609

core23 commented Oct 7, 2021 •

edited

Loading

VincentLanglet commented Oct 7, 2021

core23 commented Oct 7, 2021

franmomu Oct 7, 2021

core23 Oct 8, 2021

franmomu Oct 8, 2021 •

edited

Loading

wbloszyk Oct 8, 2021

core23 Oct 8, 2021

wbloszyk Oct 8, 2021

wbloszyk commented Oct 8, 2021

franmomu commented Oct 8, 2021

wbloszyk commented Oct 8, 2021

VincentLanglet commented Oct 8, 2021

		$connectionIterator = new Definition('%sonata.seo.exporter.database_source_iterator.class%', [
		$connectionIterator = new Definition(DoctrineDBALConnectionSourceIterator::class, [

Prepare major release #609

Prepare major release #609

Conversation

core23 commented Oct 7, 2021 • edited Loading

Subject

Changelog

VincentLanglet commented Oct 7, 2021

core23 commented Oct 7, 2021

franmomu Oct 7, 2021

Choose a reason for hiding this comment

core23 Oct 8, 2021

Choose a reason for hiding this comment

franmomu Oct 8, 2021 • edited Loading

Choose a reason for hiding this comment

wbloszyk Oct 8, 2021

Choose a reason for hiding this comment

core23 Oct 8, 2021

Choose a reason for hiding this comment

wbloszyk Oct 8, 2021

Choose a reason for hiding this comment

wbloszyk commented Oct 8, 2021

franmomu commented Oct 8, 2021

wbloszyk commented Oct 8, 2021

VincentLanglet commented Oct 8, 2021

core23 commented Oct 7, 2021 •

edited

Loading

franmomu Oct 8, 2021 •

edited

Loading