Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove BaseBreadcrumbMenuBlockService::getRootMenu #624

Merged
merged 1 commit into from
Nov 1, 2021
Merged

Remove BaseBreadcrumbMenuBlockService::getRootMenu #624

merged 1 commit into from
Nov 1, 2021

Conversation

core23
Copy link
Member

@core23 core23 commented Nov 1, 2021 •
edited by phansys
Loading

Subject

I am targeting this branch, because this is a major upgrade path.

Changelog

### Changed
- `BaseBreadcrumbMenuBlockService::getMenu()` method contains the root menu

### Removed
- `BaseBreadcrumbMenuBlockService::getRootMenu()` method

@core23 core23 added the major label Nov 1, 2021
@core23 core23 requested a review from a team November 1, 2021 16:14
@core23 core23 mentioned this pull request Nov 1, 2021
Merged
VincentLanglet
VincentLanglet reviewed Nov 1, 2021
View reviewed changes
src/Block/Breadcrumb/BaseBreadcrumbMenuBlockService.php Outdated Show resolved Hide resolved
src/Block/Breadcrumb/BaseBreadcrumbMenuBlockService.php Outdated Show resolved Hide resolved
tests/Block/Breadcrumb/BreadcrumbTest.php Outdated Show resolved Hide resolved
src/Block/Breadcrumb/BaseBreadcrumbMenuBlockService.php
return $this->factory;
}

abstract protected function getContext(): string;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You may add the changes of https://github.com/sonata-project/SonataSeoBundle/pull/622/files in this PR ?

VincentLanglet
VincentLanglet previously approved these changes Nov 1, 2021
View reviewed changes
@VincentLanglet VincentLanglet requested a review from a team November 1, 2021 16:19
phansys
phansys requested changes Nov 1, 2021
View reviewed changes
UPGRADE-3.0.md Outdated Show resolved Hide resolved
UPGRADE-3.0.md Outdated Show resolved Hide resolved
UPGRADE-3.0.md Outdated Show resolved Hide resolved
VincentLanglet
VincentLanglet previously approved these changes Nov 1, 2021
View reviewed changes
phansys
phansys requested changes Nov 1, 2021
View reviewed changes
UPGRADE-3.0.md Outdated Show resolved Hide resolved
@VincentLanglet VincentLanglet merged commit 159efe6 into sonata-project:3.x Nov 1, 2021
@VincentLanglet
Copy link
Member

thanks

@core23 core23 deleted the merge-menu branch November 1, 2021 17:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@VincentLanglet VincentLanglet VincentLanglet approved these changes

@phansys phansys phansys approved these changes

Assignees
No one assigned
Labels
major
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@core23 @VincentLanglet @phansys