Improve fixtures 3 #636
Improve fixtures 3 #636
Conversation
wbloszyk
force-pushed
the
improve_fixtures_3
branch
2 times, most recently
from
8588bf9
to
253fc73
Compare
wbloszyk
force-pushed
the
improve_fixtures_3
branch
2 times, most recently
from
69efdc6
to
440b0d1
Compare
|
@core23 @VincentLanglet @phansys Can you check it? It is RTM and require for next PRs. |
|
|
||
| $gallery->addGalleryHasMedias($galleryHasMedia); | ||
| } | ||
|
|
||
| protected function createMedia($file, string $name, string $autor, Category $category, bool $enabled = true, string $copyright = 'CC BY-NC-SA 4.0') |
There was a problem hiding this comment.
Can this method be private?
| protected function createMedia($file, string $name, string $autor, Category $category, bool $enabled = true, string $copyright = 'CC BY-NC-SA 4.0') | |
| protected function createMedia(string $file, string $name, string $autor, Category $category, bool $enabled = true, string $copyright = 'CC BY-NC-SA 4.0') |
There was a problem hiding this comment.
$file can be string or File like setBinaryContext.
IMHO we should keep Api open as much as it is possible in Demo. This will allow user to people to test it and understand how sonata work.
There was a problem hiding this comment.
It's ok then. Could you please add a docblock for this argument?
|
@phansys @jordisala1991 Can we merge it? |
|
IMO yes, @phansys wdyt? |
I just leave a small suggestion about an argument's docblock. IMO, it's RTM. |
|
The phpdoc could be indeed great before merging this. |
|
I need this PR to webpack. I will work on dobclock, update API, fix file structure in next PRs too. So lets merge it now. BTW. I working on sandbox 3.0 |
|
This is an open source project, every body can use it, working on it. We're just asking this change. |
wbloszyk
force-pushed
the
improve_fixtures_3
branch
from
440b0d1
to
bf0b8cc
Compare
/**
* @param string|File $file File pathname or `Symfony\Component\HttpFoundation\File` object
*
* @return Media
*/
protected function createMedia( |
* improve fixtures * Add static code analysis through GitHub actions * Improve fixtures 2 * Add initial Docker configuration * Add dependabot to keep dependencies up to date * Improve fixtures 3 (#636) Co-authored-by: Javier Spagnoletti <[email protected]> Co-authored-by: Jordi <[email protected]>
No description provided.