Update check #208

bhamail · 2021-01-08T04:59:39Z

Automatic check for new releases. Prompt user when new version is available.

The automatic check will only occur once every 28 hours.
The timestamp of the lookup is stored in an app specific yml file:
~/.ossindex/.nancy-config/update_check.yml

This PR also adds an explicit update command that can be used to force a check for a new release. e.g.
nancy update

In order for the release lookup logic to be happy, I had to change the goreleaser release filename template a little. (see .goreleaser.yml)
The related logic in the selfupdater is: https://github.com/rhysd/go-github-selfupdate/blob/master/selfupdate/detect.go#L95. The suffixes used to find a matching release file didn't like the 'version' on the tail end, so I moved it.
Note: I'm guessing something in homebrew-nancy-tap will need to change to match the new filename pattern (or maybe it'll "just work")?

Once we have some releases with the new filename pattern, I can work on adding "auto update" stuff for certain cases.

It relates to the following issue #s:

Fixes Provide option for nancy to auto-update #140

cc @bhamail / @DarthHater

https://github.com/rhysd/go-github-selfupdate/blob/master/selfupdate/detect.go#L95

… on demand.

bhamail · 2021-01-08T19:58:52Z

I will look into merging the goreleaser template changes first. That would allow me to do more testing.

zendern · 2021-01-08T20:14:49Z

internal/cmd/update.go

+	/*	updateCmd.AddCommand(&cobra.Command{
+			Use:    "check",
+			Hidden: true,
+			Short:  "Check if there are any updates available",
+			RunE: func(_ *cobra.Command, _ []string) error {
+				return updateCLI("", false)
+			},
+		})
+	*/
+	/*	updateCmd.AddCommand(&cobra.Command{
+			Use:    "install",
+			Hidden: true,
+			Short:  "Update the tool to the latest version",
+			PersistentPreRun: func(_ *cobra.Command, _ []string) {
+				opts.cfg.SkipUpdateCheck = true
+			},
+			PreRun: func(cmd *cobra.Command, args []string) {
+				opts.args = args
+			},
+			RunE: func(_ *cobra.Command, _ []string) error {
+				return updateCLI(opts)
+			},
+		})
+	*/


So what are these?? Future state?? If the plan is to have it be nancy update check and nancy update install we should probably first pass make it actually be nancy update check instead of changing the api again probably very soon.

So what are these?? Future state?? If the plan is to have it be nancy update check and nancy update install we should probably first pass make it actually be nancy update check instead of changing the api again probably very soon.

Yeah, far future state. The really nice CircleCI CLI code I'm basing this off of has some complex (to my brain anyway) logic that sets some flags (opts...) on "hidden" commands to affect if/when an "install" is attempted (dryRun). I don't think I want to go down the same path. Maybe I'll change my mind if a light bulb goes on for me, but I'm gonna try and keep it simpler.

I kept these commented chunks around mostly to remember to flesh out the "install" stuff.

Deleted these comments in 1882f98

Created #209 to track future work.

zendern · 2021-01-08T20:16:54Z

internal/cmd/check.go

+		return err
+	}
+
+	if update.ShouldCheckForUpdates(updateCheck) {


This is probably fine....but thinking of how we do CI.... not much gets cached. So once we make this automatic its going to be checking all the time if the underlying docker CI containers always get blown away. We we still want to do it automatically we probably need to add something to the README about caching the ~/.ossindex dir.

This is probably fine....but thinking of how we do CI.... not much gets cached. So once we make this automatic its going to be checking all the time if the underlying docker CI containers always get blown away. We we still want to do it automatically we probably need to add something to the README about caching the ~/.ossindex dir.

Great point! I'll try to add some doco about this. I actually like the idea of it printing messages about an updated Nancy version in CI builds. Slightly increasing the chance a human will notice it in the CI logs. Still worth mentioning though.

Added some docs here: c62fded

zendern · 2021-01-08T20:27:02Z

internal/cmd/update.go

+
+func logAndShowMessage(message string) {
+	logLady.Info(message)
+	fmt.Println(message)


Do we want to respect the quiet flag here??

Maybe its fine.... realistically this is for humans only right?? Not really a CI thing and probably doesn't hurt to log some more.

I see your thinking, and am still leaning to leaving the "nag" enabled even in "quiet" mode. If somebody complains, we can tweak things.

zendern · 2021-01-08T20:30:51Z

buildversion/version.go

+// You can override this value using -X flag to the compiler ldflags. This is
+// overridden when we build for Homebrew.


So this still needs done so that homebrew will be set here??

So this still needs done so that homebrew will be set here??

Err, um, yes? This falls into the bucket of "I still don't know exactly how that will all work". :)

zendern · 2021-01-08T20:47:34Z

$ ./nancy update
Checking for updates...
You are running 0.0.0
A new release is available (1.0.6)
You can visit the Github releases page for the CLI to manually download and install:
https://github.com/sonatype-nexus-community/nancy/releases

As per @bhamail ... this is some sample output

bhamail · 2021-01-08T22:08:15Z

Fixed a boog in the autocheck execution path. Some sample output:

$ ./nancy 
Checking for updates...
You are running 0.0.0
A new release is available (1.0.6)
You can visit the Github releases page for the CLI to manually download and install:
https://github.com/sonatype-nexus-community/nancy/releases


Usage:
  nancy [flags]
...

…to track future work.

Automatic check for new releases. Prompt user when new version is available.

bhamail added 8 commits January 6, 2021 21:30

tweak test error message

340489b

change release filename templates to allow matching by selfupdate. see:

1e21103

https://github.com/rhysd/go-github-selfupdate/blob/master/selfupdate/detect.go#L95

add automatic check for newer release and new update command to check…

2473c47

… on demand.

cleanup parameter messiness

6d2e344

comment fix

2abe0da

un-twiddle import

a148f0d

remove extraneous function

0c49ea8

remove extraneous function

bafcd1c

bhamail requested review from DarthHater and zendern January 8, 2021 04:59

bhamail added 3 commits January 8, 2021 00:04

cleanup output to stdout

354f945

server utility method test/rename

49f703f

Doh! Forgot to add the test source

988a85b

zendern reviewed Jan 8, 2021

View reviewed changes

Merge remote-tracking branch 'origin/main' into update_check

308450d

bhamail added 5 commits January 8, 2021 15:50

fix tests for working release file names

205a033

delete redundant test

3a016a8

improve user messaging, logging

06ed5a5

delete bogus comment

122b044

fix slug bug. Hey, that rhymes.

95dacc3

bhamail added 3 commits January 8, 2021 17:24

update help text to latest output

db9605e

document useful thoughts from @zendern

c62fded

typo

2557496

bhamail mentioned this pull request Jan 11, 2021

Optional "install" of updated version #209

Open

Remove old comments that my just muddy the water. Created Issue #209 …

1882f98

…to track future work.

bhamail merged commit acc0816 into main Jan 11, 2021

bhamail deleted the update_check branch January 11, 2021 22:11

zendern pushed a commit to zendern/nancy that referenced this pull request Mar 7, 2022

Update check (sonatype-nexus-community#208)

5345116

Automatic check for new releases. Prompt user when new version is available.

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Update check #208

Update check #208

bhamail commented Jan 8, 2021 •

edited

Loading

bhamail commented Jan 8, 2021

zendern Jan 8, 2021

bhamail Jan 8, 2021 •

edited

Loading

bhamail Jan 11, 2021

zendern Jan 8, 2021

bhamail Jan 8, 2021

bhamail Jan 8, 2021

zendern Jan 8, 2021

zendern Jan 8, 2021

bhamail Jan 8, 2021

zendern Jan 8, 2021

bhamail Jan 8, 2021

zendern commented Jan 8, 2021 •

edited

Loading

bhamail commented Jan 8, 2021

		// You can override this value using -X flag to the compiler ldflags. This is
		// overridden when we build for Homebrew.

Update check #208

Update check #208

Conversation

bhamail commented Jan 8, 2021 • edited Loading

bhamail commented Jan 8, 2021

Choose a reason for hiding this comment

bhamail Jan 8, 2021 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

zendern commented Jan 8, 2021 • edited Loading

bhamail commented Jan 8, 2021

bhamail commented Jan 8, 2021 •

edited

Loading

bhamail Jan 8, 2021 •

edited

Loading

zendern commented Jan 8, 2021 •

edited

Loading