Skip to content

Commit

Permalink
health_check filter & README: fix typos (envoyproxy#11513)
Browse files Browse the repository at this point in the history
Signed-off-by: Martin Matusiak <[email protected]>
  • Loading branch information
numerodix authored and songhu committed Jun 25, 2020
1 parent f121211 commit 1f75dca
Show file tree
Hide file tree
Showing 2 changed files with 9 additions and 9 deletions.
6 changes: 3 additions & 3 deletions generated_api_shadow/README.md
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
This directory is for generated Envoy internal artifacts (via `proto_format`).

Do not hand edit any file under `envoy/`. This shadow API may only be used be
used in the Envoy source tree.
Do not hand edit any file under `envoy/`. This shadow API may only be used in
the Envoy source tree.

The `bazel/` tree is an symlink back to the official API Bazel rules.
The `bazel/` tree is a symlink back to the official API Bazel rules.
12 changes: 6 additions & 6 deletions test/extensions/filters/http/health_check/health_check_test.cc
Original file line number Diff line number Diff line change
Expand Up @@ -249,9 +249,9 @@ TEST_F(HealthCheckFilterPassThroughTest, Ok) {
EXPECT_CALL(callbacks_, encodeHeaders_(_, _)).Times(0);
EXPECT_EQ(Http::FilterHeadersStatus::Continue, filter_->decodeHeaders(request_headers_, false));

Http::TestResponseHeaderMapImpl service_hc_respnose{{":status", "200"}};
EXPECT_EQ(Http::FilterHeadersStatus::Continue, filter_->encodeHeaders(service_hc_respnose, true));
EXPECT_EQ("cluster_name", service_hc_respnose.getEnvoyUpstreamHealthCheckedClusterValue());
Http::TestResponseHeaderMapImpl service_hc_response{{":status", "200"}};
EXPECT_EQ(Http::FilterHeadersStatus::Continue, filter_->encodeHeaders(service_hc_response, true));
EXPECT_EQ("cluster_name", service_hc_response.getEnvoyUpstreamHealthCheckedClusterValue());
}

TEST_F(HealthCheckFilterPassThroughTest, OkWithContinue) {
Expand All @@ -268,9 +268,9 @@ TEST_F(HealthCheckFilterPassThroughTest, OkWithContinue) {
filter_->encode100ContinueHeaders(continue_response));
Http::MetadataMap metadata_map{{"metadata", "metadata"}};
EXPECT_EQ(Http::FilterMetadataStatus::Continue, filter_->encodeMetadata(metadata_map));
Http::TestResponseHeaderMapImpl service_hc_respnose{{":status", "200"}};
EXPECT_EQ(Http::FilterHeadersStatus::Continue, filter_->encodeHeaders(service_hc_respnose, true));
EXPECT_EQ("cluster_name", service_hc_respnose.getEnvoyUpstreamHealthCheckedClusterValue());
Http::TestResponseHeaderMapImpl service_hc_response{{":status", "200"}};
EXPECT_EQ(Http::FilterHeadersStatus::Continue, filter_->encodeHeaders(service_hc_response, true));
EXPECT_EQ("cluster_name", service_hc_response.getEnvoyUpstreamHealthCheckedClusterValue());
}

TEST_F(HealthCheckFilterPassThroughTest, Failed) {
Expand Down

0 comments on commit 1f75dca

Please sign in to comment.