Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[16.0][MIG] test_base_import_async: Migrate to version 16.0 #1

Open
wants to merge 2 commits into
base: 16.0
Choose a base branch
from

Conversation

sonhd91
Copy link
Owner

@sonhd91 sonhd91 commented Mar 17, 2023

Depended on(add test-requirements later):

@anothingguy
Copy link

anothingguy commented Mar 20, 2023

@sonhd91 : why I didn't see old commit histories of previous versions (< v15) in this PR ?

@sonhd91
Copy link
Owner Author

sonhd91 commented Mar 20, 2023

@sonhd91 : why I didn't see old commit histories of previous versions (< v15) in this PR ?

This module already exists in OCA/queue/16.0 but not migrated version, so we don't need history commit in this PR

@anothingguy
Copy link

lgtm

@dzungtran89
Copy link

sorry for interrupting, but if the migration is from 14.0 to 16.0, the commit OCA@1e2b3af should be preserved

@anothingguy
Copy link

image

anh @dzungtran89 you meant we should preserve the commit history. Regrading the code, I didn't see much change except cleaning empty character

@dzungtran89
Copy link

I know, it's a part of a commit which was probably about doing pre-commit, but preserving commit history has its own meaning where we keep the commit history of a module, as well as respecting the contribution of the commit's author

@sonhd91 sonhd91 force-pushed the 16.0-mig-test_base_import_async branch from eafd46c to f9b297d Compare March 21, 2023 05:13
@sonhd91
Copy link
Owner Author

sonhd91 commented Mar 21, 2023

I know, it's a part of a commit which was probably about doing pre-commit, but preserving commit history has its own meaning where we keep the commit history of a module, as well as respecting the contribution of the commit's author

I just include the commit above, please check again

@dzungtran89
Copy link

thx, lgtm

@sonhd91 sonhd91 force-pushed the 16.0-mig-test_base_import_async branch from f9b297d to 997d574 Compare July 24, 2023 03:05
@sonhd91 sonhd91 force-pushed the 16.0-mig-test_base_import_async branch from 997d574 to f731d47 Compare December 4, 2023 05:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants