Add schema relationships diagram to dash-sonic-hld #94
Conversation
Added reminder notes.
chrispsommers
requested review from
GeraldatMicrosoft,
KrisNey-MSFT,
mmiele and
mzms
| # Canonical Test Data | ||
|
|
||
| ### Figure - Schema Relationships | ||
|
|
There was a problem hiding this comment.
I like this diagram and the relationships it shows. Perhaps, it belongs in @prsunny document SONiC-DASH HLD when the details are ironed out which is the goal of the PR #93.
There was a problem hiding this comment.
Thank you Michael, that would be a good outcome. I needed to put it somewhere for review. I'm perfectly fine with the content being adapted/merged into #93 if it's useful, and I can close this PR. Or, I can delete the .md file from this PR, the image can remain and accepted into /images, then referred to in #93.
There was a problem hiding this comment.
I suggest keeping the 2 PRs open for now.
When we meet next time, and after some feedback hopefully, we can merge them.
There was a problem hiding this comment.
Agree with @mmiele, this content is more on Sonic. You can update the Sonic HLD to have this details captured and update the diagram.
There was a problem hiding this comment.
@prsunny would you please review again, I merged this into your dash-sonic-hld. I still need some clarity on the final JSON config format. Thanks.
chrispsommers
changed the title
…d ToC entry for dash-sonic-hld.
chrispsommers
changed the title
I want to facilitate discussion of #93, in general how they relate to one another but in particular how are the JSON schema derived. My understanding is they could be derived directly from the DASH_APP_DB object schema using sonic-cfggen, thus we don't have to "invent" a schema by hand nor maintain yet another one.