Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HLD update: Adding support for FPGA devices in PDDF #1232

Merged
merged 5 commits into from
Mar 15, 2023

Conversation

FuzailBrcm
Copy link
Contributor

@FuzailBrcm FuzailBrcm commented Jan 23, 2023

HW vendors use FPGA devices in their platform design.

In one of the use cases, the FPGA is connected to CPU via I2C bus. Such FPGAs are similar to any other I2C device with I2C address and adapter where they are connected. We are calling it FPGAI2C.

The other use case is where the FPGA is connected to CPU via PCIe. The FPGA also acts as the I2C controller and other devices are controlled by it. We are calling this design as FPGAPCIe.

This update in the PDDF HLD deals with the support for these two kind of FPGAs.

Repo PR title State
sonic-buildimage Adding support for I2CFPGA in PDDF
sonic-buildimage Adding support for FPGAPCIe in PDDF
sonic-buildimage Enabling FPGA device support in PDDF
sonic-buildimage Modifying the PDDF common platform APIs as per the LED driver changes

@FuzailBrcm
Copy link
Contributor Author

@celestica-gl , @qnos

Please review.

@FuzailBrcm
Copy link
Contributor Author

@jostar-yang please help review

qnos
qnos previously approved these changes Feb 1, 2023
jostar-yang
jostar-yang previously approved these changes Feb 8, 2023
Copy link

@jostar-yang jostar-yang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is fine to me.

Copy link

@jostar-yang jostar-yang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes is fine to me.

Copy link

@qnos qnos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's fine to me.

@zhangyanzhao
Copy link
Collaborator

#13484 need be added into the PR list @FuzailBrcm can you please help to update this HLD? Thanks.

@zhangyanzhao
Copy link
Collaborator

@lguohan can you please check and merge this PR? Thanks.

@yxieca yxieca merged commit c5def30 into sonic-net:master Mar 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants