Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expected output for transceiver DOM CLI #1306

Merged
merged 5 commits into from
Apr 6, 2023

Conversation

mihirpat1
Copy link
Contributor

@mihirpat1 mihirpat1 commented Mar 27, 2023

Add the expected output for show interfaces transceiver dom <port> CLI for all types of transceivers.

Overall, this CLI will display the real time values and threshold data for the DOM sensors on the particular SFP. The CLI is planned to read data from TRANSCEIVER_DOM_SENSOR and TRANSCEIVER_DOM_THRESHOLD STATE_DB tables.

The current output is classified in 3 sections.
Section 1 will be displayed for all transceivers.
Section 2 will be displayed only if the transceiver is CMIS or C_CMIS based
Section 3 will be displayed only if the transceiver is C_CMIS based

@mihirpat1 mihirpat1 marked this pull request as ready for review March 28, 2023 00:14
@mihirpat1
Copy link
Contributor Author

@prgeor @qinchuanares @keboliu @shyam77git - It will be great if you can help in review this.

qinchuanares
qinchuanares previously approved these changes Mar 31, 2023
@keboliu
Copy link
Collaborator

keboliu commented Apr 4, 2023

In PR sonic-net/sonic-utilities#2630 "show interfaces transceiver info {interface}" was added as a warper to "sfpshow eeprom -p {interface}", will this command be a similar case? a wraper to "sfpshow eeprom -p {interface} --dom"?

@mihirpat1
Copy link
Contributor Author

In PR sonic-net/sonic-utilities#2630 "show interfaces transceiver info {interface}" was added as a warper to "sfpshow eeprom -p {interface}", will this command be a similar case? a wraper to "sfpshow eeprom -p {interface} --dom"?

@keboliu We plan to deprecate "sfpshow eeprom" in future and use "show interfaces transceiver info {interface}" or "show interfaces transceiver dom {interface}" for dumping EEPROM info or DOM related information.
Currently, we plan to add "show interface transceiver dom {port}" as a wrapper to "sfpshow dom {interface}"

prgeor
prgeor previously approved these changes Apr 5, 2023
Copy link
Contributor

@prgeor prgeor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mihirpat1 approving with minor comment

@mihirpat1 mihirpat1 dismissed stale reviews from prgeor and qinchuanares via be095ab April 5, 2023 16:37
@shyam77git
Copy link
Contributor

@longhuan-cisco to please review this

@mihirpat1 mihirpat1 merged commit 6051d1a into sonic-net:master Apr 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants