Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

System crashed if IPv6 link-local is enabled and user tried to add member to port-channel #9908

Open
Hedgehog-Guru opened this issue Feb 2, 2022 · 5 comments
Open

System crashed if IPv6 link-local is enabled and user tried to add member to port-channel #9908

Hedgehog-Guru opened this issue Feb 2, 2022 · 5 comments
Labels
BRCM Triaged this issue has been triaged

Comments

@Hedgehog-Guru
Copy link

Description

System crashed when port added to the LAG if IPv6 link-local addresses were enabled before

Steps to reproduce the issue:

  1. Empty config without any IP addresses on interfaces
  2. Enable IPv6 link-local
    config ipv6 enable link-local
  3. Create port-channel interface
    config portchannel add PortChannel0001
  4. Try to add any member to it
    config portchannel member add PortChannel0001 Ethernet0
  5. Check the logs

Describe the results you received:

System crashed with following errors in log

Describe the results you expected:

CLI command rejected or completed without any issues

Output of show version:

SONiC Software Version: SONiC.HEAD.1153-dirty-20211213.215406
Distribution: Debian 11.1
Kernel: 5.10.0-8-2-amd64
Build commit: 82085af78
Build date: Mon Dec 13 23:41:02 UTC 2021
Built by: sw-r2d2-bot@r-build-sonic02-005

Platform: x86_64-mlnx_msn3700-r0
HwSKU: ACS-MSN3700
ASIC: mellanox
ASIC Count: 1
Serial Number: MT1928X02622
Model Number: MSN3700-VS2F
Hardware Revision: A1
Uptime: 17:21:37 up 56 min,  2 users,  load average: 1.06, 0.86, 0.54

Output of show techsupport:

Feb  2 17:16:22.142094 sonic NOTICE swss#portsyncd: :- onMsg: nlmsg type:16 key:PortChannel0001 admin:1 oper:0 addr:b8:59:9f:a8:71:00 ifindex:72 master:0 type:team
Feb  2 17:16:22.142094 sonic NOTICE swss#portsyncd: :- onMsg: nlmsg type:16 key:Ethernet0 admin:0 oper:0 addr:b8:59:9f:a8:71:00 ifindex:40 master:0 type:sx_netdev
Feb  2 17:16:22.142353 sonic NOTICE swss#portsyncd: :- onMsg: Publish Ethernet0(ok:down) to state db
Feb  2 17:16:22.254591 sonic NOTICE swss#portsyncd: :- onMsg: nlmsg type:16 key:Ethernet0 admin:1 oper:0 addr:b8:59:9f:a8:71:00 ifindex:40 master:0 type:sx_netdev
Feb  2 17:16:22.254937 sonic NOTICE swss#portsyncd: :- onMsg: Publish Ethernet0(ok:down) to state db
Feb  2 17:16:22.254937 sonic NOTICE swss#portsyncd: :- onMsg: nlmsg type:16 key:Ethernet0 admin:1 oper:0 addr:b8:59:9f:a8:71:00 ifindex:40 master:72 type:sx_netdev
Feb  2 17:16:22.255102 r-qa-sw-eth-20192 INFO kernel: [ 3055.213928] 8021q: adding VLAN 0 to HW filter on device Ethernet0
Feb  2 17:16:22.255147 r-qa-sw-eth-20192 INFO kernel: [ 3055.214425] PortChannel0001: Port device Ethernet0 added
Feb  2 17:16:22.255411 sonic NOTICE swss#portsyncd: :- onMsg: nlmsg type:16 key:Ethernet0 admin:1 oper:0 addr:b8:59:9f:a8:71:00 ifindex:40 master:72 type:sx_netdev
Feb  2 17:16:22.255411 sonic NOTICE swss#portsyncd: :- onMsg: nlmsg type:16 key:PortChannel0001 admin:1 oper:0 addr:b8:59:9f:a8:71:00 ifindex:72 master:0 type:team
Feb  2 17:16:22.257683 sonic NOTICE swss#orchagent: message repeated 2 times: [ :- updatePortOperStatus: Port PortChannel0001 oper state set from down to down]
Feb  2 17:16:22.257683 sonic ERR swss#orchagent: :- setPortPvid: pvid setting for router interface Ethernet0 is not allowed
Feb  2 17:16:22.259261 r-qa-sw-eth-20192 NOTICE syncd#SDK: [SAI_LAG.NOTICE] mlnx_sai_lag.c[1331]- mlnx_create_lag_member: Create lag member, #0 LAG_ID=LAG,(0:0),80,0000,0 #1 PORT_ID=PORT,(0:0),10061,0000,0 
Feb  2 17:16:22.259261 r-qa-sw-eth-20192 ERR syncd#SDK: [SAI_LAG.ERR] mlnx_sai_lag.c[596]- validate_port: Can't add port with created RIFs count=1
Feb  2 17:16:22.259309 r-qa-sw-eth-20192 ERR syncd#SDK: :- sendApiResponse: api SAI_COMMON_API_CREATE failed in syncd mode: SAI_STATUS_INVALID_PARAMETER
Feb  2 17:16:22.259745 r-qa-sw-eth-20192 ERR syncd#SDK: :- processQuadEvent: attr: SAI_LAG_MEMBER_ATTR_LAG_ID: oid:0x20000000005c3
Feb  2 17:16:22.259745 r-qa-sw-eth-20192 ERR syncd#SDK: :- processQuadEvent: attr: SAI_LAG_MEMBER_ATTR_PORT_ID: oid:0x1000000000462
Feb  2 17:16:22.259813 sonic ERR swss#orchagent: :- create: create status: SAI_STATUS_INVALID_PARAMETER
Feb  2 17:16:22.259861 sonic ERR swss#orchagent: :- addLagMember: Failed to add member Ethernet0 to LAG PortChannel0001 lid:20000000005c3 pid:1000000000462
Feb  2 17:16:22.259883 sonic ERR swss#orchagent: :- handleSaiCreateStatus: Encountered failure in create operation, exiting orchagent, SAI API: SAI_API_LAG, status: SAI_STATUS_INVALID_PARAMETER
Feb  2 17:16:22.261373 sonic NOTICE swss#orchagent: :- uninitialize: begin

Additional information you deem important (e.g. issue happens only occasionally):

sonic_dump_r-qa-sw-eth-20192_20220202_171716.tar.gz
@dgsudharsan
Copy link
Collaborator

@adyeung Can you please assign?

@zhangyanzhao zhangyanzhao added the Triaged this issue has been triaged label Feb 2, 2022
@zhangyanzhao
Copy link
Collaborator

BRCM will take a look. Thanks.

@adyeung
Copy link
Collaborator

adyeung commented Feb 4, 2022

@AkhileshSamineni pls take a look and update the thread

@AkhileshSamineni AkhileshSamineni mentioned this issue Feb 18, 2022
Merged
@AkhileshSamineni
Copy link
Contributor

@zhangyanzhao @dgsudharsan
The CLI command should reject when user trying to add a member to a portchannel when link-local is enabled for the member port.
Fixed this issue.

@adyeung
Copy link
Collaborator

adyeung commented Feb 23, 2022

@dgsudharsan pls review the fix

liat-grozovik pushed a commit to sonic-net/sonic-utilities that referenced this issue Mar 15, 2022
@AkhileshSamineni
Validation check correction while adding a member to PortChannel (#2078)
398da58 
Corrected the validation check while adding a member to a PortChannel

This PR will fix the issue - sonic-net/sonic-buildimage#9908

The CLI command should reject when trying to add member to a Portchannel when link-local is enabled in it.
``
root@sonic:/home/admin# config ipv6 enable link-local
root@sonic:/home/admin#
root@sonic:/home/admin# config portchannel add PortChannel0001
root@sonic:/home/admin#
root@sonic:/home/admin# config portchannel member add PortChannel0001 Ethernet64
Usage: config portchannel member add [OPTIONS] <portchannel_name> <port_name>
Try "config portchannel member add -h" for help.

Error:  Ethernet64 has ip address configured
root@sonic:/home/admin#
``
Signed-off-by: Akhilesh Samineni [email protected]
judyjoseph pushed a commit to sonic-net/sonic-utilities that referenced this issue Mar 20, 2022
@AkhileshSamineni @judyjoseph
Validation check correction while adding a member to PortChannel (#2078)
51d92ae 
Corrected the validation check while adding a member to a PortChannel

This PR will fix the issue - sonic-net/sonic-buildimage#9908

The CLI command should reject when trying to add member to a Portchannel when link-local is enabled in it.
``
root@sonic:/home/admin# config ipv6 enable link-local
root@sonic:/home/admin#
root@sonic:/home/admin# config portchannel add PortChannel0001
root@sonic:/home/admin#
root@sonic:/home/admin# config portchannel member add PortChannel0001 Ethernet64
Usage: config portchannel member add [OPTIONS] <portchannel_name> <port_name>
Try "config portchannel member add -h" for help.

Error:  Ethernet64 has ip address configured
root@sonic:/home/admin#
``
Signed-off-by: Akhilesh Samineni [email protected]
malletvapid23 added a commit to malletvapid23/Sonic-Utility that referenced this issue Aug 3, 2023
@malletvapid23
Validation check correction while adding a member to PortChannel (#2078)
4e21a59 
Corrected the validation check while adding a member to a PortChannel

This PR will fix the issue - sonic-net/sonic-buildimage#9908

The CLI command should reject when trying to add member to a Portchannel when link-local is enabled in it.
``
root@sonic:/home/admin# config ipv6 enable link-local
root@sonic:/home/admin#
root@sonic:/home/admin# config portchannel add PortChannel0001
root@sonic:/home/admin#
root@sonic:/home/admin# config portchannel member add PortChannel0001 Ethernet64
Usage: config portchannel member add [OPTIONS] <portchannel_name> <port_name>
Try "config portchannel member add -h" for help.

Error:  Ethernet64 has ip address configured
root@sonic:/home/admin#
``
Signed-off-by: Akhilesh Samineni [email protected]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
BRCM Triaged this issue has been triaged
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@zhangyanzhao @dgsudharsan @adyeung @AkhileshSamineni @Hedgehog-Guru