Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[sonic-cfggen]: Add port speed for UT #10483

Merged
merged 2 commits into from
Apr 7, 2022
Merged

Conversation

ganglyu
Copy link
Contributor

@ganglyu ganglyu commented Apr 6, 2022

Signed-off-by: Gang Lv [email protected]

Why I did it

Need to run yang validation for sonic-cfggen unit test, and many unit test does not provide speed for port table.

How I did it

Update minigraph xml.

How to verify it

Run sonic-cfggen unit test.

Which release branch to backport (provide reason below if selected)

  • 201811
  • 201911
  • 202006
  • 202012
  • 202106
  • 202111

Description for the changelog

Fix #9579

Link to config_db schema for YANG module changes

A picture of a cute animal (not mandatory but encouraged)

@ganglyu ganglyu added the sonic-cfggen SONiC Configuration Generator Tool label Apr 6, 2022
@ganglyu ganglyu requested a review from lguohan as a code owner April 6, 2022 13:52
@qiluo-msft
Copy link
Collaborator

qiluo-msft commented Apr 6, 2022

    <EndPort>Ethernet1</EndPort>

Do you need to change this line Ethernet1->Ethernet4 at the same time?


In reply to: 1090726175


Refers to: src/sonic-config-engine/tests/sample_graph.xml:115 in c264774. [](commit_id = c264774, deletion_comment = False)

@qiluo-msft
Copy link
Collaborator

@abdosi, @arlakshm and @SuvarnaMeenakshi
Could you help review changes under src/sonic-config-engine/tests/multi_npu_data directory?

arlakshm
arlakshm previously approved these changes Apr 6, 2022
Copy link
Contributor

@arlakshm arlakshm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the changes to files src/sonic-config-engine/tests/multi_npu_data look good to me.

@ganglyu ganglyu merged commit 3046c79 into sonic-net:master Apr 7, 2022
@ganglyu ganglyu added the Request for 202111 Branch For PRs being requested for 202111 branch label Apr 14, 2022
judyjoseph pushed a commit that referenced this pull request Apr 18, 2022
Why I did it
Need to run yang validation for sonic-cfggen unit test, and many unit test does not provide speed for port table.

How I did it
Update minigraph xml.

How to verify it
Run sonic-cfggen unit test.

Signed-off-by: Gang Lv [email protected]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Included in 202111 Branch Request for 202111 Branch For PRs being requested for 202111 branch sonic-cfggen SONiC Configuration Generator Tool
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[yang-models] port validation issue, speed is mandatory
4 participants