Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[submodule] Update sairedis #10607

Merged
merged 1 commit into from
Apr 21, 2022
Merged

Conversation

alexrallen
Copy link
Contributor

@alexrallen alexrallen commented Apr 19, 2022

Update sairedis to include the following commit which allows SAI to build against any python3 version with saithriftv2.

c7cbfe8 Update SAI submodule to support python 3.7 (#1035)

@dgsudharsan
Copy link
Collaborator

@kcudnik @lguohan Can you please review?

@prsunny
Copy link
Contributor

prsunny commented Apr 21, 2022

@alexrallen , can you please follow the submodule update template to include the commit ids in descriptions?

@alexrallen
Copy link
Contributor Author

@prsunny Updated. I'm not sure this offers much additional utility in the way of referencing the commit though, in my opinion having a backlink to the PR is more useful than a commit id.

@prsunny prsunny merged commit 37e2848 into sonic-net:master Apr 21, 2022
@prsunny
Copy link
Contributor

prsunny commented Apr 21, 2022

@prsunny Updated. I'm not sure this offers much additional utility in the way of referencing the commit though, in my opinion having a backlink to the PR is more useful than a commit id.

The intention is to have this in the commit description while merging. The link won't help in 'git log' etc:
Refer - 37e2848

liushilongbuaa pushed a commit to liushilongbuaa/sonic-buildimage that referenced this pull request Jun 20, 2022
Related work items: #49, #58, #107, sonic-net#247, sonic-net#249, sonic-net#277, sonic-net#593, sonic-net#597, sonic-net#1035, sonic-net#2130, sonic-net#2150, sonic-net#2165, sonic-net#2169, sonic-net#2178, sonic-net#2179, sonic-net#2187, sonic-net#2188, sonic-net#2191, sonic-net#2195, sonic-net#2197, sonic-net#2198, sonic-net#2200, sonic-net#2202, sonic-net#2206, sonic-net#2209, sonic-net#2211, sonic-net#2216, sonic-net#7909, sonic-net#8927, sonic-net#9681, sonic-net#9733, sonic-net#9746, sonic-net#9850, sonic-net#9967, sonic-net#10104, sonic-net#10152, sonic-net#10168, sonic-net#10228, sonic-net#10266, sonic-net#10288, sonic-net#10294, sonic-net#10313, sonic-net#10394, sonic-net#10403, sonic-net#10404, sonic-net#10421, sonic-net#10431, sonic-net#10437, sonic-net#10445, sonic-net#10457, sonic-net#10458, sonic-net#10465, sonic-net#10467, sonic-net#10469, sonic-net#10470, sonic-net#10474, sonic-net#10477, sonic-net#10478, sonic-net#10482, sonic-net#10485, sonic-net#10488, sonic-net#10489, sonic-net#10492, sonic-net#10494, sonic-net#10498, sonic-net#10501, sonic-net#10509, sonic-net#10512, sonic-net#10514, sonic-net#10516, sonic-net#10517, sonic-net#10523, sonic-net#10525, sonic-net#10531, sonic-net#10532, sonic-net#10538, sonic-net#10555, sonic-net#10557, sonic-net#10559, sonic-net#10561, sonic-net#10565, sonic-net#10572, sonic-net#10574, sonic-net#10576, sonic-net#10578, sonic-net#10581, sonic-net#10585, sonic-net#10587, sonic-net#10599, sonic-net#10607, sonic-net#10611, sonic-net#10616, sonic-net#10618, sonic-net#10619, sonic-net#10623, sonic-net#10624, sonic-net#10633, sonic-net#10646, sonic-net#10655, sonic-net#10660, sonic-net#10664, sonic-net#10680, sonic-net#10683
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants