load_db_config before connecting to ConfigDBConnector in portconfig.py

[nathcohe]

Why I did it

Running commands like sfputil show presence would cause the following error:

validateNamespace: Initialize global DB config using API SonicDBConfig::initializeGlobalConfig 

A similar issue was already fixed for show commands upstream:

sonic-net/sonic-utilities#1752

How I did it

Imported and used the load_db_config() function from utilities_common.general.

How to verify it

Running:

sfputil show presence

Which release branch to backport (provide reason below if selected)

• 201811
• 201911
• 202006
• 202012
• 202106
• 202111
• 202205

Description for the changelog

Adds call to load_db_config() before connecting to the ConfigDBConnector in portconfig.py

Link to config_db schema for YANG module changes

A picture of a cute animal (not mandatory but encouraged)

🐿

[SuvarnaMeenakshi]

@nathcohe load_db_config() was removed from portconfig.py because it portconfi is a library and load_db_config() should be done by application. So it was moved to sonic-cfggen which is using portconfig.py functions.
The issue that you are seeing is reported in this issue: #11269
The latest sonic master branch image should no longer see this issue.
Can you please confirm with latest master branch and close this PR.

[nathcohe]

@SuvarnaMeenakshi, even with the change
sonic-net/sonic-utilities#2238

we still hit the following:

root@sfd-t2-lc0:/home/cisco# sfputil show presence
Error reading port info (:- validateNamespace: Initialize global DB config using API SonicDBConfig::initializeGlobalConfig)

Are there any other changes that went in recently that might have fixed the above CLI?

[SuvarnaMeenakshi]

@SuvarnaMeenakshi, even with the change Azure/sonic-utilities#2238

we still hit the following:

root@sfd-t2-lc0:/home/cisco# sfputil show presence
Error reading port info (:- validateNamespace: Initialize global DB config using API SonicDBConfig::initializeGlobalConfig)

Are there any other changes that went in recently that might have fixed the above CLI?

Not that I know of, can you check if "pfcwd start_default" works ?
The issue that we initially saw was load_minigraph failing because of "pfcwd start_default" failure.

[SuvarnaMeenakshi]

@SuvarnaMeenakshi, even with the change Azure/sonic-utilities#2238
we still hit the following:

root@sfd-t2-lc0:/home/cisco# sfputil show presence
Error reading port info (:- validateNamespace: Initialize global DB config using API SonicDBConfig::initializeGlobalConfig)

Are there any other changes that went in recently that might have fixed the above CLI?

Not that I know of, can you check if "pfcwd start_default" works ? The issue that we initially saw was load_minigraph failing because of "pfcwd start_default" failure.

@SuvarnaMeenakshi, even with the change Azure/sonic-utilities#2238
we still hit the following:

root@sfd-t2-lc0:/home/cisco# sfputil show presence
Error reading port info (:- validateNamespace: Initialize global DB config using API SonicDBConfig::initializeGlobalConfig)

Are there any other changes that went in recently that might have fixed the above CLI?

Not that I know of, can you check if "pfcwd start_default" works ? The issue that we initially saw was load_minigraph failing because of "pfcwd start_default" failure.

Discussed with @arlakshm Similar sonic-net/sonic-utilities#2238 should be made in the sfputil cli implementation in sonic-utilities.

[nathcohe]

Could we try re-running the GitHub checks or have them looked at? I am unable to view the build issue.

[SuvarnaMeenakshi]

ng the GitHub checks or have them looked at? I am unable to view the build issue.
Seems like the sonic-config-engine unit tests are failing. re-running might not resolve the issue seen here.
I have copied one of the failures.
This is not the right fix in portconfig.py, the fix should be made in sonic-utilities

======================================================================
ERROR: test_var_json_data (tests.test_cfggen.TestCfgGen)
----------------------------------------------------------------------
Traceback (most recent call last):
 File "/sonic/src/sonic-config-engine/tests/test_cfggen.py", line 152, in test_var_json_data
   output = self.run_script(argument)
 File "/sonic/src/sonic-config-engine/tests/test_cfggen.py", line 60, in run_script
   output = subprocess.check_output(self.script_file + ' ' + argument, shell=True)
 File "/usr/lib/python2.7/subprocess.py", line 223, in check_output
   raise CalledProcessError(retcode, cmd, output=output)
CalledProcessError: Command 'python2 /sonic/src/sonic-config-engine/tests/../sonic-cfggen -m "/sonic/src/sonic-config-engine/tests/simple-sample-graph.xml" -p "/sonic/src/sonic-config-engine/tests/t0-sample-port-config.ini" --var-json VLAN_MEMBER' returned non-zero exit status 1