Subnet route added for management interface (eth0) - "fixes #1023" #1142
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
cfg engine unit test is broken, can you check? |
|
Build triggered. sha1 is merged. |
2 similar comments
|
Build triggered. sha1 is merged. |
|
Build triggered. sha1 is merged. |
|
Build started sha1 is merged. |
2 similar comments
|
Build started sha1 is merged. |
|
Build started sha1 is merged. |
|
Build finished. No test results found. |
1 similar comment
|
Build finished. No test results found. |
|
No test results found. |
|
cfggen test still fails? |
|
Build triggered. sha1 is merged. |
2 similar comments
|
Build triggered. sha1 is merged. |
|
Build triggered. sha1 is merged. |
|
Build started sha1 is merged. |
2 similar comments
|
Build started sha1 is merged. |
|
Build started sha1 is merged. |
|
Build finished. No test results found. |
1 similar comment
|
Build finished. No test results found. |
|
No test results found. |
|
Build triggered. sha1 is merged. |
2 similar comments
|
Build triggered. sha1 is merged. |
|
Build triggered. sha1 is merged. |
|
Build started sha1 is merged. |
2 similar comments
|
Build started sha1 is merged. |
|
Build started sha1 is merged. |
|
No test results found. |
|
Build finished. No test results found. |
|
@lguohan, fixed the cfggen test issue. Can you please review? |
|
Build finished. No test results found. |
lguohan
approved these changes
Nov 14, 2017
stepanblyschak
pushed a commit
to stepanblyschak/sonic-buildimage
that referenced
this pull request
Dec 20, 2019
9f6efa0 [port/buffer] introduce a sync mechanism to protect port PG/queue from changes under PFC storm (sonic-net#1143) 823e426 [aclorch] Enable DSCP rules on IPv6 mirror tables (sonic-net#1146) b8745f8 [bitmap_vnet]: Fix removal flow for tunnel route (sonic-net#1139) 03be983 Increase ip2me CIR/CBR for faster in-band file transfers (sonic-net#1000) a4a1d3b [vnet]: Update VNET route table size to 40K for BITMAP implementation (sonic-net#1132) efe142a Fix bug: Wrong condition for mac address (sonic-net#1142) 7bf63a0 [teammgrd]during warm-reboot teamd need to recover system-id from saved lacp-pdu (sonic-net#1003) 8b4cfb6 Cleanup configure.ac from BFN specific code (sonic-net#1133) b931751 [teamsyncd]: Add retry logic in teamsyncd to avoid team handler init failure (sonic-net#854) Signed-off-by: Stepan Blyschak <[email protected]>
lguohan
pushed a commit
that referenced
this pull request
Dec 27, 2019
9f6efa0 [port/buffer] introduce a sync mechanism to protect port PG/queue from changes under PFC storm (#1143) 823e426 [aclorch] Enable DSCP rules on IPv6 mirror tables (#1146) b8745f8 [bitmap_vnet]: Fix removal flow for tunnel route (#1139) 03be983 Increase ip2me CIR/CBR for faster in-band file transfers (#1000) a4a1d3b [vnet]: Update VNET route table size to 40K for BITMAP implementation (#1132) efe142a Fix bug: Wrong condition for mac address (#1142) 7bf63a0 [teammgrd]during warm-reboot teamd need to recover system-id from saved lacp-pdu (#1003) 8b4cfb6 Cleanup configure.ac from BFN specific code (#1133) b931751 [teamsyncd]: Add retry logic in teamsyncd to avoid team handler init failure (#854) Signed-off-by: Stepan Blyschak <[email protected]>
madhanmellanox
pushed a commit
to madhanmellanox/sonic-buildimage
that referenced
this pull request
Mar 23, 2020
Signed-off-by: Ze Gan <[email protected]>
lguohan
pushed a commit
that referenced
this pull request
Oct 6, 2020
- [acl-loader] Revert fix for IP protocol == 0 (#1142) - Show sflow interface to display all interfaces enabled for sflow (#1143) - [sflow_test.py]: tests for config sflow commands. (#1112) - [config/console] Support add/del console port setting commands (#1136) - [cli][bgp]use vtysh in the show ip bgp summary command (#1137) - [README.md] Describe new package creation schema (#1131) - [consutil] Remove actual baud and refactor lib for future change (#1130) Signed-off-by: Danny Allen <[email protected]>
raphaelt-nvidia
pushed a commit
to raphaelt-nvidia/sonic-buildimage
that referenced
this pull request
Jan 14, 2021
Signed-off-by: Ze Gan <[email protected]>
santhosh-kt
pushed a commit
to santhosh-kt/sonic-buildimage
that referenced
this pull request
Feb 25, 2021
…t#5545) - [acl-loader] Revert fix for IP protocol == 0 (sonic-net#1142) - Show sflow interface to display all interfaces enabled for sflow (sonic-net#1143) - [sflow_test.py]: tests for config sflow commands. (sonic-net#1112) - [config/console] Support add/del console port setting commands (sonic-net#1136) - [cli][bgp]use vtysh in the show ip bgp summary command (sonic-net#1137) - [README.md] Describe new package creation schema (sonic-net#1131) - [consutil] Remove actual baud and refactor lib for future change (sonic-net#1130) Signed-off-by: Danny Allen <[email protected]>
stepanblyschak
pushed a commit
to stepanblyschak/sonic-buildimage
that referenced
this pull request
May 10, 2021
Signed-off-by: Danny Allen <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
- What I did
Added a subnet route in "default" kernel route table based on the IP address/prefix of management interface (eth0)
- How I did it
Modified the interface.j2 template to add/delete subnet route for eth0
- How to verify it
Execute the following command:
Note: Instead of "ifdown/ifup", if interface is shut using
"ifconfig eth0 down"or "ip link set dev eth0 down" and then "ifconfig eth0 up", then these entries will be deleted from the default route table and you've to restart network service to reconfigure the route entries.- Description for the changelog
Added subnet route to default route table in kernel for management interface
- A picture of a cute animal (not mandatory but encouraged)