Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[build] Fix isc-dhcp full version in rules.mk #13288

Merged
merged 1 commit into from
Jan 8, 2023

Conversation

guillaumelambert
Copy link
Contributor

@guillaumelambert guillaumelambert commented Jan 6, 2023

During the build process, a dsc file is retrieved from the URL: http://deb.debian.org/debian/pool/main/i/isc-dhcp/isc-dhcp_4.4.1-2.3.dsc

Depending on the DNS resolution, the server reached may respond with a HTTP 404 error code, what stops the build process. In all cases, the URL http://deb.debian.org/debian/pool/main/i/isc-dhcp/ no more lists this DSC file but one with a different format.

The suffix "+deb11u1" is now appended to identify the debian version.

  • append this suffix to the make file rules of isc-dhcp

Issue #13281

Which release branch to backport (provide reason below if selected)

all using this version of isc-dhcp

Description for the changelog

[build] Fix isc-dhcp full version in rules.mk

A picture of a cute animal (not mandatory but encouraged)

                  .".
                     /  |
                    /  /
                   / ,"
       .-------.--- /
      "._ __.-/ o. o\  
         "   (    Y  )
              )     /
             /     (
            /       Y
        .-"         |
       /  _     \    \ 
      /    `. ". ) /' )
     Y       )( / /(,/
    ,|      /     )
   ( |     /     /
    " \_  (__   (__        [nabis]
        "-._,)--._,)

During the build process, a dsc file is retrieved from the URL:
http://deb.debian.org/debian/pool/main/i/isc-dhcp/isc-dhcp_4.4.1-2.3.dsc

Depending on the DNS resolution, the server reached may respond with a
HTTP 404 error code, what stops the build process.
In all cases, the URL http://deb.debian.org/debian/pool/main/i/isc-dhcp/
no more lists this DSC file but one with a different format.

The suffix "+deb11u1" is now appended to identify the debian version.

- append this suffix to the make file rules of isc-dhcp

Signed-off-by: Guillaume Lambert <[email protected]>
@guillaumelambert
Copy link
Contributor Author

@collivier @odd22 FYI

@saiarcot895
Copy link
Contributor

Technically, this is a package update, not just a version numbering fix. It's odd, though, that the dsc file for 4.4.1-2.3 appears to be still partially available, but listing the directory contents doesn't show it.

@saiarcot895
Copy link
Contributor

I see #13276 is also fixing the same thing.

@guillaumelambert
Copy link
Contributor Author

guillaumelambert commented Jan 6, 2023

Technically, this is a package update, not just a version numbering fix. It's odd, though, that the dsc file for 4.4.1-2.3 appears to be still partially available, but listing the directory contents doesn't show it.

Yep I was referring to the variable name in the commit title indeed.
Maybe it would be worth to update this variable name too.
About the weird listing, this is a classical caching issue probably related to debian packages staging process..
I had access to the old dsc file from a different Internet access location where it was not yet removed.
Here are diff and grep results.
As you can see sources checksum are identical but not the debian packages ones.
I suspect this is only a renaming issue indeed.

hope this helps

diff isc-dhcp*.dsc
8c8
< Version: 4.4.1-2.3+deb11u1

Version: 4.4.1-2.3
27c27
< dcf53786e6b1650184fde075bbe25a0f3dd7e49c 89040 isc-dhcp_4.4.1-2.3+deb11u1.debian.tar.xz


aad326e51276efeb3d6d64b23f274eaaa329a737 88136 isc-dhcp_4.4.1-2.3.debian.tar.xz
30c30
< b693380b77195e6e742848be2a86248506b0c9bbbb461622daa1ad5b36d9ac54 89040 isc-dhcp_4.4.1-2.3+deb11u1.debian.tar.xz


8396ddc072a5f1d1863f95ba8f95cb4d6f0de3928615038eeaa8897d966dcd35 88136 isc-dhcp_4.4.1-2.3.debian.tar.xz
33c33
< 8c3640097a1b4cc59e927badbd45b3f0 89040 isc-dhcp_4.4.1-2.3+deb11u1.debian.tar.xz


72af4f677ebb88970bdcae0f73f2d9e8 88136 isc-dhcp_4.4.1-2.3.debian.tar.xz
37c37
< iQKmBAEBCgCQFiEERkRAmAjBceBVMd3uBUy48xNDz0QFAmM8nvlfFIAAAAAALgAo


iQKmBAEBCgCQFiEERkRAmAjBceBVMd3uBUy48xNDz0QFAmCvLJJfFIAAAAAALgAo
[...]>
grep -A3 Checksum isc-dhcp*.dsc
isc-dhcp_4.4.1-2.3+deb11u1.dsc:Checksums-Sha1:
isc-dhcp_4.4.1-2.3+deb11u1.dsc- 2c52eac4eb3dc9a2ecde623b1a687fa0146a6ce9 1189920 isc-dhcp_4.4.1.orig.tar.gz
isc-dhcp_4.4.1-2.3+deb11u1.dsc- dcf53786e6b1650184fde075bbe25a0f3dd7e49c 89040 isc-dhcp_4.4.1-2.3+deb11u1.debian.tar.xz
isc-dhcp_4.4.1-2.3+deb11u1.dsc:Checksums-Sha256:
isc-dhcp_4.4.1-2.3+deb11u1.dsc- c8e079dd4303ed121811b05c9f62a37669b2c8d91658d47a5ec58ec34e5a8247 1189920 isc-dhcp_4.4.1.orig.tar.gz
isc-dhcp_4.4.1-2.3+deb11u1.dsc- b693380b77195e6e742848be2a86248506b0c9bbbb461622daa1ad5b36d9ac54 89040 isc-dhcp_4.4.1-2.3+deb11u1.debian.tar.xz
isc-dhcp_4.4.1-2.3+deb11u1.dsc-Files:
--
isc-dhcp_4.4.1-2.3.dsc:Checksums-Sha1:
isc-dhcp_4.4.1-2.3.dsc- 2c52eac4eb3dc9a2ecde623b1a687fa0146a6ce9 1189920 isc-dhcp_4.4.1.orig.tar.gz
isc-dhcp_4.4.1-2.3.dsc- aad326e51276efeb3d6d64b23f274eaaa329a737 88136 isc-dhcp_4.4.1-2.3.debian.tar.xz
isc-dhcp_4.4.1-2.3.dsc:Checksums-Sha256:
isc-dhcp_4.4.1-2.3.dsc- c8e079dd4303ed121811b05c9f62a37669b2c8d91658d47a5ec58ec34e5a8247 1189920 isc-dhcp_4.4.1.orig.tar.gz
isc-dhcp_4.4.1-2.3.dsc- 8396ddc072a5f1d1863f95ba8f95cb4d6f0de3928615038eeaa8897d966dcd35 88136 isc-dhcp_4.4.1-2.3.debian.tar.xz
isc-dhcp_4.4.1-2.3.dsc-Files:
`

@saiarcot895
Copy link
Contributor

That's standard practice for the source package (orig.tar.*) being the same, but the debian package (debian.tar.*) being different, since the upstream version is the same, but Debian is making specific changes. See here for details on the new version.

@guillaumelambert
Copy link
Contributor Author

So this is CVE security updates by Debian security team.
Thanks for the pointer.

@lguohan lguohan linked an issue Jan 8, 2023 that may be closed by this pull request
@lguohan lguohan merged commit 19010a3 into sonic-net:master Jan 8, 2023
mssonicbld pushed a commit to mssonicbld/sonic-buildimage that referenced this pull request Jan 11, 2023
During the build process, a dsc file is retrieved from the URL:
http://deb.debian.org/debian/pool/main/i/isc-dhcp/isc-dhcp_4.4.1-2.3.dsc

Depending on the DNS resolution, the server reached may respond with a
HTTP 404 error code, what stops the build process.
In all cases, the URL http://deb.debian.org/debian/pool/main/i/isc-dhcp/
no more lists this DSC file but one with a different format.

The suffix "+deb11u1" is now appended to identify the debian version.

- append this suffix to the make file rules of isc-dhcp

Signed-off-by: Guillaume Lambert <[email protected]>
@mssonicbld
Copy link
Collaborator

Cherry-pick PR to 202205: #13339

mssonicbld pushed a commit to mssonicbld/sonic-buildimage that referenced this pull request Jan 13, 2023
During the build process, a dsc file is retrieved from the URL:
http://deb.debian.org/debian/pool/main/i/isc-dhcp/isc-dhcp_4.4.1-2.3.dsc

Depending on the DNS resolution, the server reached may respond with a
HTTP 404 error code, what stops the build process.
In all cases, the URL http://deb.debian.org/debian/pool/main/i/isc-dhcp/
no more lists this DSC file but one with a different format.

The suffix "+deb11u1" is now appended to identify the debian version.

- append this suffix to the make file rules of isc-dhcp

Signed-off-by: Guillaume Lambert <[email protected]>
@mssonicbld
Copy link
Collaborator

Cherry-pick PR to 202211: #13357

liorghub pushed a commit to liorghub/sonic-buildimage that referenced this pull request Jan 22, 2023
During the build process, a dsc file is retrieved from the URL:
http://deb.debian.org/debian/pool/main/i/isc-dhcp/isc-dhcp_4.4.1-2.3.dsc

Depending on the DNS resolution, the server reached may respond with a
HTTP 404 error code, what stops the build process.
In all cases, the URL http://deb.debian.org/debian/pool/main/i/isc-dhcp/
no more lists this DSC file but one with a different format.

The suffix "+deb11u1" is now appended to identify the debian version.

- append this suffix to the make file rules of isc-dhcp

Signed-off-by: Guillaume Lambert <[email protected]>
yxieca pushed a commit to yxieca/sonic-buildimage that referenced this pull request Mar 21, 2023
During the build process, a dsc file is retrieved from the URL:
http://deb.debian.org/debian/pool/main/i/isc-dhcp/isc-dhcp_4.4.1-2.3.dsc

Depending on the DNS resolution, the server reached may respond with a
HTTP 404 error code, what stops the build process.
In all cases, the URL http://deb.debian.org/debian/pool/main/i/isc-dhcp/
no more lists this DSC file but one with a different format.

The suffix "+deb11u1" is now appended to identify the debian version.

- append this suffix to the make file rules of isc-dhcp

Signed-off-by: Guillaume Lambert <[email protected]>
yxieca added a commit that referenced this pull request Mar 22, 2023
During the build process, a dsc file is retrieved from the URL:
http://deb.debian.org/debian/pool/main/i/isc-dhcp/isc-dhcp_4.4.1-2.3.dsc

Depending on the DNS resolution, the server reached may respond with a
HTTP 404 error code, what stops the build process.
In all cases, the URL http://deb.debian.org/debian/pool/main/i/isc-dhcp/
no more lists this DSC file but one with a different format.

The suffix "+deb11u1" is now appended to identify the debian version.

- append this suffix to the make file rules of isc-dhcp

Signed-off-by: Guillaume Lambert <[email protected]>
Co-authored-by: Guilt <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Build] Failed to build isc dhcp
6 participants