Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switchport Modes Port & Port Channel Yang Model Configurations #13580

Merged
merged 250 commits into from
Jan 26, 2024
Merged
Show file tree
Hide file tree
Changes from 5 commits
Commits
Show all changes
250 commits
Select commit Hold shift + click to select a range
eb5e0d1
Modified SONiC VS image path
ridahanif96 Dec 21, 2022
a88fed6
Port & Port Channel configurations for yang model
ridahanif96 Feb 1, 2023
0cb73cb
Merge branch 'sonic-net:master' into Switchport_Vlan
ridahanif96 Feb 1, 2023
81b0917
Some Fix in Port.yang
ridahanif96 Feb 2, 2023
ffa3aa3
Modified Code as per suggestions
ridahanif96 Feb 3, 2023
ca12402
small fixes
ridahanif96 Feb 3, 2023
a943665
fixes
ridahanif96 Feb 3, 2023
d242392
code fixes for PORT
ridahanif96 Feb 6, 2023
2ab6864
fixes in code
ridahanif96 Feb 7, 2023
aad224c
Merge branch 'master' into Switchport_Vlan
ridahanif96 Mar 6, 2023
b1234a9
Fixes
ridahanif96 Mar 6, 2023
ccfc565
Merge branch 'Switchport_Vlan' of https://github.com/ridahanif96/soni…
ridahanif96 Mar 10, 2023
63c977a
Fixes for build failure
ridahanif96 Mar 10, 2023
aff122f
Updated Command Reference
ridahanif96 Mar 10, 2023
3b9f975
Updates for build fixes
ridahanif96 Mar 10, 2023
90eda6b
Updated Configuration.md to resolove merge conflicts
ridahanif96 Dec 21, 2022
7c6511c
Fixing Merge Conflicts
ridahanif96 Mar 11, 2023
26cabaa
Fixing Merge Conflicts
ridahanif96 Mar 11, 2023
97e23ac
fixing merge conflicts
ridahanif96 Mar 13, 2023
69f3fdf
Merge branch 'Switchport_Vlan' of https://github.com/ridahanif96/soni…
ridahanif96 Mar 13, 2023
9b29e26
Merge branch 'master' into Switchport_Vlan
ridahanif96 Mar 13, 2023
dc0836f
Update port.json
ridahanif96 Mar 13, 2023
e7246e0
Update port.json
ridahanif96 Mar 13, 2023
3e03e59
Update portchannel.json
ridahanif96 Mar 13, 2023
476a2fe
Fixing Build Failure Errors
ridahanif96 Mar 13, 2023
b360f2a
Fixing
ridahanif96 Mar 13, 2023
a39ea2b
Python version Updates for Failed Error Fixes
ridahanif96 Mar 13, 2023
15644f9
Fixing VlanTest.py Error
ridahanif96 Mar 13, 2023
fcbf1db
Update port.json
ridahanif96 Mar 14, 2023
4e40046
Update port.json
ridahanif96 Mar 14, 2023
f5875c5
Update portchannel.json
ridahanif96 Mar 14, 2023
785a419
Merge branch 'master' into Switchport_Vlan
ridahanif96 Mar 17, 2023
21bb63e
Merge conflicts resolve
ridahanif96 Mar 18, 2023
6f366c6
Must condition for Vlan member assignment on access or trunk
ridahanif96 Apr 6, 2023
a8df3b9
Merge branch 'Switchport_Vlan' of https://github.com/ridahanif96/soni…
ridahanif96 Apr 6, 2023
894ff9f
Must condition on port for Vlan Member assignment
ridahanif96 Apr 6, 2023
92f8815
Must Validation for Vlan Member assignment on access and trun port
ridahanif96 Apr 6, 2023
d463596
Fixing Merge Conflicts
ridahanif96 Apr 7, 2023
505d375
Merge branch 'master' into Switchport_Vlan
ridahanif96 Apr 7, 2023
bb17b58
build failure fixes
ridahanif96 Apr 10, 2023
ece9730
Build fixes
ridahanif96 Apr 10, 2023
c46192c
Build failure Fixes
ridahanif96 Apr 10, 2023
57e8d8f
Fixes for Failure
ridahanif96 Apr 11, 2023
a24d373
fixes
ridahanif96 Apr 26, 2023
1e1c47e
Resolving Merge Conflicts
ridahanif96 Apr 27, 2023
831e2cd
Merge branch 'master' into Switchport_Vlan
ridahanif96 Apr 27, 2023
8a3dbce
Failed Conditions Fixes
ridahanif96 Apr 27, 2023
e8f1620
Merge branch 'Switchport_Vlan' of https://github.com/ridahanif96/soni…
ridahanif96 Apr 27, 2023
00f2a92
Build Fixes for Vlantestcases
ridahanif96 May 3, 2023
753ecb9
Build Failure & Merge Conflicts Fixes
ridahanif96 May 7, 2023
72e6e66
Merge branch 'master' into Switchport_Vlan
ridahanif96 May 8, 2023
fdd0373
Vlan member Test update for build failure
ridahanif96 May 8, 2023
cd6fcdd
Merge branch 'Switchport_Vlan' of https://github.com/ridahanif96/soni…
ridahanif96 May 8, 2023
1c9e91a
Build Failure Libyang issues
ridahanif96 May 9, 2023
f138005
Libyang fixes PortChannel
ridahanif96 May 9, 2023
2d221c6
Libyang error fixes
ridahanif96 May 9, 2023
5ec50f7
Vlan Must condition Libyang error
ridahanif96 May 10, 2023
cd01710
Build Failure Libyang
ridahanif96 May 10, 2023
92dae69
Libyang failure
ridahanif96 May 10, 2023
30e4af3
Failures
ridahanif96 May 10, 2023
431f8f8
Fixing BUILD for Validations
ridahanif96 May 10, 2023
44d3d19
Merge branch 'sonic-net:master' into Switchport_Vlan
ridahanif96 May 11, 2023
b0c23ae
Fixing Errors
ridahanif96 May 11, 2023
d9b5b7b
Merge branch 'sonic-net:master' into Switchport_Vlan
ridahanif96 May 14, 2023
9165049
Merge branch 'Switchport_Vlan' of https://github.com/ridahanif96/soni…
ridahanif96 May 14, 2023
e96e915
Build Failure Fixes
ridahanif96 May 14, 2023
c5a91d6
Merge branch 'master' into Switchport_Vlan
ridahanif96 May 18, 2023
d2634c1
Fix for Libyang errors
ridahanif96 May 19, 2023
330e086
Merge branch 'master' into Switchport_Vlan
ridahanif96 May 19, 2023
150543b
Fixes for Libyang errors
ridahanif96 May 19, 2023
44893af
Merge branch 'Switchport_Vlan' of https://github.com/ridahanif96/soni…
ridahanif96 May 19, 2023
2c766e0
Fixes for lib errors
ridahanif96 May 19, 2023
e0d4312
Fixing Errror
ridahanif96 May 21, 2023
623f728
Fixing errors for PortChannel
ridahanif96 May 21, 2023
2838944
Fixixng PortChannel Error
ridahanif96 May 22, 2023
9e1ce95
Fixing Errors
ridahanif96 May 23, 2023
bb01427
Portchannel fixing
ridahanif96 May 23, 2023
cf3d239
Cisco Port Errors
ridahanif96 May 23, 2023
5f9a751
Failure resolve
ridahanif96 May 23, 2023
6cdc918
Fix
ridahanif96 May 24, 2023
fe7072e
Fix
ridahanif96 May 24, 2023
fc13204
Fix
ridahanif96 May 24, 2023
16dbc64
Fix
ridahanif96 May 24, 2023
78121d4
Fix
ridahanif96 May 24, 2023
27d302b
Merge branch 'master' into Switchport_Vlan
ridahanif96 May 24, 2023
cf11a19
Fix for voq
ridahanif96 May 24, 2023
32fa54c
Merge conflicts
ridahanif96 May 24, 2023
aa1c6c1
Merge conflictss
ridahanif96 May 24, 2023
cbb70e7
Fix voq errors
ridahanif96 May 25, 2023
99fb006
VOQ Fix
ridahanif96 May 25, 2023
ed958ae
Fix
ridahanif96 May 25, 2023
81853ad
Port Config error in whl file
ridahanif96 May 25, 2023
5baedc3
J2 Fixes
ridahanif96 May 25, 2023
262fc28
Fix for J2
ridahanif96 May 25, 2023
86c5e9b
VOQ Macsec failure
ridahanif96 May 26, 2023
d27f4c5
Fixes for voq and macsec
ridahanif96 May 26, 2023
99bbc12
Port ini
ridahanif96 May 26, 2023
9ca5c77
Fix for failure nokia
ridahanif96 May 27, 2023
40fb451
Fix Port.ini
ridahanif96 May 28, 2023
39b8efa
Fix for device images
ridahanif96 May 28, 2023
cac094b
Fix for J2
ridahanif96 May 29, 2023
7288fe8
Fixing Chassis and J2
ridahanif96 May 29, 2023
2811a4a
Fix for Port multi-npu-data
ridahanif96 May 29, 2023
d753464
Fix for TestJ2Files
ridahanif96 May 30, 2023
c105305
Fix for J2Files.py errors
ridahanif96 May 30, 2023
1bb9fbc
Added new File t0-sample-config-J2.ini for J2Files build conflicts
ridahanif96 May 30, 2023
21c0724
Fix for J2Files using t0-sample-port.ini
ridahanif96 May 30, 2023
38ee257
Fix for J2Files revert
ridahanif96 Jun 1, 2023
ee7f3be
Fix
ridahanif96 Jun 1, 2023
bcff4f1
Fix
ridahanif96 Jun 1, 2023
321286e
Fix
ridahanif96 Jun 9, 2023
675094e
Merge branch 'master' into Switchport_Vlan
ridahanif96 Jun 9, 2023
cd3c5ce
Fixing Port multi-npu-data
ridahanif96 Jun 9, 2023
0c87653
Merge branch 'Switchport_Vlan' of https://github.com/ridahanif96/soni…
ridahanif96 Jun 9, 2023
a4129c7
Fix for Hwsku files
ridahanif96 Jun 12, 2023
4c17015
Fix for voq
ridahanif96 Jun 13, 2023
629e3f4
FIX
ridahanif96 Jun 13, 2023
12b293d
FIX FOR SAMPLE_PLATFORM
ridahanif96 Jun 13, 2023
9da166f
Fix
ridahanif96 Jun 13, 2023
85fc0f7
Fixing
ridahanif96 Jun 13, 2023
cc9cd22
fixing
ridahanif96 Jun 13, 2023
6804e33
Fix
ridahanif96 Jun 13, 2023
ad8bf7f
Fix
ridahanif96 Jun 14, 2023
6adecfc
Merge branch 'master' into Switchport_Vlan
ridahanif96 Jun 14, 2023
c4afe76
Fixing for Port-config
ridahanif96 Jun 15, 2023
7191e23
Merge branch 'master' into Switchport_Vlan
ridahanif96 Jun 26, 2023
65388a8
build fixes
ridahanif96 Jun 26, 2023
d12c452
T0 Errors fix
ridahanif96 Jun 27, 2023
fe99edd
Autonegfix
ridahanif96 Jun 27, 2023
363170a
Extra eternet errors fix
ridahanif96 Jun 28, 2023
b74bde4
Minigraph fixes
ridahanif96 Jun 28, 2023
f395373
fix for portchannel
ridahanif96 Jun 30, 2023
241b2f1
Fix cisco errors
ridahanif96 Jun 30, 2023
5aaf667
Fix for cisco voq
ridahanif96 Jul 1, 2023
2d981a3
Fix for cisco 100g
ridahanif96 Jul 1, 2023
f741f92
Test for mgmt build failures
ridahanif96 Jul 2, 2023
496d19f
Merge branch 'master' into Switchport_Vlan
ridahanif96 Jul 6, 2023
4aa82f5
Merge branch 'master' into Switchport_Vlan
ridahanif96 Jul 13, 2023
4d7afc0
Merge branch 'sonic-net:master' into Switchport_Vlan
ridahanif96 Jul 20, 2023
04833a3
Merge branch 'master' into Switchport_Vlan
ridahanif96 Aug 16, 2023
e440c51
Delete sample_port_config-3.ini
ridahanif96 Aug 25, 2023
04695fe
Merge branch 'sonic-net:master' into Switchport_Vlan
ridahanif96 Aug 31, 2023
3035ac7
Merge branch 'master' into Switchport_Vlan
ridahanif96 Sep 10, 2023
d3cb45c
Merge branch 'sonic-net:master' into Switchport_Vlan
ridahanif96 Sep 18, 2023
c8156e7
Merge branch 'sonic-net:master' into Switchport_Vlan
ridahanif96 Sep 25, 2023
4630b51
Fix for port with mode
ridahanif96 Sep 25, 2023
a4ddd16
Fix for sample_port _data-3.ini
ridahanif96 Sep 27, 2023
f25190f
fix for cisco-8111-port
ridahanif96 Sep 27, 2023
d4d6543
fixes for Update
ridahanif96 Sep 28, 2023
496ad82
Fix
ridahanif96 Sep 29, 2023
8df6912
fix for cisco
ridahanif96 Sep 29, 2023
1df283a
Fix for configurations
ridahanif96 Sep 29, 2023
6206f7d
fixes
ridahanif96 Sep 29, 2023
aeb5eba
fix for membership
ridahanif96 Sep 30, 2023
7aeb9d9
fix for vlan
ridahanif96 Sep 30, 2023
a5af2c6
fix for portchannel
ridahanif96 Sep 30, 2023
a28fef3
fix for membership
ridahanif96 Sep 30, 2023
5839477
fix
ridahanif96 Sep 30, 2023
b0d4bee
fix
ridahanif96 Sep 30, 2023
39cb4b4
fix for mode
ridahanif96 Oct 1, 2023
17dc27b
mode routed
ridahanif96 Oct 1, 2023
7316839
fix for j2
ridahanif96 Oct 1, 2023
d29ac46
Fix for ports
ridahanif96 Oct 2, 2023
023e067
fixing J2 template
ridahanif96 Oct 2, 2023
777d8dd
fix for membership
ridahanif96 Oct 7, 2023
24612b4
Fix for yang model
ridahanif96 Oct 7, 2023
efe6b54
Fix
ridahanif96 Oct 18, 2023
bc5bde1
Fix for mode
ridahanif96 Oct 22, 2023
b980944
routed all
ridahanif96 Oct 24, 2023
5044d4e
mode remove from Platform json
ridahanif96 Oct 24, 2023
98b893a
fix
ridahanif96 Oct 24, 2023
c7e6141
Fix
ridahanif96 Oct 24, 2023
85abc71
test for sample port
ridahanif96 Oct 24, 2023
dfff067
FIx
ridahanif96 Oct 24, 2023
ac48f1a
Fix
ridahanif96 Oct 25, 2023
be4593f
Fix for portchannel
ridahanif96 Oct 25, 2023
7a23689
Fix for j2
ridahanif96 Oct 25, 2023
696900f
Test for fix
ridahanif96 Oct 25, 2023
d18cc76
FIX FOR J2
ridahanif96 Oct 29, 2023
9057783
Removed T0 Files
ridahanif96 Oct 30, 2023
c1e5756
Merge branch 'master' into Switchport_Vlan
ridahanif96 Nov 9, 2023
0bd21ee
Switchport Mode YANG model for mode attribute
ridahanif96 Nov 9, 2023
233a56d
fix for pc
ridahanif96 Nov 9, 2023
eec283f
switchport mode fix
ridahanif96 Nov 9, 2023
a123517
Fix for mode trunk on vlan membership ports
ridahanif96 Nov 9, 2023
df2c095
Merge branch 'master' into Switchport_Vlan
ridahanif96 Nov 9, 2023
8b89ba7
Mode with trunk for vlan membership in cffgen
ridahanif96 Nov 9, 2023
737f597
minigraph mode trunk
ridahanif96 Nov 11, 2023
9e09e42
dump test
ridahanif96 Nov 11, 2023
659a6fb
Fixing mode issues in minigraph
ridahanif96 Nov 12, 2023
8813435
fix for minigraph
ridahanif96 Nov 12, 2023
bee9d36
fix
ridahanif96 Nov 12, 2023
eb2f9b6
fix fpr portchannel
ridahanif96 Nov 12, 2023
7320871
Fix for portchannel
ridahanif96 Nov 14, 2023
627089d
fixx
ridahanif96 Nov 15, 2023
8f90416
Fix for portchannel
ridahanif96 Nov 15, 2023
2bbb0db
Fix for error
ridahanif96 Nov 17, 2023
7e2e6ef
MOde fix
ridahanif96 Nov 19, 2023
ba1059c
Merge branch 'master' into Switchport_Vlan
ridahanif96 Nov 21, 2023
eccc625
Fix for misplaced if
ridahanif96 Nov 21, 2023
f7c5881
Fix for python error
ridahanif96 Nov 21, 2023
c58b076
Fix
ridahanif96 Nov 22, 2023
8b4cd2e
Fix for minigraph xml check
ridahanif96 Nov 22, 2023
7d99c6a
Fix for port error
ridahanif96 Nov 22, 2023
e7d262b
Revert "Fix for minigraph xml check"
ridahanif96 Nov 22, 2023
a13057b
Revert "Fix for portchannel"
ridahanif96 Nov 22, 2023
4fde0c0
fix for minigraph
ridahanif96 Nov 22, 2023
757aa24
fix
ridahanif96 Nov 22, 2023
44c8942
Merge branch 'sonic-net:master' into Switchport_Vlan
ridahanif96 Nov 23, 2023
6bbf7fd
Fix for portchannel01
ridahanif96 Nov 23, 2023
197d32f
Fixing MUST Case error
ridahanif96 Nov 24, 2023
8e45faf
fix for errors
ridahanif96 Nov 24, 2023
3fb58ec
fix for J2
ridahanif96 Nov 25, 2023
afb390d
Fix for J2 & cffgen
ridahanif96 Nov 25, 2023
9900404
Fixing issues
ridahanif96 Nov 26, 2023
6ca6c6a
Fixing J2
ridahanif96 Nov 26, 2023
a7e1f09
Fixing errors
ridahanif96 Nov 27, 2023
3f1dec0
Fix t0
ridahanif96 Nov 27, 2023
64d4228
Fix to errorrr
ridahanif96 Nov 27, 2023
6f2590c
Fix for mode
ridahanif96 Nov 27, 2023
9ede88c
Fix for cffgeen
ridahanif96 Nov 27, 2023
bfd3b7d
Fix for J2
ridahanif96 Nov 27, 2023
deeea72
Fix for cfggen errors
ridahanif96 Nov 28, 2023
96c7e8b
Fix for portchannel
ridahanif96 Nov 28, 2023
4fe6861
Fix for Port
ridahanif96 Nov 28, 2023
38e71ea
Fix
ridahanif96 Nov 28, 2023
3dc4290
fix for rs
ridahanif96 Nov 29, 2023
fe8e4ee
FIx for minigraph
ridahanif96 Nov 29, 2023
f7c8b93
Fix for minigraph.py
ridahanif96 Nov 29, 2023
b080dfa
Fix for autoneg
ridahanif96 Nov 29, 2023
9e4cc6a
Fix for autoneg ini
ridahanif96 Nov 29, 2023
924356c
Yang validation
ridahanif96 Nov 30, 2023
c12bc30
dump fix
ridahanif96 Nov 30, 2023
8b7d597
Merge branch 'master' into Switchport_Vlan
ridahanif96 Dec 22, 2023
18376f0
Must condition removal to resolve build failure
ridahanif96 Dec 22, 2023
1e9925a
Fix for failures
ridahanif96 Dec 23, 2023
ce73717
Fix for Elastic test
ridahanif96 Dec 24, 2023
d6d6d7a
Merge branch 'sonic-net:master' into Switchport_Vlan
ridahanif96 Dec 28, 2023
059b51c
Removed config-engine changes
ridahanif96 Dec 30, 2023
fe06b4a
Fix for failure
ridahanif96 Dec 30, 2023
ca8069a
Merge branch 'sonic-net:master' into Switchport_Vlan
ridahanif96 Dec 31, 2023
95cc52f
Git diff for src/sonic-config-engine/
ridahanif96 Jan 1, 2024
546c55d
Removed unnessary changes
ridahanif96 Jan 2, 2024
2791722
Resolving Unessary Errors
ridahanif96 Jan 2, 2024
0afaa1e
Missing Port invlaid mode fix
ridahanif96 Jan 2, 2024
0995ca8
Removed unnecessary lines along with typo indentation errors
ridahanif96 Jan 3, 2024
92e7569
Fix for unnessary lines
ridahanif96 Jan 4, 2024
9d6594c
Fix for spaces at end of lines
ridahanif96 Jan 7, 2024
f180e4a
Fix for spaces
ridahanif96 Jan 8, 2024
4f08b17
fix for deleted space
ridahanif96 Jan 10, 2024
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions src/sonic-yang-models/tests/files/sample_config_db.json
Original file line number Diff line number Diff line change
Expand Up @@ -86,6 +86,7 @@
],
"tpid": "0x8100",
"mtu": "9100",
"mode": "access",
"lacp_key": "auto"
},
"PortChannel0004": {
Expand All @@ -96,6 +97,7 @@
],
"tpid": "0x9200",
"mtu": "9100",
"mode": "trunk",
"lacp_key": "auto"
},
"PortChannel2": {
Expand Down
15 changes: 15 additions & 0 deletions src/sonic-yang-models/tests/yang_model_tests/tests/port.json
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,21 @@
"PORT_VALID_MTU_TEST_2": {
"desc": "PORT_VALID_MTU_TEST_2 no failure."
},
"PORT_VALID_MODE_TEST_1": {
"desc": "PORT_VALID_MODE_TEST_1 no failure.",
"eStrKey" : "Pattern",
"eStr": ["routed|access|trunk"]
},
"PORT_VALID_MODE_TEST_2": {
"desc": "PORT_VALID_MODE_TEST_2 no failure.",
"eStrKey" : "Pattern",
"eStr": ["routed|access|trunk"]
},
"PORT_VALID_MODE_TEST_3": {
"desc": "PORT_VALID_MODE_TEST_3 no failure.",
"eStrKey" : "Pattern",
"eStr": ["routed|access|trunk"]
},
"PORT_VALID_AUTONEG_TEST_1": {
"desc": "PORT_VALID_AUTONEG_TEST_1 no failure."
},
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -29,6 +29,7 @@
"description": "Ethernet8",
"fec": "rs",
"lanes": "65",
"mode": "access",
"mtu": 9000,
"pfc_asym": "on",
"name": "Ethernet8",
Expand Down Expand Up @@ -69,6 +70,51 @@
}
}
},
"PORT_VALID_MODE_TEST_1": {
"sonic-port:sonic-port": {
"sonic-port:PORT": {
"PORT_LIST": [
{
"name": "Ethernet8",
"alias": "eth8",
"lanes": "65",
"speed": 25000,
"mode": "access"
}
]
}
}
},
"PORT_VALID_MODE_TEST_2": {
"sonic-port:sonic-port": {
"sonic-port:PORT": {
"PORT_LIST": [
{
"name": "Ethernet8",
"alias": "eth8",
"lanes": "65",
"speed": 25000,
"mode": "trunk"
}
]
}
}
},
"PORT_VALID_MODE_TEST_3": {
"sonic-port:sonic-port": {
"sonic-port:PORT": {
"PORT_LIST": [
{
"name": "Ethernet8",
"alias": "eth8",
"lanes": "65",
"speed": 25000,
"mode": "routed"
}
]
}
}
},
"PORT_VALID_AUTONEG_TEST_1": {
"sonic-port:sonic-port": {
"sonic-port:PORT": {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@
"description": "Ethernet0",
"lanes": "65",
"mtu": 9000,
"mode": "access",
"name": "Ethernet0",
"tpid": "0x8100",
"speed": 25000
Expand All @@ -28,6 +29,7 @@
"mtu": "9100",
"tpid": "0x8100",
"lacp_key": "auto",
"mode": "access",
"name": "PortChannel0001"
}
]
Expand Down
8 changes: 8 additions & 0 deletions src/sonic-yang-models/yang-models/sonic-port.yang
Original file line number Diff line number Diff line change
Expand Up @@ -51,6 +51,14 @@ module sonic-port{
length 1..128;
}
}

leaf mode {
description "SwitchPort Modes values will be from "routed|access|trunk. Default val is routed. ";
ridahanif96 marked this conversation as resolved.
Show resolved Hide resolved
type string {
pattern "routed|access|trunk";
}
ridahanif96 marked this conversation as resolved.
Show resolved Hide resolved
default "routed";
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The default value will introduce disruptive change. The current behavior is conditional "default value".

}

leaf description {
type string {
Expand Down
9 changes: 9 additions & 0 deletions src/sonic-yang-models/yang-models/sonic-portchannel.yang
Original file line number Diff line number Diff line change
Expand Up @@ -80,6 +80,15 @@ module sonic-portchannel {
range 1..1024;
}
}

leaf mode {
description "PortChannel Modes values will be from "routed|access|trunk. Default val is routed.";
ridahanif96 marked this conversation as resolved.
Show resolved Hide resolved
ridahanif96 marked this conversation as resolved.
Show resolved Hide resolved
type string {
ridahanif96 marked this conversation as resolved.
Show resolved Hide resolved
pattern "routed|access|trunk";
}
default "routed";

}

leaf description {
type string {
Expand Down
8 changes: 8 additions & 0 deletions src/sonic-yang-models/yang-templates/sonic-types.yang.j2
Original file line number Diff line number Diff line change
Expand Up @@ -208,6 +208,14 @@ module sonic-types {
}
}

typedef mode {
ridahanif96 marked this conversation as resolved.
Show resolved Hide resolved
type string {
pattern "routed|access|trunk";
}
description
"SwitchPort Modes for Port & PortChannel";
}

typedef meter_type {
type enumeration {
enum packets;
Expand Down