[Edgecore][AS7326/PDDF] Enhance sonic_platform feature #13809
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: jostar-yang <[email protected]>
|
@FuzailBrcm , please help review |
FuzailBrcm
reviewed
Feb 15, 2023
|
|
||
| class Chassis(PddfChassis): | ||
| """ | ||
| PDDF Platform-specific Chassis class | ||
| """ | ||
|
|
||
| SYSLED_DEV_NAME = "DIAG_LED" |
There was a problem hiding this comment.
So chassis set/get status_led will lead to setting of DIAG led ?
This platform doesn't have SYS_LED ?
There was a problem hiding this comment.
We have DIAG_LED and LOC_LED, and don't have SYS_LED. So use DIAG_LED instead of SYS_LED.
Signed-off-by: michael_shih <[email protected]>
Signed-off-by: michael_shih <[email protected]>
8 tasks
This was referenced Oct 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why I did it
How I did it
Modify sonic_platorm, thermal plan code and pddf-device.json
How to verify it
Test show cmd.
root@sonic:/home/admin# show platform fan
Drawer LED FAN Speed Direction Presence Status Timestamp
FanTray1 green FAN-1F 38% exhaust Present OK 20230215 17:46:46
FanTray1 green FAN-1R 38% exhaust Present OK 20230215 17:46:46
FanTray2 green FAN-2F 38% exhaust Present OK 20230215 17:46:46
FanTray2 green FAN-2R 38% exhaust Present OK 20230215 17:46:46
FanTray3 green FAN-3F 38% exhaust Present OK 20230215 17:46:46
FanTray3 green FAN-3R 38% exhaust Present OK 20230215 17:46:46
FanTray4 green FAN-4F 38% exhaust Present OK 20230215 17:46:46
FanTray4 green FAN-4R 38% exhaust Present OK 20230215 17:46:46
FanTray5 green FAN-5F 38% exhaust Present OK 20230215 17:46:46
FanTray5 green FAN-5R 38% exhaust Present OK 20230215 17:46:46
FanTray6 green FAN-6F 38% exhaust Present OK 20230215 17:46:46
FanTray6 green FAN-6R 38% exhaust Present OK 20230215 17:46:46
N/A N/A PSU-1 FAN-1 0% Present Not OK 20230215 17:46:48
N/A N/A PSU-2 FAN-1 33% exhaust Present OK 20230215 17:46:48
root@sonic:/home/admin#
root@sonic:/home/admin# show platform temp
Sensor Temperature High TH Low TH Crit High TH Crit Low TH Warning Timestamp
MB_FrontMAC_temp(0x49) 30 80.0 N/A N/A N/A False 20230215 17:46:48
MB_LeftCenter_temp(0x4A) 26 80.0 N/A N/A N/A False 20230215 17:46:48
MB_RearMAC_temp(0x48) 32.5 80.0 N/A N/A N/A False 20230215 17:46:48
PSU-1 temp sensor 1 0 N/A N/A N/A N/A False 20230215 17:46:48
PSU-2 temp sensor 1 31 N/A N/A N/A N/A False 20230215 17:46:48
Which release branch to backport (provide reason below if selected)
Description for the changelog
Ensure to add label/tag for the feature raised. example - PR#2174 under sonic-utilities repo. where, Generic Config and Update feature has been labelled as GCU.
Link to config_db schema for YANG module changes
A picture of a cute animal (not mandatory but encouraged)