Add YANG model for FABRIC_PORT #14282
Conversation
| } | ||
| } | ||
|
|
||
| leaf isolateStatus { |
There was a problem hiding this comment.
please add description of the leaf nodes
| } | ||
| } | ||
|
|
||
| leaf lanes { |
There was a problem hiding this comment.
I think, the fabric port configuration without specifying lanes is not valid, can we add this field as mandatory
| } | ||
|
|
||
| leaf isolateStatus { | ||
| type string { |
There was a problem hiding this comment.
if the isolateStatus is not speicified should there be a default value?
|
/Azp run Azure.sonic-buildimage |
|
Commenter does not have sufficient privileges for PR 14282 in repo sonic-net/sonic-buildimage |
|
/Azpw run Azure.sonic-buildimage |
|
/AzurePipelines run Azure.sonic-buildimage |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
@jfeng-arista Could you resolve conflict? |
sure |
|
@arlakshm can we merge this PR before the 202305 cut off? |
|
Hi @jfeng-arista, can you fix the conflict |
|
@jfeng-arista please resolve the conflict so we can try to merge it. |
|
Jie's on FTA for another week. I fixed the conflict locally, but don't have permission to update her repo. |
@kenneth-arista Thanks for responding. If we choose to wait for @jfeng-arista to address this it would take at least another week. |
|
closing this PR to avoid confusion |
#### Why I did it Introduce YANG model for FABRIC in CONFIG_DB, which was added in #14170. #### How I did it This is a clone of @jfeng-arista's PR #14282 to resolve conflicts with upstream changes. #### How to verify it Passing pipeline build is sufficient.
#### Why I did it Introduce YANG model for FABRIC in CONFIG_DB, which was added in sonic-net#14170. #### How I did it This is a clone of @jfeng-arista's PR sonic-net#14282 to resolve conflicts with upstream changes. #### How to verify it Passing pipeline build is sufficient.
#### Why I did it Introduce YANG model for FABRIC in CONFIG_DB, which was added in #14170. #### How I did it This is a clone of @jfeng-arista's PR #14282 to resolve conflicts with upstream changes. #### How to verify it Passing pipeline build is sufficient.
#### Why I did it Introduce YANG model for FABRIC in CONFIG_DB, which was added in sonic-net#14170. #### How I did it This is a clone of @jfeng-arista's PR sonic-net#14282 to resolve conflicts with upstream changes. #### How to verify it Passing pipeline build is sufficient.
Why I did it
YANG model for FABRIC in CONFIG_DB was added in #14170.
Need to wait #14170 get merged first.
How I did it
Added new YANG model and associated unit tests.
How to verify it
Passing unit tests
Which release branch to backport (provide reason below if selected)
Description for the changelog
Ensure to add label/tag for the feature raised. example - PR#2174 under sonic-utilities repo. where, Generic Config and Update feature has been labelled as GCU.
Link to config_db schema for YANG module changes
A picture of a cute animal (not mandatory but encouraged)