Fix eth0 hardware numbering using udev for AS4630-54PE platform. #16464
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why I did it
Management port currently broken for Edgecore AS4630-54PE platform due to NIC hardware numbering.
Work item tracking
How I did it
Created new PR with typo from Edgecore in original PR fixed. Here is a link to the old PR that has broken logic:
#9560
How to verify it
Here is current master branch on AS4630-54PE with broken eth0 (note RUNNING flag):
root@t9845swta0001:/home/admin# ifconfig eth0
eth0: flags=4099<UP,BROADCAST,MULTICAST> mtu 1500
inet 10.121.38.158 netmask 255.255.254.0 broadcast 10.121.39.255
ether 90:3c:b3:2c🆎67 txqueuelen 1000 (Ethernet)
RX packets 0 bytes 0 (0.0 B)
RX errors 0 dropped 0 overruns 0 frame 0
TX packets 0 bytes 0 (0.0 B)
TX errors 0 dropped 0 overruns 0 carrier 0 collisions 0
Here is master branch with fix applied:
root@t9845swta0001:/home/admin# ifconfig eth0
eth0: flags=4163<UP,BROADCAST,RUNNING,MULTICAST> mtu 1500
inet 10.121.38.158 netmask 255.255.254.0 broadcast 10.121.39.255
inet6 fe80::923c:b3ff:fe2c:ab66 prefixlen 64 scopeid 0x20
ether 90:3c:b3:2c🆎66 txqueuelen 1000 (Ethernet)
RX packets 1718 bytes 264071 (257.8 KiB)
RX errors 0 dropped 0 overruns 0 frame 0
TX packets 461 bytes 53985 (52.7 KiB)
TX errors 0 dropped 0 overruns 0 carrier 0 collisions 0
With fix applied, able to ssh to management port IP.
Which release branch to backport (provide reason below if selected)
Fix should be backported on the branches below. eth0 management port not functional.
Tested branch (Please provide the tested image version)
Description for the changelog
Link to config_db schema for YANG module changes
A picture of a cute animal (not mandatory but encouraged)