-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
T2-VOQ-Chassis: VS support #18512
T2-VOQ-Chassis: VS support #18512
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
as comments.
…age support for VS (#3250) ### What I did For T2-Chassis VS support, we are adding new sonic_platform package for vs platforms. Please refer sonic-net/sonic-buildimage#18512 for more details. Due to this new platform package, need to modify excpetion handling as now the Module would be found, but the metadata file will not be found for pizzabox vs platforms. #### How I did it Modified the exception handling logic. MSFT ADO: 27414904 #### How to verify it Bring up vms-kvm-t0 topology. ran show interface status. The output is proper. PS: the Main PR(sonic-net/sonic-buildimage#18512) is dependent on this PR to be merged in first.
Looks like there's a new loganalyzer error message on t0:
Is this expected? Does it need to be added to the ignore list? |
Thanks @saiarcot895 .. Added above to loganalyzer_ignore file as discussed. PR sonic-net/sonic-mgmt#12345 |
/azp run |
Commenter does not have sufficient privileges for PR 18512 in repo sonic-net/sonic-buildimage |
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
@deepak-singhal0408 use |
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
/azpw run |
/AzurePipelines run |
Azure Pipelines successfully started running 1 pipeline(s). |
@arlakshm @judyjoseph @abdosi could you please help review when get a chance? Thanks! |
@deepak-singhal0408 Cherry-pick conflict for MSFT repo 202205 branch. Please raise PR directly to MSFT repo and mention this PRin the new PR. |
@deepak-singhal0408 , seems like swss PR checks are failing with this docker change. Could you confirm all swss tests were tested with this docker vs build? |
@prsunny , this PR is merged in sonic-buildimage on April 19th. And there is a PR merge in sonic-swss on April 22nd(sonic-net/sonic-swss#3118). The PR checker for April 22nd change would have already taken my changes.. right? May I know why you think this PR would have caused issue? |
…age support for VS (sonic-net#3250) ### What I did For T2-Chassis VS support, we are adding new sonic_platform package for vs platforms. Please refer sonic-net/sonic-buildimage#18512 for more details. Due to this new platform package, need to modify excpetion handling as now the Module would be found, but the metadata file will not be found for pizzabox vs platforms. #### How I did it Modified the exception handling logic. MSFT ADO: 27414904 #### How to verify it Bring up vms-kvm-t0 topology. ran show interface status. The output is proper. PS: the Main PR(sonic-net/sonic-buildimage#18512) is dependent on this PR to be merged in first.
…age support for VS (#3250) ### What I did For T2-Chassis VS support, we are adding new sonic_platform package for vs platforms. Please refer sonic-net/sonic-buildimage#18512 for more details. Due to this new platform package, need to modify excpetion handling as now the Module would be found, but the metadata file will not be found for pizzabox vs platforms. #### How I did it Modified the exception handling logic. MSFT ADO: 27414904 #### How to verify it Bring up vms-kvm-t0 topology. ran show interface status. The output is proper. PS: the Main PR(sonic-net/sonic-buildimage#18512) is dependent on this PR to be merged in first.
@deepak-singhal0408 Where can I find |
Hi, @deepak-singhal0408 , I got the same error
|
Hi @yutongzhang-microsoft , please give a try with this Fix. sonic-net/sonic-host-services#133 |
How about stopping raising an exception instead of catching |
I agree with you, some other commands also failed because of this error. |
Why I did it
Changes to ensure sonic_vs.img has everything required for it to be emulated as T2-VOQ-Chassis: Supervisor/Linecard..
With this change,
Work item tracking
27402561
How I did it
Following Changes are made as part of this PR:
3.1: To ensure, that database containers bring up goes through. The database containers on linecards fetch the supervisor slot_num, current_slot num etc.
PS: This package will be available on pizza box vs platforms as well. However, it will be noop there, as the package expects a metadata file, which will only be available on chassis VS platforms.
How to verify it
Which release branch to backport (provide reason below if selected)
Tested branch (Please provide the tested image version)
Description for the changelog
Link to config_db schema for YANG module changes
A picture of a cute animal (not mandatory but encouraged)